From 83195d0e7206226e1fb7627ab19d81523aa63d13 Mon Sep 17 00:00:00 2001
From: AlexDev_ <56083016+alexdev03@users.noreply.github.com>
Date: Wed, 8 Nov 2023 10:00:59 +0100
Subject: [PATCH] Fixed vanish problem (#116)

---
 .../velocitab/tab/PlayerTabList.java          | 22 +++++++++----------
 .../velocitab/vanish/VanishManager.java       |  2 ++
 2 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/src/main/java/net/william278/velocitab/tab/PlayerTabList.java b/src/main/java/net/william278/velocitab/tab/PlayerTabList.java
index fd4891c..b8ad74f 100644
--- a/src/main/java/net/william278/velocitab/tab/PlayerTabList.java
+++ b/src/main/java/net/william278/velocitab/tab/PlayerTabList.java
@@ -199,8 +199,8 @@ public class PlayerTabList {
                 .build());
     }
 
-    private void addEntry(@NotNull TabPlayer player, @NotNull TabList tabList, @NotNull Component displayName) {
-        TabListEntry.builder()
+    private TabListEntry createEntry(@NotNull TabPlayer player, @NotNull TabList tabList, @NotNull Component displayName) {
+        return TabListEntry.builder()
                 .profile(player.getPlayer().getGameProfile())
                 .displayName(displayName)
                 .latency(0)
@@ -437,17 +437,15 @@ public class PlayerTabList {
     public void unVanishPlayer(@NotNull TabPlayer tabPlayer) {
         final UUID uuid = tabPlayer.getPlayer().getUniqueId();
 
-        tabPlayer.getDisplayName(plugin).thenAccept(c -> {
-            players.values().forEach(p -> {
-                if (p.getPlayer().equals(tabPlayer.getPlayer())) {
-                    return;
-                }
+        tabPlayer.getDisplayName(plugin).thenAccept(c -> players.values().forEach(p -> {
+            if (p.getPlayer().equals(tabPlayer.getPlayer())) {
+                return;
+            }
 
-                if (!p.getPlayer().getTabList().containsEntry(uuid)) {
-                    addEntry(tabPlayer, p.getPlayer().getTabList(), c);
-                }
-            });
-        });
+            if (!p.getPlayer().getTabList().containsEntry(uuid)) {
+                p.getPlayer().getTabList().addEntry(createEntry(tabPlayer, p.getPlayer().getTabList(), c));
+            }
+        }));
 
     }
 }
diff --git a/src/main/java/net/william278/velocitab/vanish/VanishManager.java b/src/main/java/net/william278/velocitab/vanish/VanishManager.java
index 688c19d..ef8e733 100644
--- a/src/main/java/net/william278/velocitab/vanish/VanishManager.java
+++ b/src/main/java/net/william278/velocitab/vanish/VanishManager.java
@@ -56,6 +56,7 @@ public class VanishManager {
     public void vanishPlayer(@NotNull Player player) {
         final Optional<TabPlayer> tabPlayer = plugin.getTabList().getTabPlayer(player);
         if (tabPlayer.isEmpty()) {
+            plugin.log("Failed to vanish player " + player.getUsername() + " as they are not in the tab list");
             return;
         }
 
@@ -66,6 +67,7 @@ public class VanishManager {
     public void unVanishPlayer(@NotNull Player player) {
         final Optional<TabPlayer> tabPlayer = plugin.getTabList().getTabPlayer(player);
         if (tabPlayer.isEmpty()) {
+            plugin.log("Failed to unVanish player " + player.getUsername() + " as they are not in the tab list");
             return;
         }