Fix group sync not finding members that are not cached, enable chunking by default. Add GroupSyncResult for being able to interact with role

api/src/main/java/com/discordsrv/api/discord/entity/guild/DiscordGuild.java

@@ -54,6 +54,13 @@ public interface DiscordGuild extends JDAEntity<Guild>, Snowflake {
     @Placeholder("server_member_count")
     int getMemberCount();
 
+    /**
+     * Gets the bot's membership in the server.
+     * @return the connected bot's member
+     */
+    @NotNull
+    DiscordGuildMember getSelfMember();
+
     /**
      * Retrieves a Discord guild member from Discord by id.
      * @param id the id for the Discord guild member

api/src/main/java/com/discordsrv/api/discord/entity/guild/DiscordGuildMember.java

@@ -76,6 +76,13 @@ public interface DiscordGuildMember extends JDAEntity<Member>, Mentionable {
      */
     boolean hasRole(@NotNull DiscordRole role);
 
+    /**
+     * If this member can interact (edit, add/take from members) with the specified role.
+     * @param role the role
+     * @return {@code true} if the member has a role above the specified role or is the server owner
+     */
+    boolean canInteract(@NotNull DiscordRole role);
+
     /**
      * Gives the given role to this member.
      * @param role the role to give

common/src/main/java/com/discordsrv/common/config/main/MemberCachingConfig.java

@@ -34,7 +34,7 @@ public class MemberCachingConfig {
     public boolean all = false;
 
     @Comment("If members should be cached at startup, this requires the \"Server Members Intent\"")
-    public boolean chunk = false;
+    public boolean chunk = true;
 
     @Comment("Filter for which servers should be cached at startup")
     public GuildFilter chunkingServerFilter = new GuildFilter();

common/src/main/java/com/discordsrv/common/discord/api/entity/guild/DiscordGuildImpl.java

@@ -56,6 +56,11 @@ public class DiscordGuildImpl implements DiscordGuild {
         return guild.getMemberCount();
     }
 
+    @Override
+    public @NotNull DiscordGuildMember getSelfMember() {
+        return discordSRV.discordAPI().getGuildMember(guild.getSelfMember());
+    }
+
     @Override
     public @NotNull CompletableFuture<DiscordGuildMember> retrieveMemberById(long id) {
         return discordSRV.discordAPI().mapExceptions(() -> guild.retrieveMemberById(id)

common/src/main/java/com/discordsrv/common/discord/api/entity/guild/DiscordGuildMemberImpl.java

@@ -87,6 +87,11 @@ public class DiscordGuildMemberImpl implements DiscordGuildMember {
         return roles.stream().anyMatch(role::equals);
     }
 
+    @Override
+    public boolean canInteract(@NotNull DiscordRole role) {
+        return member.canInteract(role.asJDA());
+    }
+
     @Override
     public CompletableFuture<Void> addRole(@NotNull DiscordRole role) {
         return discordSRV.discordAPI().mapExceptions(() ->

common/src/main/java/com/discordsrv/common/groupsync/GroupSyncModule.java

@@ -18,7 +18,6 @@
 
 package com.discordsrv.common.groupsync;
 
-import com.discordsrv.api.discord.entity.guild.DiscordGuildMember;
 import com.discordsrv.api.discord.entity.guild.DiscordRole;
 import com.discordsrv.api.discord.events.member.role.DiscordMemberRoleAddEvent;
 import com.discordsrv.api.discord.events.member.role.DiscordMemberRoleRemoveEvent;
@@ -316,7 +315,11 @@ public class GroupSyncModule extends AbstractModule<DiscordSRV> {
             return CompletableFuture.completedFuture(GroupSyncResult.ROLE_DOESNT_EXIST);
         }
 
-        DiscordGuildMember member = role.getGuild().getMemberById(userId);
+        if (!role.getGuild().getSelfMember().canInteract(role)) {
+            return CompletableFuture.completedFuture(GroupSyncResult.ROLE_CANNOT_INTERACT);
+        }
+
+        return role.getGuild().retrieveMemberById(userId).thenCompose(member -> {
             if (member == null) {
                 return CompletableFuture.completedFuture(GroupSyncResult.NOT_A_GUILD_MEMBER);
             }
@@ -395,6 +398,7 @@ public class GroupSyncModule extends AbstractModule<DiscordSRV> {
             });
 
             return resultFuture;
+        });
     }
 
     // Listeners & methods to indicate something changed
@@ -636,7 +640,11 @@ public class GroupSyncModule extends AbstractModule<DiscordSRV> {
             return CompletableFuture.completedFuture(GroupSyncResult.ROLE_DOESNT_EXIST);
         }
 
-        DiscordGuildMember member = role.getGuild().getMemberById(userId);
+        if (!role.getGuild().getSelfMember().canInteract(role)) {
+            return CompletableFuture.completedFuture(GroupSyncResult.ROLE_CANNOT_INTERACT);
+        }
+
+        return role.getGuild().retrieveMemberById(userId).thenCompose(member -> {
             if (member == null) {
                 return CompletableFuture.completedFuture(GroupSyncResult.NOT_A_GUILD_MEMBER);
             }
@@ -675,5 +683,6 @@ public class GroupSyncModule extends AbstractModule<DiscordSRV> {
                 resultFuture.complete(result);
             });
             return resultFuture;
+        });
     }
 }

common/src/main/java/com/discordsrv/common/groupsync/enums/GroupSyncResult.java

@@ -34,6 +34,7 @@ public enum GroupSyncResult {
 
     // Errors
     ROLE_DOESNT_EXIST("Role doesn't exist"),
+    ROLE_CANNOT_INTERACT("Bot doesn't have a role above the synced role (cannot interact)"),
     NOT_A_GUILD_MEMBER("User is not part of the server the role is in"),
     PERMISSION_BACKEND_FAIL_CHECK("Failed to check group status, error printed"),
     UPDATE_FAILED("Failed to modify role/group, error printed"),