From 288cc4498eaab1d91f8a6f84c64a12065c6212da Mon Sep 17 00:00:00 2001
From: Kiran Hart <kiran.hart@live.com>
Date: Fri, 30 Apr 2021 12:48:55 -0400
Subject: [PATCH] fixed very bad bug where players can purchase items w.o
 having the correct funds

---
 pom.xml                                           |  2 +-
 .../auctionhouse/guis/GUIAuctionHouse.java        |  5 +++++
 .../auctionhouse/guis/GUIConfirmPurchase.java     | 15 ++++++++-------
 3 files changed, 14 insertions(+), 8 deletions(-)

diff --git a/pom.xml b/pom.xml
index 7427026..51c28fe 100644
--- a/pom.xml
+++ b/pom.xml
@@ -6,7 +6,7 @@
 
     <groupId>ca.tweetzy</groupId>
     <artifactId>auctionhouse</artifactId>
-    <version>2.6.0</version>
+    <version>2.6.2</version>
 
     <properties>
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
diff --git a/src/main/java/ca/tweetzy/auctionhouse/guis/GUIAuctionHouse.java b/src/main/java/ca/tweetzy/auctionhouse/guis/GUIAuctionHouse.java
index cf795a5..3b298ba 100644
--- a/src/main/java/ca/tweetzy/auctionhouse/guis/GUIAuctionHouse.java
+++ b/src/main/java/ca/tweetzy/auctionhouse/guis/GUIAuctionHouse.java
@@ -165,6 +165,11 @@ public class GUIAuctionHouse extends Gui {
                                 return;
                             }
 
+                            if (!AuctionHouse.getInstance().getEconomy().has(e.player, auctionItem.getBasePrice())) {
+                                AuctionHouse.getInstance().getLocale().getMessage("general.notenoughmoney").sendPrefixedMessage(e.player);
+                                return;
+                            }
+
                             cleanup();
                             e.manager.showGUI(e.player, new GUIConfirmPurchase(this.auctionPlayer, auctionItem, false));
                         } else {
diff --git a/src/main/java/ca/tweetzy/auctionhouse/guis/GUIConfirmPurchase.java b/src/main/java/ca/tweetzy/auctionhouse/guis/GUIConfirmPurchase.java
index db308ac..68101c2 100644
--- a/src/main/java/ca/tweetzy/auctionhouse/guis/GUIConfirmPurchase.java
+++ b/src/main/java/ca/tweetzy/auctionhouse/guis/GUIConfirmPurchase.java
@@ -75,6 +75,14 @@ public class GUIConfirmPurchase extends Gui {
             AuctionItem located = AuctionHouse.getInstance().getAuctionItemManager().getItem(this.auctionItem.getKey());
             preItemChecks(e, located);
 
+            // Check economy
+            if (!AuctionHouse.getInstance().getEconomy().has(e.player, this.buyingSpecificQuantity ? this.purchaseQuantity * this.pricePerItem : located.getBasePrice())) {
+                AuctionHouse.getInstance().getLocale().getMessage("general.notenoughmoney").sendPrefixedMessage(e.player);
+                SoundManager.getInstance().playSound(e.player, Settings.SOUNDS_NOT_ENOUGH_MONEY.getString(), 1.0F, 1.0F);
+                e.manager.showGUI(e.player, new GUIAuctionHouse(this.auctionPlayer));
+                return;
+            }
+
             Bukkit.getServer().getScheduler().runTaskAsynchronously(AuctionHouse.getInstance(), () -> {
                 AuctionEndEvent auctionEndEvent = new AuctionEndEvent(Bukkit.getOfflinePlayer(this.auctionItem.getOwner()), e.player, this.auctionItem, AuctionSaleType.WITHOUT_BIDDING_SYSTEM);
                 Bukkit.getServer().getPluginManager().callEvent(auctionEndEvent);
@@ -159,13 +167,6 @@ public class GUIConfirmPurchase extends Gui {
             e.manager.showGUI(e.player, new GUIAuctionHouse(this.auctionPlayer));
             return;
         }
-
-        if (!AuctionHouse.getInstance().getEconomy().has(e.player, located.getBasePrice())) {
-            AuctionHouse.getInstance().getLocale().getMessage("general.notenoughmoney").sendPrefixedMessage(e.player);
-            SoundManager.getInstance().playSound(e.player, Settings.SOUNDS_NOT_ENOUGH_MONEY.getString(), 1.0F, 1.0F);
-            e.manager.showGUI(e.player, new GUIAuctionHouse(this.auctionPlayer));
-            return;
-        }
     }
 
     private ItemStack getPurchaseInfoItem(int qty) {