From 1db24adb5d7eaa84686fd401d995ecd8952e1c40 Mon Sep 17 00:00:00 2001
From: Xephi <xephirot59@gmail.com>
Date: Sat, 5 Dec 2015 19:00:44 +0100
Subject: [PATCH 1/6] Add a wildcard command permission

---
 .../authme/command/CommandInitializer.java    | 20 +++++++++----------
 .../authme/permission/AdminPermission.java    |  7 ++++++-
 .../authme/permission/PlayerPermission.java   |  7 ++++++-
 3 files changed, 22 insertions(+), 12 deletions(-)

diff --git a/src/main/java/fr/xephi/authme/command/CommandInitializer.java b/src/main/java/fr/xephi/authme/command/CommandInitializer.java
index a8dceff04..664c59e57 100644
--- a/src/main/java/fr/xephi/authme/command/CommandInitializer.java
+++ b/src/main/java/fr/xephi/authme/command/CommandInitializer.java
@@ -90,7 +90,7 @@ public final class CommandInitializer {
             .detailedDescription("Register the specified player with the specified password.")
             .withArgument("player", "Player name", false)
             .withArgument("password", "Password", false)
-            .permissions(OP_ONLY, AdminPermission.REGISTER)
+            .permissions(OP_ONLY, AdminPermission.REGISTER, AdminPermission.ALL)
             .executableCommand(new RegisterAdminCommand())
             .build();
 
@@ -101,7 +101,7 @@ public final class CommandInitializer {
             .description("Unregister a player")
             .detailedDescription("Unregister the specified player.")
             .withArgument("player", "Player name", false)
-            .permissions(OP_ONLY, AdminPermission.UNREGISTER)
+            .permissions(OP_ONLY, AdminPermission.UNREGISTER, AdminPermission.ALL)
             .executableCommand(new UnregisterAdminCommand())
             .build();
 
@@ -112,7 +112,7 @@ public final class CommandInitializer {
             .description("Enforce login player")
             .detailedDescription("Enforce the specified player to login.")
             .withArgument("player", "Online player name", true)
-            .permissions(OP_ONLY, PlayerPermission.CAN_LOGIN_BE_FORCED)
+            .permissions(OP_ONLY, PlayerPermission.CAN_LOGIN_BE_FORCED, AdminPermission.ALL)
             .executableCommand(new ForceLoginCommand())
             .build();
 
@@ -124,7 +124,7 @@ public final class CommandInitializer {
             .detailedDescription("Change the password of a player.")
             .withArgument("player", "Player name", false)
             .withArgument("pwd", "New password", false)
-            .permissions(OP_ONLY, AdminPermission.CHANGE_PASSWORD)
+            .permissions(OP_ONLY, AdminPermission.CHANGE_PASSWORD, AdminPermission.ALL)
             .executableCommand(new ChangePasswordAdminCommand())
             .build();
 
@@ -135,7 +135,7 @@ public final class CommandInitializer {
             .description("Player's last login")
             .detailedDescription("View the date of the specified players last login.")
             .withArgument("player", "Player name", true)
-            .permissions(OP_ONLY, AdminPermission.LAST_LOGIN)
+            .permissions(OP_ONLY, AdminPermission.LAST_LOGIN, AdminPermission.ALL)
             .executableCommand(new LastLoginCommand())
             .build();
 
@@ -146,7 +146,7 @@ public final class CommandInitializer {
             .description("Display player accounts")
             .detailedDescription("Display all accounts of a player by his player name or IP.")
             .withArgument("player", "Player name or IP", true)
-            .permissions(OP_ONLY, AdminPermission.ACCOUNTS)
+            .permissions(OP_ONLY, AdminPermission.ACCOUNTS, AdminPermission.ALL)
             .executableCommand(new AccountsCommand())
             .build();
 
@@ -156,7 +156,7 @@ public final class CommandInitializer {
             .labels("getemail", "getmail", "email", "mail")
             .description("Display player's email")
             .detailedDescription("Display the email address of the specified player if set.")
-            .permissions(OP_ONLY, AdminPermission.GET_EMAIL)
+            .permissions(OP_ONLY, AdminPermission.GET_EMAIL, AdminPermission.ALL)
             .withArgument("player", "Player name", true)
             .executableCommand(new GetEmailCommand())
             .build();
@@ -168,7 +168,7 @@ public final class CommandInitializer {
             .labels("chgemail", "chgmail", "setemail", "setmail")
             .description("Change player's email")
             .detailedDescription("Change the email address of the specified player.")
-            .permissions(OP_ONLY, AdminPermission.CHANGE_EMAIL)
+            .permissions(OP_ONLY, AdminPermission.CHANGE_EMAIL, AdminPermission.ALL)
             .withArgument("player", "Player name", false)
             .withArgument("email", "Player email", false)
             .build();
@@ -304,7 +304,7 @@ public final class CommandInitializer {
             .description("Login command")
             .detailedDescription("Command to log in using AuthMeReloaded.")
             .parent(null)
-            .permissions(ALLOWED, PlayerPermission.LOGIN)
+            .permissions(ALLOWED, PlayerPermission.LOGIN, PlayerPermission.ALL_COMMANDS)
             .withArgument("password", "Login password", false)
             .build();
 
@@ -334,7 +334,7 @@ public final class CommandInitializer {
             .detailedDescription("Command to register using AuthMeReloaded.")
             .withArgument("password", "Password", false)
             .withArgument("verifyPassword", "Verify password", false)
-            .permissions(ALLOWED, PlayerPermission.REGISTER)
+            .permissions(ALLOWED, PlayerPermission.REGISTER, PlayerPermission.ALL_COMMANDS)
             .executableCommand(new RegisterCommand())
             .build();
 
diff --git a/src/main/java/fr/xephi/authme/permission/AdminPermission.java b/src/main/java/fr/xephi/authme/permission/AdminPermission.java
index 335875a87..5e1528faf 100644
--- a/src/main/java/fr/xephi/authme/permission/AdminPermission.java
+++ b/src/main/java/fr/xephi/authme/permission/AdminPermission.java
@@ -98,7 +98,12 @@ public enum AdminPermission implements PermissionNode {
     /**
      * Administrator command to reload the plugin configuration.
      */
-    RELOAD("authme.command.admin.reload");
+    RELOAD("authme.command.admin.reload"),
+
+	/**
+	 * Give access to all admin commands
+	 */
+	ALL("authme.command.admin.*");
 
     /**
      * Permission node.
diff --git a/src/main/java/fr/xephi/authme/permission/PlayerPermission.java b/src/main/java/fr/xephi/authme/permission/PlayerPermission.java
index 0488a67ad..38fef5137 100644
--- a/src/main/java/fr/xephi/authme/permission/PlayerPermission.java
+++ b/src/main/java/fr/xephi/authme/permission/PlayerPermission.java
@@ -78,7 +78,12 @@ public enum PlayerPermission implements PermissionNode {
     /**
      * Permission for user to see other accounts.
      */
-    SEE_OTHER_ACCOUNTS("authme.command.player.seeotheraccounts");
+    SEE_OTHER_ACCOUNTS("authme.command.player.seeotheraccounts"),
+
+	/**
+	 *
+	 */
+	ALL_COMMANDS("authme.command.player.*");
 
     /**
      * Permission node.

From 8460725c8300637defac4ee3386e35fd2f90b324 Mon Sep 17 00:00:00 2001
From: Xephi <xephirot59@gmail.com>
Date: Sat, 5 Dec 2015 19:16:16 +0100
Subject: [PATCH 2/6] Part of CommandBuilder rework 1/?

---
 .../authme/command/CommandInitializer.java    | 118 +++++++++---------
 1 file changed, 62 insertions(+), 56 deletions(-)

diff --git a/src/main/java/fr/xephi/authme/command/CommandInitializer.java b/src/main/java/fr/xephi/authme/command/CommandInitializer.java
index 664c59e57..f1765add5 100644
--- a/src/main/java/fr/xephi/authme/command/CommandInitializer.java
+++ b/src/main/java/fr/xephi/authme/command/CommandInitializer.java
@@ -174,74 +174,80 @@ public final class CommandInitializer {
             .build();
 
         // Register the getip command
-        CommandDescription getIpCommand = new CommandDescription(new GetIpCommand(), new ArrayList<String>() {
-            {
-                add("getip");
-                add("ip");
-            }
-        }, "Get player's IP", "Get the IP address of the specified online player.", AUTHME_BASE);
-        getIpCommand.setCommandPermissions(AdminPermission.GET_IP, OP_ONLY);
-        getIpCommand.addArgument(new CommandArgumentDescription("player", "Online player name", true));
+        CommandDescription getIpCommand = CommandDescription.builder()
+        		.executableCommand(new GetIpCommand())
+        		.parent(AUTHME_BASE)
+        		.labels("getip", "ip")
+        		.description("Get player's IP")
+        		.detailedDescription("Get the IP address of the specified online player.")
+        		.permissions(OP_ONLY, AdminPermission.GET_IP, AdminPermission.ALL)
+        		.withArgument("player", "Player Name", false)
+        		.build();
+
 
         // Register the spawn command
-        CommandDescription spawnCommand = new CommandDescription(new SpawnCommand(), new ArrayList<String>() {
-            {
-                add("spawn");
-                add("home");
-            }
-        }, "Teleport to spawn", "Teleport to the spawn.", AUTHME_BASE);
-        spawnCommand.setCommandPermissions(AdminPermission.SPAWN, OP_ONLY);
+        CommandDescription spawnCommand = CommandDescription.builder()
+        		.executableCommand(new SpawnCommand())
+        		.parent(AUTHME_BASE)
+        		.labels("spawn", "home")
+        		.description("Teleport to spawn")
+        		.detailedDescription("Teleport to the spawn")
+        		.permissions(OP_ONLY, AdminPermission.SPAWN, AdminPermission.ALL)
+        		.withArgument("player", "Player Name", false)
+        		.build();
 
         // Register the setspawn command
-        CommandDescription setSpawnCommand = new CommandDescription(new SetSpawnCommand(), new ArrayList<String>() {
-            {
-                add("setspawn");
-                add("chgspawn");
-            }
-        }, "Change the spawn", "Change the player's spawn to your current position.", AUTHME_BASE);
-        setSpawnCommand.setCommandPermissions(AdminPermission.SET_SPAWN, OP_ONLY);
+        CommandDescription setSpawnCommand = CommandDescription.builder()
+        		.executableCommand(new SetSpawnCommand())
+        		.parent(AUTHME_BASE)
+        		.labels("setspawn", "chgspawn")
+        		.description("Change the spawn")
+        		.detailedDescription("Change the player's spawn to your current position.")
+        		.permissions(OP_ONLY, AdminPermission.SET_SPAWN, AdminPermission.ALL)
+        		.build();
 
         // Register the firstspawn command
-        CommandDescription firstSpawnCommand = new CommandDescription(new FirstSpawnCommand(), new ArrayList<String>() {
-            {
-                add("firstspawn");
-                add("firsthome");
-            }
-        }, "Teleport to first spawn", "Teleport to the first spawn.", AUTHME_BASE);
-        firstSpawnCommand.setCommandPermissions(AdminPermission.FIRST_SPAWN, OP_ONLY);
+        CommandDescription firstSpawnCommand = CommandDescription.builder()
+        		.executableCommand(new FirstSpawnCommand())
+        		.parent(AUTHME_BASE)
+        		.labels("firstspawn", "firsthome")
+        		.description("Teleport to first spawn")
+        		.detailedDescription("Teleport to the first spawn.")
+        		.permissions(OP_ONLY, AdminPermission.FIRST_SPAWN, AdminPermission.ALL)
+        		.build();
+
 
         // Register the setfirstspawn command
-        CommandDescription setFirstSpawnCommand = new CommandDescription(new SetFirstSpawnCommand(), new ArrayList<String>() {
-            {
-                add("setfirstspawn");
-                add("chgfirstspawn");
-            }
-        }, "Change the first spawn", "Change the first player's spawn to your current position.", AUTHME_BASE);
-        setFirstSpawnCommand.setCommandPermissions(AdminPermission.SET_FIRST_SPAWN, OP_ONLY);
+        CommandDescription setFirstSpawnCommand = CommandDescription.builder()
+        		.executableCommand(new SetFirstSpawnCommand())
+        		.parent(AUTHME_BASE)
+        		.labels("setfirstspawn", "chgfirstspawn")
+        		.description("Change the first spawn")
+        		.detailedDescription("Change the first player's spawn to your current position.")
+        		.permissions(OP_ONLY, AdminPermission.SET_FIRST_SPAWN, AdminPermission.ALL)
+        		.build();
 
         // Register the purge command
-        CommandDescription purgeCommand = new CommandDescription(new PurgeCommand(), new ArrayList<String>() {
-            {
-                add("purge");
-                add("delete");
-            }
-        }, "Purge old data", "Purge old AuthMeReloaded data longer than the specified amount of days ago.", AUTHME_BASE);
-        purgeCommand.setCommandPermissions(AdminPermission.PURGE, OP_ONLY);
-        purgeCommand.addArgument(new CommandArgumentDescription("days", "Number of days", false));
+        CommandDescription purgeCommand = CommandDescription.builder()
+        		.executableCommand(new PurgeCommand())
+        		.parent(AUTHME_BASE)
+        		.labels("purge", "delete")
+        		.description("Purge old data")
+        		.detailedDescription("Purge old AuthMeReloaded data longer than the specified amount of days ago.")
+        		.permissions(OP_ONLY, AdminPermission.PURGE, AdminPermission.ALL)
+        		.withArgument("days", "Number of days", false)
+        		.build();
 
         // Register the purgelastposition command
-        CommandDescription purgeLastPositionCommand = new CommandDescription(new PurgeLastPositionCommand(), new ArrayList<String>() {
-            {
-                add("resetpos");
-                add("purgelastposition");
-                add("purgelastpos");
-                add("resetposition");
-                add("resetlastposition");
-                add("resetlastpos");
-            }
-        }, "Purge player's last position", "Purge the last know position of the specified player.", AUTHME_BASE);
-        purgeLastPositionCommand.setCommandPermissions(AdminPermission.PURGE_LAST_POSITION, OP_ONLY);
-        purgeLastPositionCommand.addArgument(new CommandArgumentDescription("player", "Player name", true));
+        CommandDescription purgeLastPositionCommand = CommandDescription.builder()
+        		.executableCommand(new PurgeLastPositionCommand())
+        		.parent(AUTHME_BASE)
+        		.labels("resetpos", "purgelastposition", "purgelastpos", "resetposition", "resetlastposition", "resetlastpos")
+        		.description("Purge player's last position")
+        		.detailedDescription("Purge the last know position of the specified player.")
+        		.permissions(OP_ONLY, AdminPermission.PURGE_LAST_POSITION, AdminPermission.ALL)
+        		.withArgument("player", "Player name", false)
+        		.build();
 
         // Register the purgebannedplayers command
         CommandDescription purgeBannedPlayersCommand = new CommandDescription(new PurgeBannedPlayersCommand(), new ArrayList<String>() {

From c399508736837c54c3c3002765aef401b9ff4b25 Mon Sep 17 00:00:00 2001
From: ljacqu <ljacqu@users.noreply.github.com>
Date: Sat, 5 Dec 2015 21:00:35 +0100
Subject: [PATCH 3/6] Change code style not to use wildcard imports

Set code style settings not to use wildcard imports
---
 .idea/codeStyleSettings.xml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/.idea/codeStyleSettings.xml b/.idea/codeStyleSettings.xml
index 174665cb2..26493260d 100644
--- a/.idea/codeStyleSettings.xml
+++ b/.idea/codeStyleSettings.xml
@@ -5,6 +5,8 @@
       <value>
         <option name="AUTODETECT_INDENTS" value="false" />
         <option name="LINE_SEPARATOR" value="&#10;" />
+        <option name="CLASS_COUNT_TO_USE_IMPORT_ON_DEMAND" value="99" />
+        <option name="NAMES_COUNT_TO_USE_IMPORT_ON_DEMAND" value="99" />
         <option name="JD_ADD_BLANK_AFTER_PARM_COMMENTS" value="true" />
         <option name="JD_ADD_BLANK_AFTER_RETURN" value="true" />
         <XML>

From 7c36f087fc13ef91bde403b8f31ea8ccde50cf6e Mon Sep 17 00:00:00 2001
From: ljacqu <ljacqu@users.noreply.github.com>
Date: Sat, 5 Dec 2015 21:04:14 +0100
Subject: [PATCH 4/6] Fix failing test

Detailed description of a command must end in '.'
---
 .../authme/command/CommandInitializer.java     | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/src/main/java/fr/xephi/authme/command/CommandInitializer.java b/src/main/java/fr/xephi/authme/command/CommandInitializer.java
index f1765add5..a92482f53 100644
--- a/src/main/java/fr/xephi/authme/command/CommandInitializer.java
+++ b/src/main/java/fr/xephi/authme/command/CommandInitializer.java
@@ -162,7 +162,7 @@ public final class CommandInitializer {
             .build();
 
         // Register the setemail command
-        CommandDescription setEmailCommand = CommandDescription.builder()
+        CommandDescription.builder()
             .executableCommand(new SetEmailCommand())
             .parent(AUTHME_BASE)
             .labels("chgemail", "chgmail", "setemail", "setmail")
@@ -174,7 +174,7 @@ public final class CommandInitializer {
             .build();
 
         // Register the getip command
-        CommandDescription getIpCommand = CommandDescription.builder()
+        CommandDescription.builder()
         		.executableCommand(new GetIpCommand())
         		.parent(AUTHME_BASE)
         		.labels("getip", "ip")
@@ -186,18 +186,18 @@ public final class CommandInitializer {
 
 
         // Register the spawn command
-        CommandDescription spawnCommand = CommandDescription.builder()
+        CommandDescription.builder()
         		.executableCommand(new SpawnCommand())
         		.parent(AUTHME_BASE)
         		.labels("spawn", "home")
         		.description("Teleport to spawn")
-        		.detailedDescription("Teleport to the spawn")
+        		.detailedDescription("Teleport to the spawn.")
         		.permissions(OP_ONLY, AdminPermission.SPAWN, AdminPermission.ALL)
         		.withArgument("player", "Player Name", false)
         		.build();
 
         // Register the setspawn command
-        CommandDescription setSpawnCommand = CommandDescription.builder()
+        CommandDescription.builder()
         		.executableCommand(new SetSpawnCommand())
         		.parent(AUTHME_BASE)
         		.labels("setspawn", "chgspawn")
@@ -207,7 +207,7 @@ public final class CommandInitializer {
         		.build();
 
         // Register the firstspawn command
-        CommandDescription firstSpawnCommand = CommandDescription.builder()
+        CommandDescription.builder()
         		.executableCommand(new FirstSpawnCommand())
         		.parent(AUTHME_BASE)
         		.labels("firstspawn", "firsthome")
@@ -218,7 +218,7 @@ public final class CommandInitializer {
 
 
         // Register the setfirstspawn command
-        CommandDescription setFirstSpawnCommand = CommandDescription.builder()
+        CommandDescription.builder()
         		.executableCommand(new SetFirstSpawnCommand())
         		.parent(AUTHME_BASE)
         		.labels("setfirstspawn", "chgfirstspawn")
@@ -228,7 +228,7 @@ public final class CommandInitializer {
         		.build();
 
         // Register the purge command
-        CommandDescription purgeCommand = CommandDescription.builder()
+        CommandDescription.builder()
         		.executableCommand(new PurgeCommand())
         		.parent(AUTHME_BASE)
         		.labels("purge", "delete")
@@ -239,7 +239,7 @@ public final class CommandInitializer {
         		.build();
 
         // Register the purgelastposition command
-        CommandDescription purgeLastPositionCommand = CommandDescription.builder()
+        CommandDescription.builder()
         		.executableCommand(new PurgeLastPositionCommand())
         		.parent(AUTHME_BASE)
         		.labels("resetpos", "purgelastposition", "purgelastpos", "resetposition", "resetlastposition", "resetlastpos")

From 90a04e477a368607082fa3f837d8f831bc47e833 Mon Sep 17 00:00:00 2001
From: ljacqu <ljacqu@users.noreply.github.com>
Date: Sat, 5 Dec 2015 21:10:09 +0100
Subject: [PATCH 5/6] Remove ALL perm node from command initializer; JavaDoc
 householding

---
 .../authme/command/CommandInitializer.java    | 34 +++++++++----------
 .../authme/permission/AdminPermission.java    | 17 +++++-----
 2 files changed, 26 insertions(+), 25 deletions(-)

diff --git a/src/main/java/fr/xephi/authme/command/CommandInitializer.java b/src/main/java/fr/xephi/authme/command/CommandInitializer.java
index a92482f53..f0950bdfb 100644
--- a/src/main/java/fr/xephi/authme/command/CommandInitializer.java
+++ b/src/main/java/fr/xephi/authme/command/CommandInitializer.java
@@ -90,7 +90,7 @@ public final class CommandInitializer {
             .detailedDescription("Register the specified player with the specified password.")
             .withArgument("player", "Player name", false)
             .withArgument("password", "Password", false)
-            .permissions(OP_ONLY, AdminPermission.REGISTER, AdminPermission.ALL)
+            .permissions(OP_ONLY, AdminPermission.REGISTER)
             .executableCommand(new RegisterAdminCommand())
             .build();
 
@@ -101,7 +101,7 @@ public final class CommandInitializer {
             .description("Unregister a player")
             .detailedDescription("Unregister the specified player.")
             .withArgument("player", "Player name", false)
-            .permissions(OP_ONLY, AdminPermission.UNREGISTER, AdminPermission.ALL)
+            .permissions(OP_ONLY, AdminPermission.UNREGISTER)
             .executableCommand(new UnregisterAdminCommand())
             .build();
 
@@ -112,7 +112,7 @@ public final class CommandInitializer {
             .description("Enforce login player")
             .detailedDescription("Enforce the specified player to login.")
             .withArgument("player", "Online player name", true)
-            .permissions(OP_ONLY, PlayerPermission.CAN_LOGIN_BE_FORCED, AdminPermission.ALL)
+            .permissions(OP_ONLY, PlayerPermission.CAN_LOGIN_BE_FORCED)
             .executableCommand(new ForceLoginCommand())
             .build();
 
@@ -124,7 +124,7 @@ public final class CommandInitializer {
             .detailedDescription("Change the password of a player.")
             .withArgument("player", "Player name", false)
             .withArgument("pwd", "New password", false)
-            .permissions(OP_ONLY, AdminPermission.CHANGE_PASSWORD, AdminPermission.ALL)
+            .permissions(OP_ONLY, AdminPermission.CHANGE_PASSWORD)
             .executableCommand(new ChangePasswordAdminCommand())
             .build();
 
@@ -135,7 +135,7 @@ public final class CommandInitializer {
             .description("Player's last login")
             .detailedDescription("View the date of the specified players last login.")
             .withArgument("player", "Player name", true)
-            .permissions(OP_ONLY, AdminPermission.LAST_LOGIN, AdminPermission.ALL)
+            .permissions(OP_ONLY, AdminPermission.LAST_LOGIN)
             .executableCommand(new LastLoginCommand())
             .build();
 
@@ -146,7 +146,7 @@ public final class CommandInitializer {
             .description("Display player accounts")
             .detailedDescription("Display all accounts of a player by his player name or IP.")
             .withArgument("player", "Player name or IP", true)
-            .permissions(OP_ONLY, AdminPermission.ACCOUNTS, AdminPermission.ALL)
+            .permissions(OP_ONLY, AdminPermission.ACCOUNTS)
             .executableCommand(new AccountsCommand())
             .build();
 
@@ -156,7 +156,7 @@ public final class CommandInitializer {
             .labels("getemail", "getmail", "email", "mail")
             .description("Display player's email")
             .detailedDescription("Display the email address of the specified player if set.")
-            .permissions(OP_ONLY, AdminPermission.GET_EMAIL, AdminPermission.ALL)
+            .permissions(OP_ONLY, AdminPermission.GET_EMAIL)
             .withArgument("player", "Player name", true)
             .executableCommand(new GetEmailCommand())
             .build();
@@ -168,7 +168,7 @@ public final class CommandInitializer {
             .labels("chgemail", "chgmail", "setemail", "setmail")
             .description("Change player's email")
             .detailedDescription("Change the email address of the specified player.")
-            .permissions(OP_ONLY, AdminPermission.CHANGE_EMAIL, AdminPermission.ALL)
+            .permissions(OP_ONLY, AdminPermission.CHANGE_EMAIL)
             .withArgument("player", "Player name", false)
             .withArgument("email", "Player email", false)
             .build();
@@ -180,7 +180,7 @@ public final class CommandInitializer {
         		.labels("getip", "ip")
         		.description("Get player's IP")
         		.detailedDescription("Get the IP address of the specified online player.")
-        		.permissions(OP_ONLY, AdminPermission.GET_IP, AdminPermission.ALL)
+        		.permissions(OP_ONLY, AdminPermission.GET_IP)
         		.withArgument("player", "Player Name", false)
         		.build();
 
@@ -192,7 +192,7 @@ public final class CommandInitializer {
         		.labels("spawn", "home")
         		.description("Teleport to spawn")
         		.detailedDescription("Teleport to the spawn.")
-        		.permissions(OP_ONLY, AdminPermission.SPAWN, AdminPermission.ALL)
+        		.permissions(OP_ONLY, AdminPermission.SPAWN)
         		.withArgument("player", "Player Name", false)
         		.build();
 
@@ -203,7 +203,7 @@ public final class CommandInitializer {
         		.labels("setspawn", "chgspawn")
         		.description("Change the spawn")
         		.detailedDescription("Change the player's spawn to your current position.")
-        		.permissions(OP_ONLY, AdminPermission.SET_SPAWN, AdminPermission.ALL)
+        		.permissions(OP_ONLY, AdminPermission.SET_SPAWN)
         		.build();
 
         // Register the firstspawn command
@@ -213,7 +213,7 @@ public final class CommandInitializer {
         		.labels("firstspawn", "firsthome")
         		.description("Teleport to first spawn")
         		.detailedDescription("Teleport to the first spawn.")
-        		.permissions(OP_ONLY, AdminPermission.FIRST_SPAWN, AdminPermission.ALL)
+        		.permissions(OP_ONLY, AdminPermission.FIRST_SPAWN)
         		.build();
 
 
@@ -224,7 +224,7 @@ public final class CommandInitializer {
         		.labels("setfirstspawn", "chgfirstspawn")
         		.description("Change the first spawn")
         		.detailedDescription("Change the first player's spawn to your current position.")
-        		.permissions(OP_ONLY, AdminPermission.SET_FIRST_SPAWN, AdminPermission.ALL)
+        		.permissions(OP_ONLY, AdminPermission.SET_FIRST_SPAWN)
         		.build();
 
         // Register the purge command
@@ -234,7 +234,7 @@ public final class CommandInitializer {
         		.labels("purge", "delete")
         		.description("Purge old data")
         		.detailedDescription("Purge old AuthMeReloaded data longer than the specified amount of days ago.")
-        		.permissions(OP_ONLY, AdminPermission.PURGE, AdminPermission.ALL)
+        		.permissions(OP_ONLY, AdminPermission.PURGE)
         		.withArgument("days", "Number of days", false)
         		.build();
 
@@ -245,7 +245,7 @@ public final class CommandInitializer {
         		.labels("resetpos", "purgelastposition", "purgelastpos", "resetposition", "resetlastposition", "resetlastpos")
         		.description("Purge player's last position")
         		.detailedDescription("Purge the last know position of the specified player.")
-        		.permissions(OP_ONLY, AdminPermission.PURGE_LAST_POSITION, AdminPermission.ALL)
+        		.permissions(OP_ONLY, AdminPermission.PURGE_LAST_POSITION)
         		.withArgument("player", "Player name", false)
         		.build();
 
@@ -310,7 +310,7 @@ public final class CommandInitializer {
             .description("Login command")
             .detailedDescription("Command to log in using AuthMeReloaded.")
             .parent(null)
-            .permissions(ALLOWED, PlayerPermission.LOGIN, PlayerPermission.ALL_COMMANDS)
+            .permissions(ALLOWED, PlayerPermission.LOGIN)
             .withArgument("password", "Login password", false)
             .build();
 
@@ -340,7 +340,7 @@ public final class CommandInitializer {
             .detailedDescription("Command to register using AuthMeReloaded.")
             .withArgument("password", "Password", false)
             .withArgument("verifyPassword", "Verify password", false)
-            .permissions(ALLOWED, PlayerPermission.REGISTER, PlayerPermission.ALL_COMMANDS)
+            .permissions(ALLOWED, PlayerPermission.REGISTER)
             .executableCommand(new RegisterCommand())
             .build();
 
diff --git a/src/main/java/fr/xephi/authme/permission/AdminPermission.java b/src/main/java/fr/xephi/authme/permission/AdminPermission.java
index 5e1528faf..dc3cf7044 100644
--- a/src/main/java/fr/xephi/authme/permission/AdminPermission.java
+++ b/src/main/java/fr/xephi/authme/permission/AdminPermission.java
@@ -26,27 +26,27 @@ public enum AdminPermission implements PermissionNode {
     CHANGE_PASSWORD("authme.command.admin.changepassword"),
 
     /**
-     * Administrator command to see the last login date and time of an user.
+     * Administrator command to see the last login date and time of a user.
      */
     LAST_LOGIN("authme.command.admin.lastlogin"),
 
     /**
-     * Administrator command to see all accounts associated with an user.
+     * Administrator command to see all accounts associated with a user.
      */
     ACCOUNTS("authme.command.admin.accounts"),
 
     /**
-     * Administrator command to get the email address of an user, if set.
+     * Administrator command to get the email address of a user, if set.
      */
     GET_EMAIL("authme.command.admin.getemail"),
 
     /**
-     * Administrator command to set or change the email adress of an user.
+     * Administrator command to set or change the email address of a user.
      */
     CHANGE_EMAIL("authme.command.admin.changemail"),
 
     /**
-     * Administrator command to get the last known IP of an user.
+     * Administrator command to get the last known IP of a user.
      */
     GET_IP("authme.command.admin.getip"),
 
@@ -76,7 +76,7 @@ public enum AdminPermission implements PermissionNode {
     PURGE("authme.command.admin.purge"),
 
     /**
-     * Administrator command to purge the last position of an user.
+     * Administrator command to purge the last position of a user.
      */
     PURGE_LAST_POSITION("authme.command.admin.purgelastpos"),
 
@@ -101,7 +101,7 @@ public enum AdminPermission implements PermissionNode {
     RELOAD("authme.command.admin.reload"),
 
 	/**
-	 * Give access to all admin commands
+	 * Give access to all admin commands.
 	 */
 	ALL("authme.command.admin.*");
 
@@ -112,7 +112,8 @@ public enum AdminPermission implements PermissionNode {
 
     /**
      * Get the permission node.
-     * @return
+     *
+     * @return Permission node.
      */
     @Override
     public String getNode() {

From 40a83d43660548d5da716de8ffc8b3999a0adddd Mon Sep 17 00:00:00 2001
From: ljacqu <ljacqu@users.noreply.github.com>
Date: Sat, 5 Dec 2015 21:17:16 +0100
Subject: [PATCH 6/6] Revert permission nodes from "authme.command" back to
 simple "authme"

---
 .../authme/permission/AdminPermission.java    | 40 +++++++++----------
 .../authme/permission/PlayerPermission.java   | 26 ++++++------
 2 files changed, 33 insertions(+), 33 deletions(-)

diff --git a/src/main/java/fr/xephi/authme/permission/AdminPermission.java b/src/main/java/fr/xephi/authme/permission/AdminPermission.java
index dc3cf7044..470d3a4bb 100644
--- a/src/main/java/fr/xephi/authme/permission/AdminPermission.java
+++ b/src/main/java/fr/xephi/authme/permission/AdminPermission.java
@@ -8,102 +8,102 @@ public enum AdminPermission implements PermissionNode {
     /**
      * Administrator command to register a new user.
      */
-    REGISTER("authme.command.admin.register"),
+    REGISTER("authme.admin.register"),
 
     /**
      * Administrator command to unregister an existing user.
      */
-    UNREGISTER("authme.command.admin.unregister"),
+    UNREGISTER("authme.admin.unregister"),
 
     /**
      * Administrator command to force-login an existing user.
      */
-    FORCE_LOGIN("authme.command.admin.forcelogin"),
+    FORCE_LOGIN("authme.admin.forcelogin"),
 
     /**
      * Administrator command to change the password of a user.
      */
-    CHANGE_PASSWORD("authme.command.admin.changepassword"),
+    CHANGE_PASSWORD("authme.admin.changepassword"),
 
     /**
      * Administrator command to see the last login date and time of a user.
      */
-    LAST_LOGIN("authme.command.admin.lastlogin"),
+    LAST_LOGIN("authme.admin.lastlogin"),
 
     /**
      * Administrator command to see all accounts associated with a user.
      */
-    ACCOUNTS("authme.command.admin.accounts"),
+    ACCOUNTS("authme.admin.accounts"),
 
     /**
      * Administrator command to get the email address of a user, if set.
      */
-    GET_EMAIL("authme.command.admin.getemail"),
+    GET_EMAIL("authme.admin.getemail"),
 
     /**
      * Administrator command to set or change the email address of a user.
      */
-    CHANGE_EMAIL("authme.command.admin.changemail"),
+    CHANGE_EMAIL("authme.admin.changemail"),
 
     /**
      * Administrator command to get the last known IP of a user.
      */
-    GET_IP("authme.command.admin.getip"),
+    GET_IP("authme.admin.getip"),
 
     /**
      * Administrator command to teleport to the AuthMe spawn.
      */
-    SPAWN("authme.command.admin.spawn"),
+    SPAWN("authme.admin.spawn"),
 
     /**
      * Administrator command to set the AuthMe spawn.
      */
-    SET_SPAWN("authme.command.admin.setspawn"),
+    SET_SPAWN("authme.admin.setspawn"),
 
     /**
      * Administrator command to teleport to the first AuthMe spawn.
      */
-    FIRST_SPAWN("authme.command.admin.firstspawn"),
+    FIRST_SPAWN("authme.admin.firstspawn"),
 
     /**
      * Administrator command to set the first AuthMe spawn.
      */
-    SET_FIRST_SPAWN("authme.command.admin.setfirstspawn"),
+    SET_FIRST_SPAWN("authme.admin.setfirstspawn"),
 
     /**
      * Administrator command to purge old user data.
      */
-    PURGE("authme.command.admin.purge"),
+    PURGE("authme.admin.purge"),
 
     /**
      * Administrator command to purge the last position of a user.
      */
-    PURGE_LAST_POSITION("authme.command.admin.purgelastpos"),
+    PURGE_LAST_POSITION("authme.admin.purgelastpos"),
 
     /**
      * Administrator command to purge all data associated with banned players.
      */
-    PURGE_BANNED_PLAYERS("authme.command.admin.purgebannedplayers"),
+    PURGE_BANNED_PLAYERS("authme.admin.purgebannedplayers"),
 
     /**
      * Administrator command to toggle the AntiBot protection status.
      */
-    SWITCH_ANTIBOT("authme.command.admin.switchantibot"),
+    SWITCH_ANTIBOT("authme.admin.switchantibot"),
 
     /**
      * Administrator command to convert old or other data to AuthMe data.
      */
-    CONVERTER("authme.command.admin.converter"),
+    CONVERTER("authme.admin.converter"),
 
     /**
      * Administrator command to reload the plugin configuration.
      */
-    RELOAD("authme.command.admin.reload"),
+    RELOAD("authme.admin.reload"),
 
 	/**
 	 * Give access to all admin commands.
 	 */
-	ALL("authme.command.admin.*");
+	ALL("authme.admin.*");
 
     /**
      * Permission node.
diff --git a/src/main/java/fr/xephi/authme/permission/PlayerPermission.java b/src/main/java/fr/xephi/authme/permission/PlayerPermission.java
index 38fef5137..4ef0aca2e 100644
--- a/src/main/java/fr/xephi/authme/permission/PlayerPermission.java
+++ b/src/main/java/fr/xephi/authme/permission/PlayerPermission.java
@@ -18,47 +18,47 @@ public enum PlayerPermission implements PermissionNode {
     /**
      * Command permission to login.
      */
-    LOGIN("authme.command.player.login"),
+    LOGIN("authme.player.login"),
 
     /**
      * Command permission to logout.
      */
-    LOGOUT("authme.command.player.logout"),
+    LOGOUT("authme.player.logout"),
 
     /**
      * Command permission to register.
      */
-    REGISTER("authme.command.player.register"),
+    REGISTER("authme.player.register"),
 
     /**
      * Command permission to unregister.
      */
-    UNREGISTER("authme.command.player.unregister"),
+    UNREGISTER("authme.player.unregister"),
 
     /**
      * Command permission to change the password.
      */
-    CHANGE_PASSWORD("authme.command.player.changepassword"),
+    CHANGE_PASSWORD("authme.player.changepassword"),
 
     /**
      * Command permission to add an email address.
      */
-    ADD_EMAIL("authme.command.player.email.add"),
+    ADD_EMAIL("authme.player.email.add"),
 
     /**
      * Command permission to change the email address.
      */
-    CHANGE_EMAIL("authme.command.player.email.change"),
+    CHANGE_EMAIL("authme.player.email.change"),
 
     /**
      * Command permission to recover an account using it's email address.
      */
-    RECOVER_EMAIL("authme.command.player.email.recover"),
+    RECOVER_EMAIL("authme.player.email.recover"),
 
     /**
      * Command permission to use captcha.
      */
-    CAPTCHA("authme.command.player.captcha"),
+    CAPTCHA("authme.player.captcha"),
 
     /**
      * Permission for users a login can be forced to.
@@ -68,22 +68,22 @@ public enum PlayerPermission implements PermissionNode {
     /**
      * Permission for users to bypass force-survival mode.
      */
-    BYPASS_FORCE_SURVIVAL("authme.command.player.bypassforcesurvival"),
+    BYPASS_FORCE_SURVIVAL("authme.player.bypassforcesurvival"),
 
     /**
      * Permission for users to allow two accounts.
      */
-    ALLOW_MULTIPLE_ACCOUNTS("authme.command.player.allow2accounts"),
+    ALLOW_MULTIPLE_ACCOUNTS("authme.player.allow2accounts"),
 
     /**
      * Permission for user to see other accounts.
      */
-    SEE_OTHER_ACCOUNTS("authme.command.player.seeotheraccounts"),
+    SEE_OTHER_ACCOUNTS("authme.player.seeotheraccounts"),
 
 	/**
 	 *
 	 */
-	ALL_COMMANDS("authme.command.player.*");
+	ALL_COMMANDS("authme.player.*");
 
     /**
      * Permission node.