Upstream/AuthMeReloaded
1
0
Fork 0
mirror of https://github.com/AuthMe/AuthMeReloaded.git synced 2024-11-07 11:10:14 +01:00
Code Issues Projects Releases Wiki Activity

#932 Use class collector for listener consistency test

Browse Source
This commit is contained in:
ljacqu 2016-09-09 21:54:18 +02:00
parent 93c59555f8
commit d959b0a3f2
2 changed files with 24 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
src/test/java/fr/xephi/authme/listener/ListenerConsistencyTest.java
View File

@ -1,13 +1,18 @@
package fr.xephi.authme.listener;
import com.google.common.collect.Sets;
import fr.xephi.authme.ClassCollector;
import fr.xephi.authme.TestHelper;
import org.bukkit.event.EventHandler;
import org.bukkit.event.EventPriority;
import org.bukkit.event.Listener;
import org.junit.BeforeClass;
import org.junit.Test;
import java.lang.reflect.Method;
import java.lang.reflect.Modifier;
import java.util.HashSet;
import java.util.List;
import java.util.Set;
import static org.hamcrest.Matchers.equalTo;
@ -20,9 +25,7 @@ import static org.junit.Assert.fail;
*/
public final class ListenerConsistencyTest {
private static final Class<?>[] LISTENERS = { BlockListener.class, EntityListener.class,
PlayerListener.class, PlayerListener16.class, PlayerListener18.class, PlayerListener19.class,
ServerListener.class };
private static List<Class<? extends Listener>> classes;
private static final Set<String> CANCELED_EXCEPTIONS = Sets.newHashSet(
"PlayerListener#onPlayerJoin", "PlayerListener#onPlayerLogin",
@ -30,16 +33,26 @@ public final class ListenerConsistencyTest {
"ServerListener#onServerPing", "ServerListener#onPluginEnable",
"PlayerListener#onJoinMessage");
@BeforeClass
public static void collectListenerClasses() {
ClassCollector collector = new ClassCollector(TestHelper.SOURCES_FOLDER, TestHelper.PROJECT_ROOT + "listener");
classes = collector.collectClasses(Listener.class);
if (classes.isEmpty()) {
throw new IllegalStateException("Did not find any Listener classes. Is the folder correct?");
}
}
@Test
public void shouldSetIgnoreCancelledToTrue() {
for (Class<?> listener : LISTENERS) {
for (Class<?> listener : classes) {
checkCanceledAttribute(listener);
}
}
@Test
public void shouldHaveOnlyEventListenersAsPublicMembers() {
for (Class<?> listener : LISTENERS) {
for (Class<?> listener : classes) {
checkPublicMethodsAreListeners(listener);
}
}
@ -47,7 +60,7 @@ public final class ListenerConsistencyTest {
// #367: Event listeners with EventPriority.MONITOR should not change events
@Test
public void shouldNotHaveMonitorLevelEventHandlers() {
for (Class<?> listener : LISTENERS) {
for (Class<?> listener : classes) {
verifyListenerIsNotUsingMonitorPriority(listener);
}
}
@ -55,7 +68,7 @@ public final class ListenerConsistencyTest {
@Test
public void shouldNotHaveMultipleMethodsWithSameName() {
Set<String> events = new HashSet<>();
for (Class<?> listener : LISTENERS) {
for (Class<?> listener : classes) {
for (Method method : listener.getDeclaredMethods()) {
if (isTestableMethod(method) && events.contains(method.getName())) {
fail("More than one method '" + method.getName() + "' exists (e.g. class: " + listener + ")");

4
src/test/java/fr/xephi/authme/settings/properties/SettingsClassConsistencyTest.java
View File

@ -30,6 +30,10 @@ public class SettingsClassConsistencyTest {
public static void scanForSettingsClasses() {
ClassCollector collector = new ClassCollector(TestHelper.SOURCES_FOLDER, SETTINGS_FOLDER);
classes = collector.collectClasses(SettingsHolder.class);
if (classes.isEmpty()) {
throw new IllegalStateException("Did not find any SettingsHolder classes. Is the folder correct?");
}
System.out.println("Found " + classes.size() + " SettingsHolder implementations");
}