Upstream/AuthMeReloaded
1
0
Fork 0
mirror of https://github.com/AuthMe/AuthMeReloaded.git synced 2024-11-25 19:55:39 +01:00
Code Issues Projects Releases Wiki Activity

Fix #1079

Browse Source
This commit is contained in:
Gabriele C 2017-01-29 13:46:52 +01:00
parent 12566f03ef
commit f46dd9445c
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/main/java/fr/xephi/authme/service/ValidationService.java
View File

@ -80,7 +80,7 @@ public class ValidationService implements Reloadable {
* @return true if the email is valid, false otherwise * @return true if the email is valid, false otherwise
*/ */
public boolean validateEmail(String email) { public boolean validateEmail(String email) {
if (!email.contains("@") || "your@email.com".equalsIgnoreCase(email)) { if (!email.contains("@") || email.endsWith("@") || "your@email.com".equalsIgnoreCase(email)) {
return false; return false;
} }
final String emailDomain = email.split("@")[1]; final String emailDomain = email.split("@")[1];

6
src/test/java/fr/xephi/authme/service/ValidationServiceTest.java
View File

@ -187,6 +187,12 @@ public class ValidationServiceTest {
assertThat(validationService.validateEmail("invalidinput"), equalTo(false)); assertThat(validationService.validateEmail("invalidinput"), equalTo(false));
} }
@Test
public void shouldRejectInvalidEmailWithoutDomain() {
// given/when/then
assertThat(validationService.validateEmail("invalidinput@"), equalTo(false));
}
@Test @Test
public void shouldRejectDefaultEmail() { public void shouldRejectDefaultEmail() {
// given/when/then // given/when/then