DNx
9f199b1a5a
Update AuthMePlayerListener.java
2015-11-25 05:04:38 +07:00
ljacqu
cf4e47488b
Start refactoring for Messages class
2015-11-24 22:54:54 +01:00
ljacqu
2e5b7ecf29
Merge branch 'master' of https://github.com/AuthMe-Team/AuthMeReloaded into enums
2015-11-24 22:21:53 +01:00
ljacqu
72fe710b8c
Fix UtilsTest, create MessageKeyTest
2015-11-24 22:21:36 +01:00
Gabriele C
a983253384
better names
2015-11-24 22:08:06 +01:00
ljacqu
e4c82e04ff
Merge upstream/master into ljacqu/enums
2015-11-24 21:59:55 +01:00
Gabriele C
e9b2517188
enhance the removespeed feature
2015-11-24 21:55:55 +01:00
Gabriele C
43b9462ddc
cleanup
2015-11-24 21:13:09 +01:00
Gabriele C
28e742e42f
cleanup
2015-11-24 19:04:18 +01:00
Gabriele C
cc8401e841
Move the antibot management
2015-11-24 18:51:09 +01:00
DNx5
489708b206
i forgot about the hotbar.
2015-11-25 00:44:38 +07:00
DNx5
ea420ab05f
set protect inventory to false in config file if protocol lib is not found.
2015-11-25 00:43:55 +07:00
DNx5
25c23e144c
- send blank inventory on logout if protect inventory is enabled.
...
- added reload support for protect inventory option.
2015-11-25 00:14:45 +07:00
Gabriele C
fb6ddb4b59
Cleanup
2015-11-24 17:47:10 +01:00
DNx5
bc223b04f9
shouldn't allow movement event noTeleport enabled.
2015-11-24 22:14:14 +07:00
DNx5
e39ab8a644
removed old GeoIP data check.
2015-11-24 22:08:09 +07:00
DNx5
5be476e2d6
ignore yaw changes in player move event.
2015-11-24 21:55:55 +07:00
DNx5
8e9bfc6299
update playerloginevent and some listener.
...
i hope it will fix the lag issues.
2015-11-24 07:15:58 +07:00
DNx5
b4b92e5a93
reordering local variable scope in captcha command
2015-11-24 05:46:28 +07:00
ljacqu
16a69d4126
Merge upstream/master into ljacqu/enums
2015-11-23 23:31:26 +01:00
ljacqu
6422f90114
Create Wrapper for instances / revise MockUtils
...
- Add test resources folder
- Create basic test for Messages (todo: add concrete tests)
- Create WrapperMock
- Change UtilsTest (todo: make it work)
2015-11-23 23:25:03 +01:00
DNx5
d7f9b602c7
update some Utils method
2015-11-24 04:43:29 +07:00
Tim Visée
09067ddbd1
Removed redundant code, fixed some warnings, other minor fixes
2015-11-23 22:18:04 +01:00
Tim Visée
82bf0f45ca
Finalized some fields, removed redundant code, various other fixes
2015-11-23 22:14:03 +01:00
Tim Visée
83e5d726af
Improved various code bits
2015-11-23 22:12:01 +01:00
Tim Visée
1dd540b9c0
Fixed some redundant casts and definitions
2015-11-23 22:09:15 +01:00
Tim Visée
47b1d00ccf
Fixed various spelling and grammar issues
2015-11-23 22:07:32 +01:00
Tim Visée
36c50c4507
Reformatted code with new code style
2015-11-23 21:46:34 +01:00
Tim Visée
b2db25d16c
Improved JavaDocs code style, some minor improvements
2015-11-23 21:45:23 +01:00
Tim Visée
f15eaae67f
Some minor automatic fixes and changes
2015-11-23 21:43:40 +01:00
Tim Visée
53117928f5
Reformatted all files once again
2015-11-23 21:40:11 +01:00
Tim Visée
2e868c7492
Reformatted all code files, cleaned up the project
2015-11-23 21:33:08 +01:00
ljacqu
8719cce334
Create enum for message keys in Messages
2015-11-23 21:13:12 +01:00
Gabriele C
10435657c5
Fix enableBackup option
2015-11-23 20:59:25 +01:00
Gabriele C
614aa9d5e5
Fix noTeleport in the PlayerListener
2015-11-23 20:59:13 +01:00
AuthMe-Team
9ec2d6d059
Stuff from the common floobits workspace
...
Author: AuthMe-Team <AuthMeTeam@123NoEmail.com>
2015-11-23 20:23:52 +01:00
Gabriele C
69a09aec17
cleanup
2015-11-22 21:06:08 +01:00
Tim Visée
da662afcf4
Created method to get an exception stack trace as a string
2015-11-22 21:01:31 +01:00
ljacqu
215fedc585
Minor refactoring in CustomConfiguration / Messages
...
- CustomConfiguration should be abstract
- Reduce visibility of internal method
- Fix typo in English messages
- Remove or replace unnecessary javadoc
2015-11-22 02:02:49 +01:00
ljacqu
e456203fc6
Refactor Utils#getOnlinePlayers and add background info
2015-11-22 01:30:07 +01:00
ljacqu
fc3f685de0
Create UtilsTest
...
Had to create a getGameServer() method in AuthMe in order to be able to catch this call in tests and replace it with a mock implementation of the actual server. The supertype method getServer() is declared as final, which makes it impossible to mock with Mockito.
While there are frameworks that manipulate the bytecode to mock final calls, it is much easier and less risky to simply delegate the server retrieval through another method.
2015-11-21 23:09:04 +01:00
ljacqu
cd728b569e
Create test for CommandManager; fix javadoc in CommandDescription
2015-11-21 22:32:16 +01:00
Tim Visée
1ba18439e9
Fixed invalid method arguments
2015-11-21 21:08:07 +01:00
Tim Visée
ada991904b
Improved purgePermissions method
2015-11-21 21:07:32 +01:00
Tim Visée
e45aa88504
Fixed result not being returned
2015-11-21 21:03:50 +01:00
Tim Visée
18af8f3171
Fixed addLimboPlayer method
2015-11-21 21:02:53 +01:00
Tim Visée
0a5c081732
Added method to permissions manager to get primary group of player
2015-11-21 20:59:23 +01:00
Tim Visée
89b5444d69
Fixed addNormal method, updated it's JavaDocs
2015-11-21 20:50:12 +01:00
Tim Visée
7902cd87bb
Added return statement for setGroup method, updated it's JavaDocs
2015-11-21 20:47:56 +01:00
Gabriele C
579c51f4a2
Remove the old Vault group management system. (THIS COMMIT BREAKS THE COMPILATION)
2015-11-21 20:16:07 +01:00
ljacqu
efb57989ed
Start tests for email commands
...
- Removed randomStringGenerator from Management as it is unused
2015-11-21 19:51:49 +01:00
ljacqu
2922d04aa0
Merge branch 'unit-tests' of https://github.com/ljacqu/AuthMeReloaded into unit-tests
2015-11-21 19:39:26 +01:00
ljacqu
f06f7d8c77
Merge remote-tracking branch 'origin/unit-tests' into unit-tests
...
Conflicts:
src/main/java/fr/xephi/authme/command/executable/changepassword/ChangePasswordCommand.java
src/test/java/fr/xephi/authme/AuthMeMockUtil.java
2015-11-21 19:36:48 +01:00
Tim Visée
579b7e7b97
Improved some grammar and variable names
2015-11-21 19:24:25 +01:00
Tim Visée
a176aba350
Fixed horrible typo, implemented dynamic plugin name
2015-11-21 19:22:23 +01:00
Tim Visée
30b4cfe44e
Added notice to legacy permissions instance in main class
2015-11-21 19:18:56 +01:00
ljacqu
b3d0a71dec
Merge ListUtil into StringUtil; refactor HelpSyntaxHelper + create test
...
The HelpSyntaxHelper had suppressed warnings for string concatenation within StringBuilder - the point of the StringBuilder is that it is faster when you use it to concatenate many elements. If you still use string concatenation with + within these calls it beats the purpose.
2015-11-21 17:19:11 +01:00
ljacqu
a3f24bcb9a
Create test for HelpSyntaxHelperTest
2015-11-21 17:18:58 +01:00
ljacqu
58dc15123c
Add tests for LogoutCommand and RegisterCommand. Add more generic mockUtil
2015-11-21 17:18:45 +01:00
ljacqu
4e8614fdf7
Add test for LoginCommand; create AuthMe mock test util
...
Had to create a getter for the Management instance in the AuthMe class for mocking, but fields should generally not be accessed globally. Hopefully soon we will be able to make the field private.
2015-11-21 17:18:28 +01:00
ljacqu
d81ef3168e
Command refactor - remove unused fields, reduce variable "scope"
...
Minor refactorings in the command section for familiarization.
1. Removed suppressWarning("Deprecated") - the method is deprecated for a reason and we should be made aware of that.
2. Removed same javadoc on ExecutableCommand implementation that just had the same as the interface (this is just clutter; @Override signals that it's an implementing class and a developer can view the superclass javadoc)
3. In places where the AuthMe instance was retrieved at the top but used at the very bottom, moved it to the bottom to reduce its "scope"
2015-11-21 17:18:14 +01:00
Tim Visée
8387924c64
Merge pull request #68 from ljacqu/master
...
Revert certain JavaDoc changes
2015-11-21 16:57:17 +01:00
Tim Visée
8181bda762
Minor update to hasGroupSupport method in permissions manager
2015-11-21 16:26:05 +01:00
Tim Visée
bb22daab33
Added some missing support for Nijikokun's Permissions in permissions manager
2015-11-21 16:21:38 +01:00
Tim Visée
6dc4066563
Added group support check to setGroups method in Utils class
2015-11-21 16:08:41 +01:00
Tim Visée
eaba2765fa
Created hasGroupSupport method in permissions manager
2015-11-21 16:07:02 +01:00
Tim Visée
69d6518b30
Improved setGroup method in Utils class, to replace legacy permissions code
2015-11-21 16:03:00 +01:00
Tim Visée
973c683c90
Minor fix for PermissionsBukkit support in permissions manager
2015-11-21 15:47:59 +01:00
Tim Visée
cfaece3eae
Simplefied some code
2015-11-21 15:46:10 +01:00
Tim Visée
f8cf9e2e48
Created inGroup method in permissions manager
2015-11-21 15:44:57 +01:00
Tim Visée
a05a97a0a6
Fixed setGroup method in permissions manager
2015-11-21 15:38:20 +01:00
Tim Visée
1091db0e15
Created removeAllGroups method in permissions manager
2015-11-21 15:34:38 +01:00
Tim Visée
f7f455a56a
Created setGroups method in permissions manager
2015-11-21 15:24:53 +01:00
Tim Visée
a84e219899
Fixed minor Essentials Group Manager issue in addGroup method of permissions manager
2015-11-21 15:18:01 +01:00
Tim Visée
462a2e9878
Created removeGroups method in permissions manager
2015-11-21 15:16:19 +01:00
Tim Visée
bcf4eeab00
Created removeGroup method in permissions manager
2015-11-21 15:15:04 +01:00
Tim Visée
b07e4b62cc
Created addGroups method in permissions manager
2015-11-21 15:07:46 +01:00
Tim Visée
a6fe728d79
Fixed addGroup method for PermissionsBukkit in permissions manager
2015-11-21 15:00:14 +01:00
Tim Visée
f4da63fee6
Added note to getGroups method in permissions manager for PermissionsBukkit
2015-11-21 14:57:34 +01:00
Tim Visée
42dee2e101
Created addGroup method in permissions manager
2015-11-21 14:44:43 +01:00
Tim Visée
400d014e7b
Fixed setGroup in PermissionsManager for Essentials Group Manager and zPermissions
2015-11-21 14:41:14 +01:00
ljacqu
b633b9a005
Create test for change password command
2015-11-21 13:23:18 +01:00
ljacqu
4702a1b82d
Merge ListUtil into StringUtil; refactor HelpSyntaxHelper + create test
...
The HelpSyntaxHelper had suppressed warnings for string concatenation within StringBuilder - the point of the StringBuilder is that it is faster when you use it to concatenate many elements. If you still use string concatenation with + within these calls it beats the purpose.
(cherry picked from commit bb00be2)
2015-11-21 12:12:26 +01:00
ljacqu
115680a363
Create test for HelpSyntaxHelperTest
...
(cherry picked from commit 9a6e96d)
2015-11-21 12:07:21 +01:00
ljacqu
e65319d42c
Add tests for LogoutCommand and RegisterCommand. Add more generic mockUtil
...
(cherry picked from commit 06cfd13)
2015-11-21 12:07:10 +01:00
ljacqu
987e38c5df
Add test for LoginCommand; create AuthMe mock test util
...
Had to create a getter for the Management instance in the AuthMe class for mocking, but fields should generally not be accessed globally. Hopefully soon we will be able to make the field private.
(cherry picked from commit f1a0022)
2015-11-21 12:07:00 +01:00
ljacqu
3934d67330
Command refactor - remove unused fields, reduce variable "scope"
...
Minor refactorings in the command section for familiarization.
1. Removed suppressWarning("Deprecated") - the method is deprecated for a reason and we should be made aware of that.
2. Removed same javadoc on ExecutableCommand implementation that just had the same as the interface (this is just clutter; @Override signals that it's an implementing class and a developer can view the superclass javadoc)
3. In places where the AuthMe instance was retrieved at the top but used at the very bottom, moved it to the bottom to reduce its "scope"
(cherry picked from commit 45a50f3)
2015-11-21 12:06:49 +01:00
ljacqu
9a68aa5517
Proper Javadoc example / add test for StringUtils
...
- Proper example for the purpose of javadoc and how it could look like
- Fix containsAny to be null safe
- Add tests
2015-11-21 08:28:53 +01:00
ljacqu
38cc217cff
Revert certain JavaDoc changes
...
Ideally JavaDoc should provide additional information to the developer
as to the method's purpose and usage. Typically you do not add the
return type of the method and the parameter's types since this can be
seen in the code.
A short description of what the parameter really is (e.g. a String can
hold many types of information) is a lot more beneficial. A JavaDoc
statement simply restating the parameter types and the method name is,
put bluntly, simply noise, since all of these things are already
contained in the code itself.
Similarly, @see references are great for pointing to other, related
methods but aren't very helpful to point to a superclass method (the
implemented or overriden method) since it is implied by @Override. A
developer can navigate easily to the superclass method with any
reasonable IDE.
2015-11-21 07:41:56 +01:00
Tim Visée
504106f835
Added base of setGroup method in permissions manager
2015-11-21 03:01:45 +01:00
Tim Visée
06d6bd4a7e
Fixed formatting in PermissionsManager class
2015-11-21 02:43:32 +01:00
Tim Visée
5ff9b7550e
Combined Plugin and Server listener, removed plugin listener
2015-11-21 02:33:59 +01:00
Gabriele C
bd1f868c6d
standard javadoc
2015-11-21 01:31:18 +01:00
Gabriele C
118c79401a
Prepare the project for javadocs
2015-11-21 01:27:06 +01:00
Gabriele C
adcd70b91d
auto cleanup
2015-11-21 01:15:52 +01:00
Gabriele C
ada992785c
login process cleanup
2015-11-21 00:36:46 +01:00
Gabriele C
68ae6ee701
remove useless inventory store event
2015-11-20 23:59:25 +01:00
Gabriele C
d6355adb51
cleanup
2015-11-20 23:52:20 +01:00
Gabriele C
ba483af807
fix project layout
2015-11-20 23:43:26 +01:00
ljacqu
84de22c9c0
Refactor Log4JFilter and improve branch coverage
2015-11-20 23:17:50 +01:00
