From e6a2d2f1c5cf69ff15c89b384658b44c9eae1b98 Mon Sep 17 00:00:00 2001
From: Phoenix616 <max@themoep.de>
Date: Wed, 1 Mar 2023 17:49:59 +0100
Subject: [PATCH] Cleanup: Properly log errors and remove unnecessary early
 return

---
 .../java/com/Acrobot/ChestShop/Database/Migrations.java   | 8 +++-----
 .../java/com/Acrobot/ChestShop/UUIDs/NameManager.java     | 2 +-
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/main/java/com/Acrobot/ChestShop/Database/Migrations.java b/src/main/java/com/Acrobot/ChestShop/Database/Migrations.java
index 4c8f26b..7e918cd 100644
--- a/src/main/java/com/Acrobot/ChestShop/Database/Migrations.java
+++ b/src/main/java/com/Acrobot/ChestShop/Database/Migrations.java
@@ -28,8 +28,6 @@ public class Migrations {
     public static int migrate(int currentVersion) {
         if (currentVersion != CURRENT_DATABASE_VERSION) {
             ChestShop.getBukkitLogger().info("Updating database...");
-        } else {
-            return CURRENT_DATABASE_VERSION;
         }
 
         switch (currentVersion) {
@@ -67,7 +65,7 @@ public class Migrations {
             accounts.executeRaw("ALTER TABLE `accounts` ADD COLUMN lastSeenName VARCHAR");
             return true;
         } catch (SQLException e) {
-            e.printStackTrace();
+            ChestShop.getBukkitLogger().log(Level.SEVERE, "Error while migrating database to v2", e);
             return false;
         }
     }
@@ -122,7 +120,7 @@ public class Migrations {
 
             return true;
         } catch (SQLException e) {
-            e.printStackTrace();
+            ChestShop.getBukkitLogger().log(Level.SEVERE, "Error while migrating database to v3", e);
             return false;
         }
     }
@@ -145,7 +143,7 @@ public class Migrations {
 
             return true;
         } catch (SQLException e) {
-            e.printStackTrace();
+            ChestShop.getBukkitLogger().log(Level.SEVERE, "Error while migrating database to v4", e);
             return false;
         }
     }
diff --git a/src/main/java/com/Acrobot/ChestShop/UUIDs/NameManager.java b/src/main/java/com/Acrobot/ChestShop/UUIDs/NameManager.java
index 1109649..e68d682 100644
--- a/src/main/java/com/Acrobot/ChestShop/UUIDs/NameManager.java
+++ b/src/main/java/com/Acrobot/ChestShop/UUIDs/NameManager.java
@@ -355,7 +355,7 @@ public class NameManager implements Listener {
                 }
             }
         } catch (SQLException e) {
-            e.printStackTrace();
+            ChestShop.getBukkitLogger().log(Level.SEVERE, "Error while trying to setup accounts", e);
         }
     }