Upstream
/
Citizens2
mirror of https://github.com/CitizensDev/Citizens2.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Trial a iteration performance tradeoff for PlayerUpdateTask

This commit is contained in:
fullwall 2023-11-17 01:33:46 +08:00
parent 3221019dda
commit 145d6ce616
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
main/src/main/java/net/citizensnpcs/util/PlayerUpdateTask.java
View File

@ -17,6 +17,8 @@ import net.citizensnpcs.npc.ai.NPCHolder;
import net.citizensnpcs.trait.PacketNPC;
public class PlayerUpdateTask extends BukkitRunnable {
private PlayerTick[] players = new PlayerTick[0];
@Override
public void cancel() {
super.cancel();
@ -43,11 +45,15 @@ public class PlayerUpdateTask extends BukkitRunnable {
PLAYERS.put(entity.getUniqueId(), new PlayerTick((Player) entity));
}
}
// convert to sorted list with binary search
if (PLAYERS_PENDING_ADD.size() + PLAYERS_PENDING_REMOVE.size() > 0) {
players = PLAYERS.values().toArray(new PlayerTick[PLAYERS.values().size()]);
}
PLAYERS_PENDING_ADD.clear();
PLAYERS_PENDING_REMOVE.clear();
PLAYERS.values().forEach(Runnable::run);
for (int i = 0; i < players.length; i++) {
players[i].run();
}
}
private static class PlayerTick implements Runnable {