Use onPreSpawn event to avoid 'FOUC' in armorstands. Fix invulnerable ticks being reduced too quickly.

main/src/main/java/net/citizensnpcs/npc/CitizensNPC.java

@@ -255,6 +255,16 @@ public class CitizensNPC extends AbstractNPC {
         entityController.spawn(at.clone(), this);
         getEntity().setMetadata(NPC_METADATA_MARKER, new FixedMetadataValue(CitizensAPI.getPlugin(), true));
 
+        Collection<Trait> onPreSpawn = traits.values();
+        for (Trait trait : onPreSpawn.toArray(new Trait[onPreSpawn.size()])) {
+            try {
+                trait.onPreSpawn();
+            } catch (Throwable ex) {
+                Messaging.severeTr(Messages.TRAIT_ONSPAWN_FAILED, trait.getName(), getId());
+                ex.printStackTrace();
+            }
+        }
+
         boolean loaded = Util.isLoaded(at);
         boolean couldSpawn = !loaded ? false : NMS.addEntityToWorld(getEntity(), CreatureSpawnEvent.SpawnReason.CUSTOM);
 
@@ -294,10 +304,7 @@ public class CitizensNPC extends AbstractNPC {
 
         navigator.onSpawn();
 
-        // Modify NPC using traits after the entity has been created
         Collection<Trait> onSpawn = traits.values();
-
-        // work around traits modifying the map during this iteration.
         for (Trait trait : onSpawn.toArray(new Trait[onSpawn.size()])) {
             try {
                 trait.onSpawn();

main/src/main/java/net/citizensnpcs/trait/ArmorStandTrait.java

@@ -65,54 +65,59 @@ public class ArmorStandTrait extends Trait {
         return visible;
     }
 
+    @Override
+    public void onPreSpawn() {
+        onSpawn();
+    }
+
     @Override
     public void onSpawn() {
-        if (npc.getEntity() instanceof ArmorStand) {
+        if (!(npc.getEntity() instanceof ArmorStand))
-            ArmorStand entity = (ArmorStand) npc.getEntity();
+            return;
-            if (leftArm != null) {
+        ArmorStand entity = (ArmorStand) npc.getEntity();
-                entity.setLeftArmPose(leftArm);
+        if (leftArm != null) {
-            }
+            entity.setLeftArmPose(leftArm);
-            if (leftLeg != null) {
-                entity.setLeftLegPose(leftLeg);
-            }
-            if (rightArm != null) {
-                entity.setRightArmPose(rightArm);
-            }
-            if (rightLeg != null) {
-                entity.setRightLegPose(rightLeg);
-            }
-            if (body != null) {
-                entity.setBodyPose(body);
-            }
-            if (head != null) {
-                entity.setHeadPose(head);
-            }
-            entity.setVisible(visible);
-            entity.setGravity(gravity);
-            entity.setArms(hasarms);
-            entity.setBasePlate(hasbaseplate);
-            entity.setSmall(small);
-            entity.setMarker(marker);
         }
+        if (leftLeg != null) {
+            entity.setLeftLegPose(leftLeg);
+        }
+        if (rightArm != null) {
+            entity.setRightArmPose(rightArm);
+        }
+        if (rightLeg != null) {
+            entity.setRightLegPose(rightLeg);
+        }
+        if (body != null) {
+            entity.setBodyPose(body);
+        }
+        if (head != null) {
+            entity.setHeadPose(head);
+        }
+        entity.setVisible(visible);
+        entity.setGravity(gravity);
+        entity.setArms(hasarms);
+        entity.setBasePlate(hasbaseplate);
+        entity.setSmall(small);
+        entity.setMarker(marker);
     }
 
     @Override
     public void run() {
-        if (npc.getEntity() instanceof ArmorStand) {
+        if (!(npc.getEntity() instanceof ArmorStand))
-            ArmorStand entity = (ArmorStand) npc.getEntity();
+            return;
-            body = entity.getBodyPose();
+        ArmorStand entity = (ArmorStand) npc.getEntity();
-            leftArm = entity.getLeftArmPose();
+        body = entity.getBodyPose();
-            leftLeg = entity.getLeftLegPose();
+        leftArm = entity.getLeftArmPose();
-            rightArm = entity.getRightArmPose();
+        leftLeg = entity.getLeftLegPose();
-            rightLeg = entity.getRightLegPose();
+        rightArm = entity.getRightArmPose();
-            head = entity.getHeadPose();
+        rightLeg = entity.getRightLegPose();
-            entity.setVisible(visible);
+        head = entity.getHeadPose();
-            entity.setGravity(gravity);
+        entity.setVisible(visible);
-            entity.setArms(hasarms);
+        entity.setGravity(gravity);
-            entity.setBasePlate(hasbaseplate);
+        entity.setArms(hasarms);
-            entity.setSmall(small);
+        entity.setBasePlate(hasbaseplate);
-            entity.setMarker(marker);
+        entity.setSmall(small);
-        }
+        entity.setMarker(marker);
     }
 
     /**

v1_11_R1/src/main/java/net/citizensnpcs/nms/v1_11_R1/entity/EntityHumanNPC.java

@@ -127,10 +127,6 @@ public class EntityHumanNPC extends EntityPlayer implements NPCHolder, Skinnable
         boolean navigating = npc.getNavigator().isNavigating();
         updatePackets(navigating);
 
-        if (noDamageTicks > 0) {
-            --noDamageTicks;
-        }
-
         npc.update();
     }
 

v1_12_R1/src/main/java/net/citizensnpcs/nms/v1_12_R1/entity/EntityHumanNPC.java

@@ -140,10 +140,6 @@ public class EntityHumanNPC extends EntityPlayer implements NPCHolder, Skinnable
         boolean navigating = npc.getNavigator().isNavigating();
         updatePackets(navigating);
 
-        if (noDamageTicks > 0) {
-            --noDamageTicks;
-        }
-
         npc.update();
     }
 

v1_13_R2/src/main/java/net/citizensnpcs/nms/v1_13_R2/entity/EntityHumanNPC.java

@@ -421,10 +421,6 @@ public class EntityHumanNPC extends EntityPlayer implements NPCHolder, Skinnable
         boolean navigating = npc.getNavigator().isNavigating();
         updatePackets(navigating);
 
-        if (noDamageTicks > 0) {
-            --noDamageTicks;
-        }
-
         npc.update();
     }
 

v1_14_R1/src/main/java/net/citizensnpcs/nms/v1_14_R1/entity/EntityHumanNPC.java

@@ -424,11 +424,6 @@ public class EntityHumanNPC extends EntityPlayer implements NPCHolder, Skinnable
 
         boolean navigating = npc.getNavigator().isNavigating();
         updatePackets(navigating);
-
-        if (noDamageTicks > 0) {
-            --noDamageTicks;
-        }
-
         npc.update();
     }
 

v1_15_R1/src/main/java/net/citizensnpcs/nms/v1_15_R1/entity/EntityHumanNPC.java

@@ -170,7 +170,7 @@ public class EntityHumanNPC extends EntityPlayer implements NPCHolder, Skinnable
             public void run() {
                 ((WorldServer) world).removeEntity(EntityHumanNPC.this);
             }
-        }, 35); // give enough time for death and smoke animation
+        }, 15); // give enough time for death and smoke animation
     }
 
     @Override
@@ -425,10 +425,6 @@ public class EntityHumanNPC extends EntityPlayer implements NPCHolder, Skinnable
         boolean navigating = npc.getNavigator().isNavigating();
         updatePackets(navigating);
 
-        if (noDamageTicks > 0) {
-            --noDamageTicks;
-        }
-
         npc.update();
         /*
          double diff = this.yaw - this.aK;

v1_16_R3/src/main/java/net/citizensnpcs/nms/v1_16_R3/entity/EntityHumanNPC.java

@@ -183,7 +183,7 @@ public class EntityHumanNPC extends EntityPlayer implements NPCHolder, Skinnable
             public void run() {
                 ((WorldServer) world).removeEntity(EntityHumanNPC.this);
             }
-        }, 35); // give enough time for death and smoke animation
+        }, 15); // give enough time for death and smoke animation
     }
 
     @Override
@@ -455,10 +455,6 @@ public class EntityHumanNPC extends EntityPlayer implements NPCHolder, Skinnable
         boolean navigating = npc.getNavigator().isNavigating();
         updatePackets(navigating);
 
-        if (noDamageTicks > 0) {
-            --noDamageTicks;
-        }
-
         npc.update();
         /*
          double diff = this.yaw - this.aK;

v1_17_R1/src/main/java/net/citizensnpcs/nms/v1_17_R1/entity/EntityHumanNPC.java

@@ -197,11 +197,11 @@ public class EntityHumanNPC extends ServerPlayer implements NPCHolder, Skinnable
 
         if (this.hurtTime > 0)
             this.hurtTime--;
-        if (this.invulnerableTime > 0)
+
-            this.invulnerableTime--;
         if (isDeadOrDying()) {
             tickDeath();
         }
+
         if (this.lastHurtByPlayerTime > 0) {
             this.lastHurtByPlayerTime--;
         } else {
@@ -482,10 +482,6 @@ public class EntityHumanNPC extends ServerPlayer implements NPCHolder, Skinnable
 
         updatePackets(npc.getNavigator().isNavigating());
 
-        if (invulnerableTime > 0) {
-            --invulnerableTime;
-        }
-
         npc.update();
     }