Upstream/Citizens2
1
0
Fork 0
mirror of https://github.com/CitizensDev/Citizens2.git synced 2025-01-13 03:40:39 +01:00
Code Issues Projects Releases Wiki Activity

Fix NPC sometimes spins in circles...

Browse Source 
Fix NPC sometimes spins in circles when reaches destination.

Honor NavigationParameters#distanceMargin value.
This commit is contained in:
JCThePants 2015-02-18 21:28:46 -08:00
parent 90512ac162
commit 8324752b2d
1 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/main/java/net/citizensnpcs/npc/ai/MCNavigationStrategy.java
View File

@ -15,12 +15,13 @@ public class MCNavigationStrategy extends AbstractPathStrategy {
private final NavigationAbstract navigation;
private final NavigatorParameters parameters;
private final Location target;
private final EntityLiving handle;
MCNavigationStrategy(final NPC npc, Location dest, NavigatorParameters params) {
super(TargetType.LOCATION);
this.target = dest;
this.parameters = params;
EntityLiving handle = ((CraftLivingEntity) npc.getEntity()).getHandle();
handle = ((CraftLivingEntity) npc.getEntity()).getHandle();
handle.onGround = true;
// not sure of a better way around this - if onGround is false, then
// navigation won't execute, and calling entity.move doesn't
@ -58,6 +59,17 @@ public class MCNavigationStrategy extends AbstractPathStrategy {
return true;
navigation.a(parameters.speed());
parameters.run();
if (distanceSquared() < parameters.distanceMargin()) {
stop();
return true;
}
return NMS.isNavigationFinished(navigation);
}
private double distanceSquared() {
return handle.getBukkitEntity().getLocation(HANDLE_LOCATION)
.distanceSquared(target);
}
private static final Location HANDLE_LOCATION = new Location(null, 0, 0, 0);
}