From 8efde00530942c5b82844dae1b63fc8183fffca5 Mon Sep 17 00:00:00 2001 From: fullwall Date: Mon, 23 Oct 2023 02:07:59 +0800 Subject: [PATCH] Re-mounting interaction entities seems to work --- .../src/main/java/net/citizensnpcs/trait/HologramTrait.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/main/src/main/java/net/citizensnpcs/trait/HologramTrait.java b/main/src/main/java/net/citizensnpcs/trait/HologramTrait.java index 74de7db84..e65bd2dac 100644 --- a/main/src/main/java/net/citizensnpcs/trait/HologramTrait.java +++ b/main/src/main/java/net/citizensnpcs/trait/HologramTrait.java @@ -38,6 +38,7 @@ import net.citizensnpcs.util.Util; /** * Persists a hologram attached to the NPC. */ +// TODO: refactor this class and remove HologramDirection @TraitName("hologramtrait") public class HologramTrait extends Trait { private Location currentLoc; @@ -326,7 +327,7 @@ public class HologramTrait extends Trait { } if (useDisplayEntities && nameLine.hologram.getEntity().getVehicle() == null) { - NMS.updateMountedInteractionHeight(nameLine.hologram.getEntity(), npc.getEntity(), 0); + npc.getEntity().addPassenger(nameLine.hologram.getEntity()); } if (updateName) { @@ -354,8 +355,7 @@ public class HologramTrait extends Trait { } if (useDisplayEntities && hologramNPC.getEntity().getVehicle() == null) { - NMS.updateMountedInteractionHeight(hologramNPC.getEntity(), npc.getEntity(), - (direction == HologramDirection.BOTTOM_UP ? getHeight(i) : getMaxHeight() - getHeight(i))); + npc.getEntity().addPassenger(hologramNPC.getEntity()); } String text = line.text;