Upstream/CloverBootloader
1
0
Fork 0
mirror of https://github.com/CloverHackyColor/CloverBootloader.git synced 2024-11-23 11:35:19 +01:00
Code Issues Packages Projects Releases Wiki Activity

Prevent panic in XTheme::ClearScreen()

Browse Source
This commit is contained in:
jief666 2020-08-19 10:52:33 +03:00
parent 2ef2b9df0d
commit 3eece0918c
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
rEFIt_UEFI/libeg/XTheme.cpp
View File

@ -328,6 +328,13 @@ void XTheme::FillByEmbedded()
void XTheme::ClearScreen() //and restore background and banner
{
if ( UGAWidth == 0 || UGAHeight == 0 ) {
// jief : I had the case where no graphic protocol were availbale. So UGAWidth == 0 && UGAHeight == 0 which panic because Background would be empty.
// Background.GetPixelPtr(0, 0) panic on an empty image because there is no pixel at x=0 y=0
// test could be "if ( UGAWidth == 0 && UGAHeight == 0 )" (&& instead of ||), but I feel like if one of the dimension is 0, we have a graphic problem.
// also, should we implement the case if we are in text mode ?
return;
}
EFI_GRAPHICS_OUTPUT_BLT_PIXEL FirstBannerPixel = MenuBackgroundPixel;
if (BanHeight < 2) {
BanHeight = ((UGAHeight - (int)(LayoutHeight * Scale)) >> 1);