Upstream/CloverBootloader
1
0
Fork 0
mirror of https://github.com/CloverHackyColor/CloverBootloader.git synced 2025-02-25 02:32:21 +01:00
Code Issues Packages Projects Releases Wiki Activity

GetIcon memory leak.

Browse Source
This commit is contained in:
jief 2020-04-14 10:33:02 +03:00
parent 5520ede381
commit 807e36c427
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
rEFIt_UEFI/libeg/XTheme.cpp
View File

@ -319,19 +319,19 @@ const XImage& XTheme::GetIcon(INTN Id)
return Icons[i].Image; return Icons[i].Image;
} }
//if not found then create new one from embedded //if not found then create new one from embedded
Icon* NewIcon = new Icon(Id, true); Icon NewIcon(Id, true);
// NewIcon.GetEmbedded(); // NewIcon.GetEmbedded();
// DBG("got embedded icon %lld name{%s}\n", Id, IconsNames[Id]); // DBG("got embedded icon %lld name{%s}\n", Id, IconsNames[Id]);
if (!Daylight && !NewIcon->ImageNight.isEmpty()) { if (!Daylight && !NewIcon.ImageNight.isEmpty()) {
// DBG("got night icon and cache\n"); // DBG("got night icon and cache\n");
Icons[i].ImageNight = NewIcon->ImageNight; // Icons[i].ImageNight = NewIcon.ImageNight; //
return NewIcon->ImageNight; return Icons[i].ImageNight; // Do not return NewIcon.ImageNight, it'll freed
} }
//if daylight or night icon absent //if daylight or night icon absent
if (!NewIcon->Image.isEmpty()) { if (!NewIcon.Image.isEmpty()) {
// DBG("got day icon and cache\n"); // DBG("got day icon and cache\n");
Icons[i].Image = NewIcon->Image; Icons[i].Image = NewIcon.Image;
return NewIcon->Image; return Icons[i].Image;; // Do not return NewIcon.ImageNight, it'll freed
} }
} }
} }