More detailed comments/TODOs and code cleanup

This commit is contained in:
Christian Koop 2020-04-17 15:06:03 +02:00 committed by Brianna
parent df40a6323e
commit 124a796546
2 changed files with 4 additions and 2 deletions

View File

@ -47,6 +47,8 @@ public class ModuleAutoCrafting extends Module {
// jam check: is this hopper gummed up?
if (crafterEjection) {
// TODO: Recode. Why specifically eject ingredients (allMaterials).
// And why not eject when we checked crafting is possible
final List<Material> allMaterials = getRecipes(toCraft).getAllMaterials();
if (Stream.of(hopperCache.cachedInventory)
.allMatch(item -> item != null && allMaterials.stream().anyMatch(mat -> mat == item.getType()))) {
@ -105,7 +107,7 @@ public class ModuleAutoCrafting extends Module {
}
}
// Not enough items for this recipe
// Not enough ingredients for this recipe
if (amount != 0) continue;
for (Map.Entry<Integer, Integer> entry : slotsToAlter.entrySet()) {

View File

@ -134,7 +134,7 @@ public class HopperListeners implements Listener {
if (!allowItem) {
event.setCancelled(true);
if (moveInstead != null) {
// hopper code is a bit derpy - changing the item doesn't change what's removed
// hopper code is a bit derpy - changing the item doesn't change what's removed
//event.setItem(moveInstead);
// we need to instead cancel and manually remove the item to move
source.removeItem(moveInstead);