From 327806d9a11e00281e5efd467706238571540078 Mon Sep 17 00:00:00 2001
From: MD <1917406+md678685@users.noreply.github.com>
Date: Fri, 23 Oct 2020 00:19:04 +0100
Subject: [PATCH] Add new PR templates and revamp issue templates (#3711)

Adds new PR templates and revamps the existing issue templates to (hopefully) make the PR/issue submission easier to understand.
---
 .github/ISSUE_TEMPLATE/help.md               | 80 ++++++++++++++-----
 .github/ISSUE_TEMPLATE/report-a-bug.md       | 64 ++++++++++-----
 .github/ISSUE_TEMPLATE/request-a-feature.md  | 24 +++---
 .github/PULL_REQUEST_TEMPLATE/bug-fix.md     | 82 ++++++++++++++++++++
 .github/PULL_REQUEST_TEMPLATE/config.yml     |  8 ++
 .github/PULL_REQUEST_TEMPLATE/new-feature.md | 82 ++++++++++++++++++++
 CONTRIBUTING.md                              | 31 ++++++++
 README.md                                    |  6 +-
 8 files changed, 326 insertions(+), 51 deletions(-)
 create mode 100644 .github/PULL_REQUEST_TEMPLATE/bug-fix.md
 create mode 100644 .github/PULL_REQUEST_TEMPLATE/config.yml
 create mode 100644 .github/PULL_REQUEST_TEMPLATE/new-feature.md
 create mode 100644 CONTRIBUTING.md

diff --git a/.github/ISSUE_TEMPLATE/help.md b/.github/ISSUE_TEMPLATE/help.md
index 686935cfe..d46a29e87 100644
--- a/.github/ISSUE_TEMPLATE/help.md
+++ b/.github/ISSUE_TEMPLATE/help.md
@@ -5,42 +5,82 @@ labels: 'type: question'
 
 ---
 
-<!-- EssentialsX help guide
+<!-- EssentialsX help request guide
 
-Don't write inside the arrows as they will be hidden when you post your issue.
+NOTE: Failure to fill out this template properly may result in your issue being
+      delayed or ignored.
 
-Want faster support? Come join our Discord server to get help sooner:
-https://discord.gg/F7gexAQ
+Don't type between any arrows in the template, as this text will be hidden.
+This includes this header block and any other explanatory text blocks.
+
+Want faster support? Come join our Discord server to get help from both
+developers and community members: https://discord.gg/F7gexAQ
 
 If you're happy to wait (or you were sent here from Discord), read on:
 
-1.  Fill out the template.
-      This will help us understand what problem you've encountered and help us
-      find a solution.
-
-2.  Check the Common Issues page.
+1.  Check the Common Issues page.
       Read through the wiki page to see if you've encountered a regular issue:
       https://essentialsx.net/wiki/Common-Issues.html
 
-3.  Delete this line and all above lines before posting your issue!       -->
+2.  Fill out the template.
+      Run the commands in the console. Don't just put "latest" as a version, or
+      we will ignore it. This will help us understand what problem you've
+      encountered and help us find a solution.
+
+3.  When linking logs or config files, do not attach them to the post!
+      Copy and paste any logs into https://gist.github.com/, then paste a
+      link to them in the relevant parts of the template. Do not use Hastebin
+      or Pastebin, as this can cause issues when trying to solve issues in the
+      future.
+      **DO NOT drag logs into this text box!**
+
+4.  If you are encountering a performance issue, please include a link to a
+    Timings and/or profiler report.
+
+-->
 
 ### Information
 
-Full output of `/ess version`:
+**Full output of `/ess version`:**
+<!--
+    Run /ess version in the console, then paste the full output of the command
+    between the ```s.
+-->
+```
 
-<!-- Replace this with the command output -->
+```
 
-**Server log:** <!-- Upload `logs/latest.log` to https://gist.github.com/ -->
+**Server startup log:**
+<!--
+    Restart your server and upload `logs/latest.log` to
+    https://gist.github.com/. You may redact sensitive data (such as IP
+    addresses), but you should make it clear what data was removed. Once
+    uploaded, paste the link below this block.
+-->
+
+
+**EssentialsX config:**
+<!--
+    Upload `plugins/Essentials/config.yml` (and other config files if relevant)
+    to https://gist.github.com/ then paste the link below this block.
+-->
 
-**EssentialsX config** <!-- Upload `plugins/Essentials/config.yml` to https://gist.github.com/ -->
 
 ### Help request
 
-**Problem**
-<!-- What problem did you encounter? -->
+**Problem:**  
+<!-- What problem did you encounter? Type below this line. -->
 
-**What I have tried**
-<!-- What have you tried so far? -->
+**What I have tried:**  
+<!-- What have you tried so far? Type below this line. -->
 
-**Screenshots**
-<!-- If relevant, include any screenshots here. -->
+**Console stack trace:**  
+<!--
+    If you are reporting an error in the console, paste it between the ```s.
+-->
+```
+
+```
+
+**Screenshots:**  
+<!-- If relevant, include any screenshots or a video below this line. -->
diff --git a/.github/ISSUE_TEMPLATE/report-a-bug.md b/.github/ISSUE_TEMPLATE/report-a-bug.md
index b6b22c2c2..3583fd794 100644
--- a/.github/ISSUE_TEMPLATE/report-a-bug.md
+++ b/.github/ISSUE_TEMPLATE/report-a-bug.md
@@ -7,7 +7,11 @@ labels: 'bug: unconfirmed'
 
 <!-- EssentialsX bug reporting guide
 
-Don't put anything inside this block, as it won't be included in the issue.
+NOTE: Failure to fill out this template properly may result in your issue being
+      delayed or ignored.
+
+Don't type between any arrows in the template, as this text will be hidden.
+This includes this header block and any other explanatory text blocks.
 
 If you are reporting a bug, please follow the following steps:
 
@@ -19,7 +23,7 @@ If you are reporting a bug, please follow the following steps:
       Copy and paste any logs into https://gist.github.com/, then paste a
       link to them in the relevant parts of the template. Avoid using
       Hastebin or Pastebin, as this makes providing support more difficult.
-      **DO NOT drag files into this box!**
+      **DO NOT drag files into this text box!**
 
 3.  If you are reporting a performance issue, please include a link to a
     Timings and/or profiler report.
@@ -27,33 +31,53 @@ If you are reporting a bug, please follow the following steps:
 4.  If you are reporting a bug with commands or something else in-game,
     please include screenshots to help us diagnose the problem.
 
-5.  Make sure not to write between the arrows, as anything there will be
-    hidden.
-
-6.  Delete this line and all above lines before posting your issue!       -->
+-->
 
 ### Information
 
-**Full output of `/ess version`**:
-
-```
-<!-- Run the command in your console, and copy and paste the whole output here -->
+**Full output of `/ess version`:**
+<!--
+    Run /ess version in the console, then paste the full output of the command
+    between the ```s.
+-->
 ```
 
-**Server log**: <!-- Upload `logs/latest.log` to https://gist.github.com/, replace this with link -->
+```
+
+**Server startup log:**
+<!--
+    Restart your server and upload `logs/latest.log` to
+    https://gist.github.com/. You may redact sensitive data (such as IP
+    addresses), but you should make it clear what data was removed. Once
+    uploaded, paste the link below this block.
+-->
+
+
+**EssentialsX config:**
+<!--
+    Upload `plugins/Essentials/config.yml` (and other config files if relevant)
+    to https://gist.github.com/ then paste the link below this block.
+-->
 
-**EssentialsX config**: <!-- Upload `plugins/Essentials/config.yml` to https://gist.github.com/, replace this with link -->
 
 ### Details
 
-**Description**  
-<!-- Replace this with a brief summary of the bug. -->
+**Description:**  
+<!-- What is the bug? Type a brief summary below this line. -->
 
-**Steps to reproduce**  
-<!-- Replace this with exactly what you did to cause the bug. -->
+**Steps to reproduce:**  
+<!-- How did you cause it? Describe what you did to cause the bug below. -->
 
-**Expected behavior**  
-<!-- Replace this with what you expected to happen. -->
+**Expected behavior:**  
+<!-- What did you expect to happen? Type below this line. -->
 
-**Screenshots**  
-<!-- Replace this with screenshots, if necessary. -->
+**Console stack trace:**  
+<!--
+    If you are encountering an error in the console, paste it between the ```s.
+-->
+```
+
+```
+
+**Screenshots:**  
+<!-- If necessary, include screenshots or a video below this line. -->
diff --git a/.github/ISSUE_TEMPLATE/request-a-feature.md b/.github/ISSUE_TEMPLATE/request-a-feature.md
index a848dfa7b..fcda835c3 100644
--- a/.github/ISSUE_TEMPLATE/request-a-feature.md
+++ b/.github/ISSUE_TEMPLATE/request-a-feature.md
@@ -7,8 +7,11 @@ labels: 'type: enhancement'
 
 <!-- EssentialsX feature request guide
 
-Fill out the template. Don't write inside the arrows as they will be hidden
-when you post your issue.
+NOTE: Failure to fill out this template properly may result in your issue being
+      delayed or ignored.
+
+Don't type between any arrows in the template, as this text will be hidden.
+This includes this header block and any other explanatory text blocks.
 
 Not sure if your feature fits in EssentialsX? Feel free to ask on our Discord
 server: https://discord.gg/F7gexAQ
@@ -27,20 +30,23 @@ If you have a feature suggestion for EssentialsX, read the following tips:
 3.  Check whether it has already been asked or added.
       You can search the issue tracker to see if your feature has already been
       requested at https://github.com/EssentialsX/Essentials/issues. You can
-      also check the changelogs at https://github.com/EssentialsX/Essentials/releases
-      to see if the feature was recently added.
+      also check the changelogs to see if the feature was recently added:
+      https://github.com/EssentialsX/Essentials/releases
 
 4.  Ask yourself: "Does this belong in EssentialsX?"
       There are lots of features that we reject because most servers won't
       need or use them. If your feature is very specific or already exists in
       another plugin, it might not be a good fit for EssentialsX.
 
-5.  Delete this line and all above lines before posting your issue!       -->
+-->
 
 ### Feature request
 
-**Feature description**
-<!-- What feature are you suggesting? -->
+**Feature description:**  
+<!-- What feature are you suggesting? Type below this line. -->
 
-**How the feature is useful**
-<!-- How is the feature useful to players, server owners and/or developers? -->
+**How the feature is useful:**  
+<!--
+    How is the feature useful to players, server owners and/or developers?
+    Type below this block.
+-->
diff --git a/.github/PULL_REQUEST_TEMPLATE/bug-fix.md b/.github/PULL_REQUEST_TEMPLATE/bug-fix.md
new file mode 100644
index 000000000..c833e1210
--- /dev/null
+++ b/.github/PULL_REQUEST_TEMPLATE/bug-fix.md
@@ -0,0 +1,82 @@
+---
+name: Bug fix
+about: Use this if your PR fixes a bug in EssentialsX.
+labels: 'type: bugfix'
+---
+
+<!-- EssentialsX bug fix submission guide
+
+NOTE: Failure to fill out this template properly may result in your PR being
+      delayed or ignored without warning.
+
+Don't type between any arrows in the template, as this text will be hidden.
+This includes this header block and any other explanatory text blocks.
+
+Want to discuss your PR before submitting it? Join the EssentialsX Development
+server: https://discord.gg/CUN7qVb
+
+By contributing to EssentialsX, you agree to license your code under the
+GNU General Public License version 3, which can be found at the link below:
+https://github.com/EssentialsX/Essentials/blob/2.x/LICENSE
+
+If you are submitting a bug fix, please follow the following steps:
+
+1.  Fill out the template in full.
+      This includes providing screenshots and a link to the original bug 
+      report. If there isn't an existing bug report, we recommend opening a new
+      detailed bug report BEFORE opening your PR to fix it, else your PR may be
+      delayed or rejected without warning.
+      
+      You can open a new bug report by following this link:
+      https://github.com/EssentialsX/Essentials/issues/new/choose 
+
+2.  When linking logs or config files, do not attach them to the post!
+      Copy and paste any logs into https://gist.github.com/, then paste a
+      link to them in the relevant parts of the template. Do not use Hastebin
+      or Pastebin, as this can cause issues with future reviews.
+      **DO NOT drag logs into this text box!**
+
+3.  If you are fixing a performance issue, please include a link to a
+    Timings and/or profiler report, both before and after your PR.
+
+4.  If you are fixing a visual bug, such as in commands, please include
+    screenshots so that we can more easily review the proposed fix.
+    (You may drag screenshots directly into this box.)
+
+-->
+
+### Information
+
+<!--
+    Replace #nnnn with the number of the original issue. If this PR fixes
+    multiple issues, you should repeat the phrase "fixes #nnnn" for each issue. 
+-->
+
+This PR fixes #nnnn. 
+
+### Details
+
+**Proposed fix:**    
+<!-- Type a description of your proposed fix below this line. -->
+
+
+**Environments tested:**    
+<!--
+    Below this line, put an "x" inside the box for the environments you have
+    tested this bug fix on, and if relevant alter the OS and Java version
+    accordingly. If this feature does not apply to an environment, strike
+    through the environment using ~~strikethrough~~. If you have tested on
+    other environments, add a new line with relevant details.
+-->
+
+- [ ] Paper 1.16.3 (any OS, any Java 8+ version)
+- [ ] CraftBukkit/Spigot/Paper 1.12.2 (any OS, any Java 8+ version)
+- [ ] CraftBukkit 1.8.8 (any OS, any Java 8+ version)
+
+
+**Demonstration:**    
+<!--
+    Below this block, include screenshots/log snippets from before and after as
+    necessary. If you have created or used a test case plugin, please link to a
+    download of the plugin, source code and exact version used where possible.
+-->
diff --git a/.github/PULL_REQUEST_TEMPLATE/config.yml b/.github/PULL_REQUEST_TEMPLATE/config.yml
new file mode 100644
index 000000000..68f0c161b
--- /dev/null
+++ b/.github/PULL_REQUEST_TEMPLATE/config.yml
@@ -0,0 +1,8 @@
+blank_issues_enabled: false
+contact_links:
+  - name: MOSS Discord Server
+    url: https://discord.gg/casfFyh
+    about: Need help with using EssentialsX? Join the MOSS Discord server for help.
+  - name: EssentialsX Development Discord Server
+    url: https://discord.gg/CUN7qVb
+    about: Got questions or want to discuss changes before opening your PR? Join the EssentialsX Development Discord server. (Need help? Join MOSS instead.)
diff --git a/.github/PULL_REQUEST_TEMPLATE/new-feature.md b/.github/PULL_REQUEST_TEMPLATE/new-feature.md
new file mode 100644
index 000000000..c019e8037
--- /dev/null
+++ b/.github/PULL_REQUEST_TEMPLATE/new-feature.md
@@ -0,0 +1,82 @@
+---
+name: Feature addition
+about: Use this if your PR adds a new feature to EssentialsX.
+labels: 'type: enhancement'
+---
+
+<!-- EssentialsX feature submission guide
+
+NOTE: Failure to fill out this template properly may result in your PR being
+      delayed or ignored without warning.
+
+Don't type between any arrows in the template, as this text will be hidden.
+This includes this header block and any other explanatory text blocks.
+
+Want to discuss your PR before submitting it? Join the EssentialsX Development
+server: https://discord.gg/CUN7qVb
+
+By contributing to EssentialsX, you agree to license your code under the
+GNU General Public License version 3, which can be found at the link below:
+https://github.com/EssentialsX/Essentials/blob/2.x/LICENSE
+
+If you are submitting a new feature, please follow the following steps:
+
+1.  Fill out the template in full.
+      This includes providing screenshots and a link to the original feature 
+      request. If there isn't an existing feature request, we strongly
+      recommend opening a new feature request BEFORE opening your PR to
+      implement it, as this allows us to review whether we're likely to accept
+      your feature in advance, and also allows us to discuss possible
+      implementations for the feature. If there is no associated feature
+      request, your PR may be delayed or rejected without warning.
+      
+      You can open a new feature request by following this link:
+      https://github.com/EssentialsX/Essentials/issues/new/choose
+
+2.  If you are fixing a performance issue, please use the "Bug fix" PR template
+      instead. The "bug fix" template is better suited to performance issues.
+
+3.  Include a demonstration.
+      If you are adding commands, please provide screenshots and/or a video
+      demonstration of the feature. Similarly, if you are adding a new API,
+      please include a link to example code that takes advantage of your
+      proposed API. This will aid us in reviewing PRs and speed up the process
+      significantly.
+
+-->
+
+### Information
+
+<!--
+    Replace #nnnn with the number of the original issue. If this PR implements
+    features from multiple issues, you should repeat the phrase "closes #nnnn"
+    for each issue. 
+-->
+
+This PR closes #nnnn. 
+
+### Details
+
+**Proposed feature**  
+<!-- Type a description of your proposed feature below this line. -->
+
+**Environments tested:**  
+<!--
+    Below this block, put an "x" inside the box for the environments you have
+    tested this bug fix on, and if relevant alter the OS and Java version
+    accordingly. If this feature does not apply to an environment, strike
+    through the environment using ~~strikethrough~~. If you have tested on
+    other environments, add a new line with relevant details.
+-->
+
+- [ ] Paper 1.16.3 (any OS, any Java 8+ version)
+- [ ] CraftBukkit/Spigot/Paper 1.12.2 (any OS, any Java 8+ version)
+- [ ] CraftBukkit 1.8.8 (any OS, any Java 8+ version)
+
+**Demonstration:**  
+<!--
+    Below this block, include screenshots/code snippets from before and after
+    as necessary. If you have created or used a test case plugin, please link
+    to a download of the plugin, source code and exact version used where
+    possible.
+-->
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
new file mode 100644
index 000000000..0c26baf29
--- /dev/null
+++ b/CONTRIBUTING.md
@@ -0,0 +1,31 @@
+Contributing to EssentialsX
+===========================
+
+Want to help improve EssentialsX? There are several ways you can support and contribute to the project.
+
+If you'd like to make a financial contribution to the project, you can join our [Patreon](https://www.patreon.com/essentialsx/),
+or to make a one-off donation you can visit our [Ko-fi page](https://ko-fi.com/essentialsx). If you can't make a
+donation, don't worry! There are lots of other ways to contribute:
+
+* Do you run a server? Take a look at our ["help wanted"](https://github.com/EssentialsX/Essentials/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc+label%3A%22help+wanted%22)
+  and ["bug: unconfirmed"](https://github.com/EssentialsX/Essentials/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc+label%3A%22bug%3A+unconfirmed%22)
+  issues, where you can find issues that need extra testing and investigation.
+* Do you speak multiple languages? If so, we always welcome contributions to our [Crowdin project](https://crowdin.com/project/essentialsx-official).
+* Do you enjoy helping others? If so, why not contribute to the [EssentialsX documentation](https://github.com/EssentialsX/wiki)?
+  You can also join the [MOSS Discord community](https://discord.gg/casfFyh) and provide direct community support to
+  other EssentialsX users.
+* If you're a developer, you could look through our ["open to PR"](https://github.com/EssentialsX/Essentials/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc+label%3A%22status%3A+open+to+PR%22)
+  issues. We're always happy to receive bug fixes and feature additions as pull requests.
+
+Submitting a PR
+---------------
+
+EssentialsX has extensive templates for PRs that detail how to submit your PR. To find out more, see the PR templates for:
+* [Bug fixes](https://github.com/EssentialsX/Essentials/blob/2.x/.github/PULL_REQUEST_TEMPLATE/bug-fix.md) 
+* [New features](https://github.com/EssentialsX/Essentials/blob/2.x/.github/PULL_REQUEST_TEMPLATE/new-feature.md)
+
+Want to discuss a feature before opening a PR? Join the [EssentialsX Development Discord server](https://discord.gg/CUN7qVb). Note that this server is **not for end-users** - if you need support with EssentialsX, you should join [MOSS](https://discord.gg/casfFyh) instead.
+
+By contributing to EssentialsX, you agree to license your code under the [GNU General Public License version 3](https://github.com/EssentialsX/Essentials/blob/2.x/LICENSE).
+
+
diff --git a/README.md b/README.md
index 0bc1f572e..66f60c2c9 100644
--- a/README.md
+++ b/README.md
@@ -59,11 +59,11 @@ To depend on EssentialsX 2.18.1, you should use the artifact `net.ess3:Essential
 Contributing
 ------------
 
-Want to help improve EssentialsX? There are numerous ways you can contribute to the project.
+Want to help improve EssentialsX? There are several ways you can support and contribute to the project.
 
 If you'd like to make a financial contribution to the project, you can join our [Patreon](https://www.patreon.com/essentialsx/),
 or to make a one-off donation you can visit our [Ko-fi page](https://ko-fi.com/essentialsx). If you can't make a
-donation, don't worry! There's lots of other ways to contribute:
+donation, don't worry! There are lots of other ways to contribute:
 
 * Do you run a server? Take a look at our ["help wanted"](https://github.com/EssentialsX/Essentials/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc+label%3A%22help+wanted%22)
   and ["bug: unconfirmed"](https://github.com/EssentialsX/Essentials/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc+label%3A%22bug%3A+unconfirmed%22)
@@ -74,3 +74,5 @@ donation, don't worry! There's lots of other ways to contribute:
   other EssentialsX users.
 * If you're a developer, you could look through our ["open to PR"](https://github.com/EssentialsX/Essentials/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc+label%3A%22status%3A+open+to+PR%22)
   issues. We're always happy to receive bug fixes and feature additions as pull requests.
+
+See [CONTRIBUTING.md](https://github.com/EssentialsX/Essentials/blob/2.x/CONTRIBUTING.md) to find out more.