From c76e4239bb817a246c418ec1d53de0ca6d5114c6 Mon Sep 17 00:00:00 2001
From: Josh Roy <10731363+JRoy@users.noreply.github.com>
Date: Thu, 13 May 2021 17:30:37 -0400
Subject: [PATCH] Ensure NPC userdata creation for Citizen NPCs (#4149)

https://github.com/CitizensDev/Citizens2/blob/0ddfcbd0fa99678934e7b086f1a7b92e6a1bc49e/v1_16_R3/src/main/java/net/citizensnpcs/nms/v1_16_R3/entity/HumanController.java#L36-L40

why????????????????????????????????????????????????????????????
---
 .../essentials/economy/vault/VaultEconomyProvider.java       | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/Essentials/src/main/java/com/earth2me/essentials/economy/vault/VaultEconomyProvider.java b/Essentials/src/main/java/com/earth2me/essentials/economy/vault/VaultEconomyProvider.java
index 88c251a2b..273f8b410 100644
--- a/Essentials/src/main/java/com/earth2me/essentials/economy/vault/VaultEconomyProvider.java
+++ b/Essentials/src/main/java/com/earth2me/essentials/economy/vault/VaultEconomyProvider.java
@@ -283,8 +283,9 @@ public class VaultEconomyProvider implements Economy {
             return false;
         }
 
-        // This is a UUID generated from a seed that is 100% an NPC or offline mode user.
-        if (player.getUniqueId().version() == 3) {
+        // String based UUIDs are version 3 and are used for NPC and OfflinePlayers
+        // Citizens uses v2 UUIDs, yeah I don't know either!
+        if (player.getUniqueId().version() == 3 || player.getUniqueId().version() == 2) {
             final File folder = new File(ess.getDataFolder(), "userdata");
             if (!folder.exists()) {
                 if (!folder.mkdirs()) {