Upstream/LuckPerms
1
0
Fork 0
mirror of https://github.com/LuckPerms/LuckPerms.git synced 2025-01-16 13:21:32 +01:00
Code Issues Projects Releases Wiki Activity

Fix potential race condition in MRUCache

Browse Source
This commit is contained in:
Luck 2020-06-21 22:07:53 +01:00
parent 6cb0f5e810
commit 21ae1dbac0
No known key found for this signature in database
GPG Key ID: EFA9B3EC5FD90F8B
1 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
common/src/main/java/me/lucko/luckperms/common/cache/MRUCache.java vendored
View File

@ -46,13 +46,21 @@ public abstract class MRUCache<T> {
}
protected void offerRecent(int validAt, T offer) {
if (validAt == this.modCount.get()) {
this.recent = offer;
synchronized (this) {
if (validAt == this.modCount.get()) {
this.recent = offer;
}
}
}
/**
* Calling clearRecent effectively resets the instance. any other threads going to call
* offerRecent in the future with the previous mod count will be ignored.
*/
protected void clearRecent() {
this.recent = null;
this.modCount.incrementAndGet();
synchronized (this) {
this.recent = null;
this.modCount.incrementAndGet();
}
}
}