Upstream/LuckPerms
1
0
Fork 0
mirror of https://github.com/LuckPerms/LuckPerms.git synced 2025-02-05 15:11:56 +01:00
Code Issues Projects Releases Wiki Activity

Add notice to inform users to ignore 'illegal reflective access' warning messages (#952)

Browse Source
This commit is contained in:
Luck 2020-03-19 12:14:17 +00:00
parent ac9fe74785
commit 3973aa1000
No known key found for this signature in database
GPG Key ID: EFA9B3EC5FD90F8B
1 changed files with 41 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

55
common/src/main/java/me/lucko/luckperms/common/dependencies/classloader/ReflectionClassLoader.java
View File

@ -25,6 +25,11 @@
package me.lucko.luckperms.common.dependencies.classloader; package me.lucko.luckperms.common.dependencies.classloader;
import com.google.common.base.Supplier;
import com.google.common.base.Suppliers;
import me.lucko.luckperms.common.plugin.bootstrap.LuckPermsBootstrap;
import java.lang.reflect.InvocationTargetException; import java.lang.reflect.InvocationTargetException;
import java.lang.reflect.Method; import java.lang.reflect.Method;
import java.net.MalformedURLException; import java.net.MalformedURLException;
@ -33,34 +38,56 @@ import java.net.URLClassLoader;
import java.nio.file.Path; import java.nio.file.Path;
public class ReflectionClassLoader implements PluginClassLoader { public class ReflectionClassLoader implements PluginClassLoader {
private static final Method ADD_URL_METHOD;
static {
try {
ADD_URL_METHOD = URLClassLoader.class.getDeclaredMethod("addURL", URL.class);
ADD_URL_METHOD.setAccessible(true);
} catch (NoSuchMethodException e) {
throw new ExceptionInInitializerError(e);
}
}
private final URLClassLoader classLoader; private final URLClassLoader classLoader;
public ReflectionClassLoader(Object plugin) throws IllegalStateException { @SuppressWarnings("Guava") // we can't use java.util.Function because old Guava versions are used at runtime
ClassLoader classLoader = plugin.getClass().getClassLoader(); private final Supplier<Method> addUrlMethod;
public ReflectionClassLoader(LuckPermsBootstrap bootstrap) throws IllegalStateException {
ClassLoader classLoader = bootstrap.getClass().getClassLoader();
if (classLoader instanceof URLClassLoader) { if (classLoader instanceof URLClassLoader) {
this.classLoader = (URLClassLoader) classLoader; this.classLoader = (URLClassLoader) classLoader;
} else { } else {
throw new IllegalStateException("ClassLoader is not instance of URLClassLoader"); throw new IllegalStateException("ClassLoader is not instance of URLClassLoader");
} }
this.addUrlMethod = Suppliers.memoize(() -> {
if (getJavaMajorVersion() >= 9) {
bootstrap.getPluginLogger().info("It is safe to ignore any warning printed following this message " +
"starting with 'WARNING: An illegal reflective access operation has occurred, Illegal reflective " +
"access by " + getClass().getName() + "'.");
bootstrap.getPluginLogger().info("This is intended, and will not have any impact the operation of LuckPerms.");
}
try {
Method addUrlMethod = URLClassLoader.class.getDeclaredMethod("addURL", URL.class);
addUrlMethod.setAccessible(true);
return addUrlMethod;
} catch (NoSuchMethodException e) {
throw new RuntimeException(e);
}
});
} }
@Override @Override
public void addJarToClasspath(Path file) { public void addJarToClasspath(Path file) {
try { try {
ADD_URL_METHOD.invoke(this.classLoader, file.toUri().toURL()); this.addUrlMethod.get().invoke(this.classLoader, file.toUri().toURL());
} catch (IllegalAccessException | InvocationTargetException | MalformedURLException e) { } catch (IllegalAccessException | InvocationTargetException | MalformedURLException e) {
throw new RuntimeException(e); throw new RuntimeException(e);
} }
} }
private static int getJavaMajorVersion() {
String version = System.getProperty("java.version");
if (version.startsWith("1.")) {
version = version.substring(2, 3);
} else {
int dot = version.indexOf(".");
if (dot != -1) {
version = version.substring(0, dot);
}
}
return Integer.parseInt(version);
}
} }