Automatically push updates to other servers via the messaging service when commands are ran

bukkit/src/main/java/me/lucko/luckperms/bukkit/LPBukkitPlugin.java

@@ -60,6 +60,7 @@ import me.lucko.luckperms.common.managers.impl.GenericGroupManager;
 import me.lucko.luckperms.common.managers.impl.GenericTrackManager;
 import me.lucko.luckperms.common.managers.impl.GenericUserManager;
 import me.lucko.luckperms.common.messaging.InternalMessagingService;
+import me.lucko.luckperms.common.messaging.NoopMessagingService;
 import me.lucko.luckperms.common.messaging.RedisMessaging;
 import me.lucko.luckperms.common.plugin.LuckPermsPlugin;
 import me.lucko.luckperms.common.storage.Storage;
@@ -217,6 +218,10 @@ public class LPBukkitPlugin extends JavaPlugin implements LuckPermsPlugin {
             getLog().warn("Messaging service '" + messagingType + "' not recognised.");
         }
 
+        if (messagingService == null) {
+            messagingService = new NoopMessagingService();
+        }
+
         // setup the update task buffer
         updateTaskBuffer = new BufferedRequest<Void>(1000L, this::doAsync) {
             @Override

bukkit/src/main/resources/config.yml

@@ -258,6 +258,9 @@ data:
 # none ==> nothing
 messaging-service: none
 
+# If LuckPerms should automatically push updates after a change has been made with a command.
+auto-push-updates: true
+
 # Settings for Redis.
 # Port 6379 is used by default; set address to "host:port" if differs
 redis:

bungee/src/main/java/me/lucko/luckperms/bungee/LPBungeePlugin.java

@@ -52,6 +52,7 @@ import me.lucko.luckperms.common.managers.impl.GenericGroupManager;
 import me.lucko.luckperms.common.managers.impl.GenericTrackManager;
 import me.lucko.luckperms.common.managers.impl.GenericUserManager;
 import me.lucko.luckperms.common.messaging.InternalMessagingService;
+import me.lucko.luckperms.common.messaging.NoopMessagingService;
 import me.lucko.luckperms.common.messaging.RedisMessaging;
 import me.lucko.luckperms.common.plugin.LuckPermsPlugin;
 import me.lucko.luckperms.common.plugin.LuckPermsScheduler;
@@ -162,6 +163,10 @@ public class LPBungeePlugin extends Plugin implements LuckPermsPlugin {
             getLog().warn("Messaging service '" + messagingType + "' not recognised.");
         }
 
+        if (messagingService == null) {
+            messagingService = new NoopMessagingService();
+        }
+
         // setup the update task buffer
         updateTaskBuffer = new BufferedRequest<Void>(1000L, this::doAsync) {
             @Override

bungee/src/main/resources/config.yml

@@ -199,6 +199,9 @@ data:
 # none ==> nothing
 messaging-service: none
 
+# If LuckPerms should automatically push updates after a change has been made with a command.
+auto-push-updates: true
+
 # Settings for Redis.
 # Port 6379 is used by default; set address to "host:port" if differs
 redis:

common/src/main/java/me/lucko/luckperms/common/api/ApiProvider.java

@@ -46,6 +46,8 @@ import me.lucko.luckperms.common.core.NodeBuilder;
 import me.lucko.luckperms.common.core.UserIdentifier;
 import me.lucko.luckperms.common.event.EventFactory;
 import me.lucko.luckperms.common.event.LuckPermsEventBus;
+import me.lucko.luckperms.common.messaging.InternalMessagingService;
+import me.lucko.luckperms.common.messaging.NoopMessagingService;
 import me.lucko.luckperms.common.plugin.LuckPermsPlugin;
 
 import java.util.Optional;
@@ -103,7 +105,8 @@ public class ApiProvider implements LuckPermsApi {
 
     @Override
     public Optional<MessagingService> getMessagingService() {
-        return Optional.ofNullable(plugin.getMessagingService());
+        InternalMessagingService service = plugin.getMessagingService();
+        return service instanceof NoopMessagingService ? Optional.empty() : Optional.of(service);
     }
 
     @Override

common/src/main/java/me/lucko/luckperms/common/commands/abstraction/SubCommand.java

@@ -29,11 +29,14 @@ import com.google.common.base.Splitter;
 import me.lucko.luckperms.common.commands.Arg;
 import me.lucko.luckperms.common.commands.sender.Sender;
 import me.lucko.luckperms.common.commands.utils.Util;
+import me.lucko.luckperms.common.config.ConfigKeys;
 import me.lucko.luckperms.common.constants.Message;
 import me.lucko.luckperms.common.constants.Permission;
 import me.lucko.luckperms.common.core.model.Group;
 import me.lucko.luckperms.common.core.model.Track;
 import me.lucko.luckperms.common.core.model.User;
+import me.lucko.luckperms.common.messaging.InternalMessagingService;
+import me.lucko.luckperms.common.messaging.NoopMessagingService;
 import me.lucko.luckperms.common.plugin.LuckPermsPlugin;
 import me.lucko.luckperms.common.treeview.PermissionVault;
 import me.lucko.luckperms.common.treeview.TreeNode;
@@ -174,6 +177,11 @@ public abstract class SubCommand<T> extends Command<T, Void> {
             user.getRefreshBuffer().requestDirectly();
         }
 
+        InternalMessagingService messagingService = plugin.getMessagingService();
+        if (!sender.isImport() && !(messagingService instanceof NoopMessagingService) && plugin.getConfiguration().get(ConfigKeys.AUTO_PUSH_UPDATES)) {
+            messagingService.getUpdateBuffer().request();
+        }
+
         if (success) {
             Message.USER_SAVE_SUCCESS.send(sender);
         } else {
@@ -190,6 +198,11 @@ public abstract class SubCommand<T> extends Command<T, Void> {
             plugin.getUpdateTaskBuffer().requestDirectly();
         }
 
+        InternalMessagingService messagingService = plugin.getMessagingService();
+        if (!sender.isImport() && !(messagingService instanceof NoopMessagingService) && plugin.getConfiguration().get(ConfigKeys.AUTO_PUSH_UPDATES)) {
+            messagingService.getUpdateBuffer().request();
+        }
+
         if (success) {
             Message.GROUP_SAVE_SUCCESS.send(sender);
         } else {
@@ -206,6 +219,11 @@ public abstract class SubCommand<T> extends Command<T, Void> {
             plugin.getUpdateTaskBuffer().requestDirectly();
         }
 
+        InternalMessagingService messagingService = plugin.getMessagingService();
+        if (!sender.isImport() && !(messagingService instanceof NoopMessagingService) && plugin.getConfiguration().get(ConfigKeys.AUTO_PUSH_UPDATES)) {
+            messagingService.getUpdateBuffer().request();
+        }
+
         if (success) {
             Message.TRACK_SAVE_SUCCESS.send(sender);
         } else {

common/src/main/java/me/lucko/luckperms/common/commands/impl/misc/InfoCommand.java

@@ -30,6 +30,7 @@ import me.lucko.luckperms.common.config.ConfigKeys;
 import me.lucko.luckperms.common.config.LuckPermsConfiguration;
 import me.lucko.luckperms.common.constants.Message;
 import me.lucko.luckperms.common.constants.Permission;
+import me.lucko.luckperms.common.messaging.NoopMessagingService;
 import me.lucko.luckperms.common.plugin.LuckPermsPlugin;
 import me.lucko.luckperms.common.utils.Predicates;
 
@@ -66,7 +67,7 @@ public class InfoCommand extends SingleCommand {
                 plugin.getStorage().getName(),
                 c.get(ConfigKeys.SERVER),
                 c.get(ConfigKeys.SYNC_TIME),
-                plugin.getMessagingService() == null ? "None" : plugin.getMessagingService().getName(),
+                plugin.getMessagingService() instanceof NoopMessagingService ? "None" : plugin.getMessagingService().getName(),
                 plugin.getPlayerCount(),
                 plugin.getUserManager().getAll().size(),
                 plugin.getGroupManager().getAll().size(),

common/src/main/java/me/lucko/luckperms/common/commands/impl/misc/NetworkSyncCommand.java

@@ -28,6 +28,7 @@ import me.lucko.luckperms.common.commands.sender.Sender;
 import me.lucko.luckperms.common.constants.Message;
 import me.lucko.luckperms.common.constants.Permission;
 import me.lucko.luckperms.common.messaging.InternalMessagingService;
+import me.lucko.luckperms.common.messaging.NoopMessagingService;
 import me.lucko.luckperms.common.plugin.LuckPermsPlugin;
 import me.lucko.luckperms.common.utils.Predicates;
 
@@ -47,7 +48,7 @@ public class NetworkSyncCommand extends SingleCommand {
 
         InternalMessagingService messagingService = plugin.getMessagingService();
 
-        if (messagingService == null) {
+        if (messagingService instanceof NoopMessagingService) {
             Message.UPDATE_TASK_PUSH_FAILURE_NOT_SETUP.send(sender);
             return CommandResult.FAILURE;
         }

common/src/main/java/me/lucko/luckperms/common/config/ConfigKeys.java

@@ -180,6 +180,7 @@ public class ConfigKeys {
                 .build();
     }));
     public static final ConfigKey<String> MESSAGING_SERVICE = EnduringKey.wrap(StringKey.of("messaging-service", "none"));
+    public static final ConfigKey<Boolean> AUTO_PUSH_UPDATES = EnduringKey.wrap(BooleanKey.of("auto-push-updates", true));
     public static final ConfigKey<Boolean> REDIS_ENABLED = EnduringKey.wrap(BooleanKey.of("redis.enabled", false));
     public static final ConfigKey<String> REDIS_ADDRESS = EnduringKey.wrap(StringKey.of("redis.address", null));
     public static final ConfigKey<String> REDIS_PASSWORD = EnduringKey.wrap(StringKey.of("redis.password", ""));

common/src/main/java/me/lucko/luckperms/common/messaging/AbstractMessagingService.java

@@ -26,6 +26,7 @@ import lombok.Getter;
 import lombok.RequiredArgsConstructor;
 
 import me.lucko.luckperms.common.plugin.LuckPermsPlugin;
+import me.lucko.luckperms.common.utils.BufferedRequest;
 
 import java.util.Collections;
 import java.util.HashSet;
@@ -40,6 +41,7 @@ import java.util.function.Consumer;
 public abstract class AbstractMessagingService implements InternalMessagingService {
     public static final String CHANNEL = "lpuc";
 
+    @Getter
     private final LuckPermsPlugin plugin;
 
     @Getter
@@ -47,6 +49,15 @@ public abstract class AbstractMessagingService implements InternalMessagingServi
 
     private final Set<UUID> receivedMsgs = Collections.synchronizedSet(new HashSet<>());
 
+    @Getter
+    private final BufferedRequest<Void> updateBuffer = new BufferedRequest<Void>(10000L, r -> getPlugin().doAsync(r)) {
+        @Override
+        protected Void perform() {
+            pushUpdate();
+            return null;
+        }
+    };
+
     protected abstract void sendMessage(String channel, String message);
 
     protected void onMessage(String channel, String msg, Consumer<UUID> callback) {

common/src/main/java/me/lucko/luckperms/common/messaging/InternalMessagingService.java

@@ -23,10 +23,27 @@
 package me.lucko.luckperms.common.messaging;
 
 import me.lucko.luckperms.api.MessagingService;
+import me.lucko.luckperms.common.utils.BufferedRequest;
 
 public interface InternalMessagingService extends MessagingService {
 
+    /**
+     * Gets the name of this messaging service
+     *
+     * @return the name of this messaging service
+     */
     String getName();
+
+    /**
+     * Closes the messaging service
+     */
     void close();
 
+    /**
+     * Gets the buffer for sending updates to other servers
+     *
+     * @return the update buffer
+     */
+    BufferedRequest<Void> getUpdateBuffer();
+
 }

common/src/main/java/me/lucko/luckperms/common/messaging/NoopMessagingService.java

@@ -0,0 +1,48 @@
+/*
+ * Copyright (c) 2016 Lucko (Luck) <luck@lucko.me>
+ *
+ *  Permission is hereby granted, free of charge, to any person obtaining a copy
+ *  of this software and associated documentation files (the "Software"), to deal
+ *  in the Software without restriction, including without limitation the rights
+ *  to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ *  copies of the Software, and to permit persons to whom the Software is
+ *  furnished to do so, subject to the following conditions:
+ *
+ *  The above copyright notice and this permission notice shall be included in all
+ *  copies or substantial portions of the Software.
+ *
+ *  THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ *  IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ *  FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ *  AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ *  LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ *  OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+ *  SOFTWARE.
+ */
+
+package me.lucko.luckperms.common.messaging;
+
+import me.lucko.luckperms.common.utils.BufferedRequest;
+
+public class NoopMessagingService implements InternalMessagingService {
+
+    @Override
+    public String getName() {
+        return "No op";
+    }
+
+    @Override
+    public void close() {
+
+    }
+
+    @Override
+    public BufferedRequest<Void> getUpdateBuffer() {
+        return null;
+    }
+
+    @Override
+    public void pushUpdate() {
+
+    }
+}

common/src/main/java/me/lucko/luckperms/common/plugin/LuckPermsPlugin.java

@@ -100,7 +100,7 @@ public interface LuckPermsPlugin {
     Storage getStorage();
 
     /**
-     * Gets the redis messaging instance if present. Could return null if redis is not enabled.
+     * Gets the redis messaging instance.
      *
      * @return the redis messaging service
      */

sponge/src/main/java/me/lucko/luckperms/sponge/LPSpongePlugin.java

@@ -49,6 +49,7 @@ import me.lucko.luckperms.common.locale.SimpleLocaleManager;
 import me.lucko.luckperms.common.managers.TrackManager;
 import me.lucko.luckperms.common.managers.impl.GenericTrackManager;
 import me.lucko.luckperms.common.messaging.InternalMessagingService;
+import me.lucko.luckperms.common.messaging.NoopMessagingService;
 import me.lucko.luckperms.common.messaging.RedisMessaging;
 import me.lucko.luckperms.common.plugin.LuckPermsPlugin;
 import me.lucko.luckperms.common.plugin.LuckPermsScheduler;
@@ -222,6 +223,10 @@ public class LPSpongePlugin implements LuckPermsPlugin {
             getLog().warn("Messaging service '" + messagingType + "' not recognised.");
         }
 
+        if (messagingService == null) {
+            messagingService = new NoopMessagingService();
+        }
+
         // setup the update task buffer
         updateTaskBuffer = new BufferedRequest<Void>(1000L, this::doAsync) {
             @Override

sponge/src/main/resources/luckperms.conf

@@ -209,6 +209,9 @@ data {
 # none ==> nothing
 messaging-service="none"
 
+# If LuckPerms should automatically push updates after a change has been made with a command.
+auto-push-updates=true
+
 # Settings for Redis.
 # Port 6379 is used by default; set address to "host:port" if differs
 redis {