Fix Sponge subjects from being unloaded and never reinitialized - closes #124

common/src/main/java/me/lucko/luckperms/common/managers/AbstractManager.java

@@ -41,6 +41,15 @@ import java.util.Map;
  */
 public abstract class AbstractManager<I, T extends Identifiable<I>> implements Manager<I, T> {
 
+    @SuppressWarnings("unchecked")
+    private static <I> I lowerCase(I i) {
+        if (i instanceof String) {
+            return (I) ((String) i).toLowerCase();
+        } else {
+            return i;
+        }
+    }
+
     private final LoadingCache<I, T> objects = CacheBuilder.newBuilder()
             .build(new CacheLoader<I, T>() {
                 @Override
@@ -61,36 +70,30 @@ public abstract class AbstractManager<I, T extends Identifiable<I>> implements M
 
     @Override
     public T getOrMake(I id) {
-        if (id instanceof String) {
+        return objects.getUnchecked(lowerCase(id));
-            return objects.getUnchecked((I) ((String) id).toLowerCase());
-        } else {
-            return objects.getUnchecked(id);
-        }
-
     }
 
     @Override
     public T getIfLoaded(I id) {
-        if (id instanceof String) {
+        return objects.getIfPresent(lowerCase(id));
-            return objects.getIfPresent(((String) id).toLowerCase());
-        } else {
-            return objects.getIfPresent(id);
-        }
     }
 
     @Override
     public boolean isLoaded(I id) {
-        if (id instanceof String) {
+        return objects.asMap().containsKey(lowerCase(id));
-            return objects.asMap().containsKey(((String) id).toLowerCase());
+    }
-        } else {
+
-            return objects.asMap().containsKey(id);
+    @Override
+    public void unload(I id) {
+        if (id != null) {
+            objects.invalidate(lowerCase(id));
         }
     }
 
     @Override
     public void unload(T t) {
         if (t != null) {
-            objects.invalidate(t.getId());
+            unload(t.getId());
         }
     }
 

common/src/main/java/me/lucko/luckperms/common/managers/Manager.java

@@ -66,6 +66,13 @@ public interface Manager<I, T extends Identifiable<I>> extends Function<I, T> {
      */
     boolean isLoaded(I id);
 
+    /**
+     * Removes and unloads the object from the manager
+     *
+     * @param id The object id to unload
+     */
+    void unload(I id);
+
     /**
      * Removes and unloads the object from the manager
      *

sponge/src/main/java/me/lucko/luckperms/sponge/SpongeListener.java

@@ -25,6 +25,7 @@ package me.lucko.luckperms.sponge;
 import me.lucko.luckperms.api.caching.UserData;
 import me.lucko.luckperms.api.context.MutableContextSet;
 import me.lucko.luckperms.common.constants.Message;
+import me.lucko.luckperms.common.core.UuidCache;
 import me.lucko.luckperms.common.core.model.User;
 import me.lucko.luckperms.common.utils.AbstractListener;
 import me.lucko.luckperms.sponge.timings.LPTiming;
@@ -113,7 +114,15 @@ public class SpongeListener extends AbstractListener {
     @Listener(order = Order.LAST)
     public void onClientLeave(ClientConnectionEvent.Disconnect e) {
         try (Timing ignored = plugin.getTimings().time(LPTiming.ON_CLIENT_LEAVE)) {
-            onLeave(e.getTargetEntity().getUniqueId());
+            final UuidCache cache = plugin.getUuidCache();
+
+            final User user = plugin.getUserManager().get(cache.getUUID(e.getTargetEntity().getUniqueId()));
+            if (user != null) {
+                user.unregisterData();
+            }
+
+            // Unload the user from memory when they disconnect;
+            cache.clearCache(e.getTargetEntity().getUniqueId());
         }
     }
 

sponge/src/main/java/me/lucko/luckperms/sponge/managers/SpongeGroupManager.java

@@ -113,23 +113,30 @@ public class SpongeGroupManager implements GroupManager, LPSubjectCollection {
 
     @Override
     public SpongeGroup getOrMake(String id) {
-        return objects.getUnchecked(id);
+        return objects.getUnchecked(id.toLowerCase());
     }
 
     @Override
     public SpongeGroup getIfLoaded(String id) {
-        return objects.getIfPresent(id);
+        return objects.getIfPresent(id.toLowerCase());
     }
 
     @Override
     public boolean isLoaded(String id) {
-        return objects.asMap().containsKey(id);
+        return objects.asMap().containsKey(id.toLowerCase());
+    }
+
+    @Override
+    public void unload(String id) {
+        if (id != null) {
+            objects.invalidate(id.toLowerCase());
+        }
     }
 
     @Override
     public void unload(Group t) {
         if (t != null) {
-            objects.invalidate(t.getId());
+            unload(t.getId());
         }
     }
 

sponge/src/main/java/me/lucko/luckperms/sponge/managers/SpongeUserManager.java

@@ -125,6 +125,7 @@ public class SpongeUserManager implements UserManager, LPSubjectCollection {
         Set<UserIdentifier> set = new HashSet<>();
         for (Map.Entry<UserIdentifier, SpongeUser> user : objects.asMap().entrySet()) {
             if (user.getValue().getSpongeData().shouldCleanup()) {
+                user.getValue().unregisterData();
                 set.add(user.getKey());
             }
         }
@@ -156,10 +157,17 @@ public class SpongeUserManager implements UserManager, LPSubjectCollection {
         return objects.asMap().containsKey(id);
     }
 
+    @Override
+    public void unload(UserIdentifier id) {
+        if (id != null) {
+            objects.invalidate(id);
+        }
+    }
+
     @Override
     public void unload(User t) {
         if (t != null) {
-            objects.invalidate(t.getId());
+            unload(t.getId());
         }
     }
 
@@ -194,9 +202,7 @@ public class SpongeUserManager implements UserManager, LPSubjectCollection {
 
     @Override
     public void cleanup(User user) {
-        if (!plugin.isOnline(plugin.getUuidCache().getExternalUUID(user.getUuid()))) {
+        // Do nothing - this instance uses other means in order to cleanup
-            unload(user);
-        }
     }
 
     @Override

sponge/src/main/java/me/lucko/luckperms/sponge/model/SpongeUser.java

@@ -93,12 +93,10 @@ public class SpongeUser extends User {
             return (now - lastUse) > 600000;
         }
 
-        private boolean hasData() {
+        private void checkData() {
-            if (parent.getUserData() != null) {
+            if (parent.getUserData() == null) {
-                return true;
-            } else {
                 plugin.getLog().warn("User " + parent.getName() + " - " + parent.getUuid() + " does not have any data loaded.");
-                return false;
+                parent.setupData(false);
             }
         }
 
@@ -133,10 +131,7 @@ public class SpongeUser extends User {
         public Tristate getPermissionValue(ContextSet contexts, String permission) {
             logUsage();
             try (Timing ignored = plugin.getTimings().time(LPTiming.USER_GET_PERMISSION_VALUE)) {
-                if (!hasData()) {
+                checkData();
-                    return Tristate.UNDEFINED;
-                }
-
                 return parent.getUserData().getPermissionData(plugin.getService().calculateContexts(contexts)).getPermissionValue(permission);
             }
         }
@@ -155,7 +150,7 @@ public class SpongeUser extends User {
             try (Timing ignored = plugin.getTimings().time(LPTiming.USER_GET_PARENTS)) {
                 ImmutableSet.Builder<SubjectReference> subjects = ImmutableSet.builder();
 
-                if (hasData()) {
+                checkData();
                 for (String perm : parent.getUserData().getPermissionData(plugin.getService().calculateContexts(contexts)).getImmutableBacking().keySet()) {
                     if (!perm.startsWith("group.")) {
                         continue;
@@ -166,7 +161,6 @@ public class SpongeUser extends User {
                         subjects.add(plugin.getService().getGroupSubjects().get(groupName).toReference());
                     }
                 }
-                }
 
                 subjects.addAll(plugin.getService().getUserSubjects().getDefaultSubject().resolve(getService()).getParents(contexts));
                 subjects.addAll(plugin.getService().getDefaults().getParents(contexts));
@@ -179,7 +173,8 @@ public class SpongeUser extends User {
         public Optional<String> getOption(ContextSet contexts, String s) {
             logUsage();
             try (Timing ignored = plugin.getTimings().time(LPTiming.USER_GET_OPTION)) {
-                if (hasData()) {
+                checkData();
+
                 MetaData data = parent.getUserData().getMetaData(plugin.getService().calculateContexts(contexts));
                 if (s.equalsIgnoreCase("prefix")) {
                     if (data.getPrefix() != null) {
@@ -196,7 +191,6 @@ public class SpongeUser extends User {
                 if (data.getMeta().containsKey(s)) {
                     return Optional.of(data.getMeta().get(s));
                 }
-                }
 
                 Optional<String> v = plugin.getService().getUserSubjects().getDefaultSubject().resolve(getService()).getOption(contexts, s);
                 if (v.isPresent()) {