From 111d5b9b6616a7db743032f5b9ba7dcff791c73a Mon Sep 17 00:00:00 2001 From: TheMode Date: Mon, 19 Jul 2021 04:34:42 +0200 Subject: [PATCH] Reduce ItemMeta allocation --- src/main/java/net/minestom/server/item/ItemMeta.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/main/java/net/minestom/server/item/ItemMeta.java b/src/main/java/net/minestom/server/item/ItemMeta.java index f4ae80319..9b6c5b211 100644 --- a/src/main/java/net/minestom/server/item/ItemMeta.java +++ b/src/main/java/net/minestom/server/item/ItemMeta.java @@ -32,8 +32,8 @@ public class ItemMeta implements TagReadable, Writeable { private final Set canDestroy; private final Set canPlaceOn; + private final ItemMetaBuilder metaBuilder; private final NBTCompound nbt; - private final ItemMetaBuilder emptyBuilder; private String cachedSNBT; private ByteBuf cachedBuffer; @@ -50,8 +50,8 @@ public class ItemMeta implements TagReadable, Writeable { this.canDestroy = new HashSet<>(metaBuilder.canDestroy); this.canPlaceOn = new HashSet<>(metaBuilder.canPlaceOn); + this.metaBuilder = metaBuilder; this.nbt = metaBuilder.nbt(); - this.emptyBuilder = metaBuilder.getSupplier().get(); } @Contract(value = "_, -> new", pure = true) @@ -143,7 +143,7 @@ public class ItemMeta implements TagReadable, Writeable { @Contract(value = "-> new", pure = true) protected @NotNull ItemMetaBuilder builder() { - return ItemMetaBuilder.fromNBT(emptyBuilder, nbt); + return ItemMetaBuilder.fromNBT(metaBuilder, nbt); } @Override