Upstream/Minestom
1
0
Fork 0
mirror of https://github.com/Minestom/Minestom.git synced 2025-03-13 07:09:51 +01:00
Code Issues Projects Releases Wiki Activity

Reduce memory allocation

Browse Source
This commit is contained in:
themode 2021-03-21 13:22:49 +01:00
parent 2028009685
commit 126382f55d
2 changed files with 12 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/main/java/net/minestom/server/network/player/NettyPlayerConnection.java
View File

@ -171,11 +171,9 @@ public class NettyPlayerConnection extends PlayerConnection {
return;
} else if (message instanceof ServerPacket) {
final ServerPacket serverPacket = (ServerPacket) message;
final ByteBuf buffer = PacketUtils.createFramedPacket(serverPacket, true);
synchronized (tickBuffer) {
tickBuffer.writeBytes(buffer);
PacketUtils.createFramedPacket(serverPacket, true, tickBuffer);
}
buffer.release();
return;
} else if (message instanceof ByteBuf) {
synchronized (tickBuffer) {

24
src/main/java/net/minestom/server/utils/PacketUtils.java
View File

@ -229,40 +229,38 @@ public final class PacketUtils {
}
/**
* Creates a "framed packet" (packet which can be send and understood by a Minecraft client)
* from a server packet.
* Writes a "framed packet" (packet which can be send and understood by a Minecraft client)
* from a server packet, directly into an output buffer.
* <p>
* Can be used if you want to store a raw buffer and send it later without the additional writing cost.
* Compression is applied if {@link MinecraftServer#getCompressionThreshold()} is greater than 0.
*
* @param serverPacket the server packet to write
* @return the framed packet from the server one
*/
@NotNull
public static ByteBuf createFramedPacket(@NotNull ServerPacket serverPacket, boolean directBuffer) {
public static void createFramedPacket(@NotNull ServerPacket serverPacket, boolean directBuffer, ByteBuf output) {
ByteBuf packetBuf = writePacket(serverPacket);
if (MinecraftServer.getCompressionThreshold() > 0) {
ByteBuf compressedBuf = directBuffer ? BufUtils.getBuffer(true) : Unpooled.buffer();
ByteBuf framedBuf = directBuffer ? BufUtils.getBuffer(true) : Unpooled.buffer();
final Deflater deflater = DEFLATER.get();
compressBuffer(deflater, null, packetBuf, compressedBuf);
packetBuf.release();
frameBuffer(compressedBuf, framedBuf);
frameBuffer(compressedBuf, output);
compressedBuf.release();
return framedBuf;
} else {
ByteBuf framedBuf = directBuffer ? BufUtils.getBuffer(true) : Unpooled.buffer();
frameBuffer(packetBuf, framedBuf);
frameBuffer(packetBuf, output);
packetBuf.release();
return framedBuf;
}
}
@NotNull
public static ByteBuf createFramedPacket(@NotNull ServerPacket serverPacket, boolean directBuffer) {
ByteBuf framedBuf = directBuffer ? BufUtils.getBuffer(true) : Unpooled.buffer();
createFramedPacket(serverPacket, directBuffer, framedBuf);
return framedBuf;
}
}