Upstream/Minestom
1
0
Fork 0
mirror of https://github.com/Minestom/Minestom.git synced 2025-01-04 23:47:59 +01:00
Code Issues Projects Releases Wiki Activity

Improve #getBlock performance

Browse Source 
Signed-off-by: TheMode <themode@outlook.fr>
This commit is contained in:
TheMode 2021-07-13 21:27:58 +02:00
parent 404852b0b1
commit 2dceab7743
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/main/java/net/minestom/server/instance/DynamicChunk.java
View File

@ -48,7 +48,7 @@ public class DynamicChunk extends Chunk {
final var blockDescription = PFBlock.get(block); final var blockDescription = PFBlock.get(block);
columnarOcclusionFieldList.onBlockChanged(x, y, z, blockDescription, 0); columnarOcclusionFieldList.onBlockChanged(x, y, z, blockDescription, 0);
} }
Section section = retrieveSection(y); Section section = getSection(ChunkUtils.getSectionAt(y));
section.setBlockAt(x, y, z, block.stateId()); section.setBlockAt(x, y, z, block.stateId());
final int index = ChunkUtils.getBlockIndex(x, y, z); final int index = ChunkUtils.getBlockIndex(x, y, z);
@ -104,7 +104,9 @@ public class DynamicChunk extends Chunk {
return entry; return entry;
} }
// Retrieve the block from state id // Retrieve the block from state id
final Section section = retrieveSection(y); final Section section = getOptionalSection(y);
if (section == null)
return Block.AIR;
final short blockStateId = section.getBlockAt(x, y, z); final short blockStateId = section.getBlockAt(x, y, z);
return blockStateId > 0 ? return blockStateId > 0 ?
Objects.requireNonNullElse(Block.fromStateId(blockStateId), Block.AIR) : Block.AIR; Objects.requireNonNullElse(Block.fromStateId(blockStateId), Block.AIR) : Block.AIR;
@ -151,8 +153,8 @@ public class DynamicChunk extends Chunk {
this.entries.clear(); this.entries.clear();
} }
private @NotNull Section retrieveSection(int y) { private @Nullable Section getOptionalSection(int y) {
final int sectionIndex = ChunkUtils.getSectionAt(y); final int sectionIndex = ChunkUtils.getSectionAt(y);
return getSection(sectionIndex); return sectionMap.get(sectionIndex);
} }
} }