Upstream/Minestom
1
0
Fork 0
mirror of https://github.com/Minestom/Minestom.git synced 2025-01-20 23:21:24 +01:00
Code Issues Projects Releases Wiki Activity

Comment to remember to fix extension dependency resolution in case we keep separate classloaders for extensions

Browse Source
This commit is contained in:
jglrxavpok 2020-10-25 20:32:50 +01:00
parent 66e85f166e
commit 35f7b27135
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/main/java/net/minestom/server/extensions/ExtensionDependencyResolver.java
View File

@ -32,6 +32,11 @@ public class ExtensionDependencyResolver implements DependencyResolver {
if(extensionMap.containsKey(extensionName)) { if(extensionMap.containsKey(extensionName)) {
DiscoveredExtension ext = extensionMap.get(extensionName); DiscoveredExtension ext = extensionMap.get(extensionName);
// convert extension URLs to subdependencies // convert extension URLs to subdependencies
// FIXME: this is not a deep conversion, this might create an issue in this scenario with different classloaders:
// A depends on an external lib (Ext<-A)
// B depends on A (A<-B)
// When loading B, with no deep conversion, Ext will not be added to the list of dependencies (because it is not a direct dependency)
// But when trying to call/access code from extension A, the parts dependent on Ext won't be inside B's dependencies, triggering a ClassNotFoundException
List<ResolvedDependency> deps = new LinkedList<>(); List<ResolvedDependency> deps = new LinkedList<>();
for(URL u : ext.files) { for(URL u : ext.files) {
deps.add(new ResolvedDependency(u.toExternalForm(), u.toExternalForm(), "", u, new LinkedList<>())); deps.add(new ResolvedDependency(u.toExternalForm(), u.toExternalForm(), "", u, new LinkedList<>()));