Upstream/Minestom
1
0
Fork 0
mirror of https://github.com/Minestom/Minestom.git synced 2024-12-28 12:07:42 +01:00
Code Issues Projects Releases Wiki Activity

Improve viewer loop performance

Browse Source 
Signed-off-by: TheMode <themode@outlook.fr>
This commit is contained in:
TheMode 2021-12-16 14:47:20 +01:00
parent f1c9871800
commit 5c6d0dc7b2
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/main/java/net/minestom/server/utils/ViewEngine.java
View File

@ -124,7 +124,7 @@ public final class ViewEngine {
private final Predicate<T> loopPredicate; private final Predicate<T> loopPredicate;
// The consumers to be called when an entity is added/removed. // The consumers to be called when an entity is added/removed.
public final Consumer<T> addition, removal; public final Consumer<T> addition, removal;
// Contains all the entity ids that are viewable by this option. // Contains all the auto-entity ids that are viewable by this option.
public final RoaringBitmap bitSet = new RoaringBitmap(); public final RoaringBitmap bitSet = new RoaringBitmap();
// 1 if auto, 0 if manual // 1 if auto, 0 if manual
private volatile int auto = 1; private volatile int auto = 1;
@ -277,7 +277,12 @@ public final class ViewEngine {
public void forEach(Consumer<? super Player> action) { public void forEach(Consumer<? super Player> action) {
synchronized (mutex) { synchronized (mutex) {
if (!manualViewers.isEmpty()) manualViewers.forEach(action); if (!manualViewers.isEmpty()) manualViewers.forEach(action);
// Auto if (entity != null) {
viewableOption.bitSet.forEach((int id) ->
action.accept((Player) Entity.getEntity(id)));
return;
}
// Non-entity fallback
final List<List<Player>> auto = ViewEngine.this.viewableOption.references; final List<List<Player>> auto = ViewEngine.this.viewableOption.references;
if (auto != null && viewableOption.isAuto()) { if (auto != null && viewableOption.isAuto()) {
for (List<Player> players : auto) { for (List<Player> players : auto) {