From 8ae02109b9406f9539b1093ef9c807ca0a47a594 Mon Sep 17 00:00:00 2001 From: themode Date: Fri, 24 Dec 2021 10:12:27 +0100 Subject: [PATCH] Avoid unnecessary volatile read --- .../minestom/server/network/packet/server/CachedPacket.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/java/net/minestom/server/network/packet/server/CachedPacket.java b/src/main/java/net/minestom/server/network/packet/server/CachedPacket.java index e8e785242..eefb6290f 100644 --- a/src/main/java/net/minestom/server/network/packet/server/CachedPacket.java +++ b/src/main/java/net/minestom/server/network/packet/server/CachedPacket.java @@ -48,7 +48,7 @@ public final class CachedPacket implements SendablePacket { public @NotNull ByteBuffer body() { FramedPacket cache = updatedCache(); - return cache != null ? cache.body() : PacketUtils.createFramedPacket(packet()); + return cache != null ? cache.body() : PacketUtils.createFramedPacket(packetSupplier.get()); } private @Nullable FramedPacket updatedCache() { @@ -57,7 +57,7 @@ public final class CachedPacket implements SendablePacket { SoftReference ref; FramedPacket cache; if (updated == 0 || ((ref = packet) == null || (cache = ref.get()) == null)) { - cache = PacketUtils.allocateTrimmedPacket(packet()); + cache = PacketUtils.allocateTrimmedPacket(packetSupplier.get()); this.packet = new SoftReference<>(cache); UPDATER.compareAndSet(this, 0, 1); }