Upstream/Minestom
1
0
Fork 0
mirror of https://github.com/Minestom/Minestom.git synced 2025-01-13 19:51:27 +01:00
Code Issues Projects Releases Wiki Activity

heap buffers don't need to be released manually

Browse Source
This commit is contained in:
Felix Cravic 2020-12-08 09:49:29 +01:00
parent b307a979c3
commit 91a000ab31
1 changed files with 1 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/main/java/net/minestom/server/utils/PacketUtils.java
View File

@ -48,20 +48,14 @@ public final class PacketUtils {
final ByteBuf finalBuffer = createFramedPacket(packet, false);
final FramedPacket framedPacket = new FramedPacket(finalBuffer);
// Prevent premature release
final int refIncrease = players.size() - 1;
if (refIncrease > 0)
finalBuffer.retain(refIncrease);
// Send packet to all players
for (Player player : players) {
final PlayerConnection playerConnection = player.getPlayerConnection();
if (playerConnection instanceof NettyPlayerConnection) {
final NettyPlayerConnection nettyPlayerConnection = (NettyPlayerConnection) playerConnection;
nettyPlayerConnection.write(framedPacket).addListener((p) -> finalBuffer.release());
nettyPlayerConnection.write(framedPacket);
} else {
playerConnection.sendPacket(packet);
finalBuffer.release();
}
}
}