Upstream/Minestom
1
0
Fork 0
mirror of https://github.com/Minestom/Minestom.git synced 2024-12-27 03:27:56 +01:00
Code Issues Projects Releases Wiki Activity

Fix Palette test

Browse Source
This commit is contained in:
Eoghanmc22 2022-01-03 21:16:22 -05:00 committed by TheMode
parent a24cb665a9
commit 9327dfaccf
2 changed files with 33 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/main/java/net/minestom/server/instance/palette/PaletteImpl.java
View File

@ -258,8 +258,8 @@ final class PaletteImpl implements Palette, Cloneable {
} }
private static int validateDimension(int dimension) { private static int validateDimension(int dimension) {
if(dimension <= 0) { if(dimension <= 1) {
throw new IllegalArgumentException("Dimension must be greater 0"); throw new IllegalArgumentException("Dimension must be greater 1");
} }
double log2 = Math.log(dimension) / Math.log(2); double log2 = Math.log(dimension) / Math.log(2);

34
src/test/java/net/minestom/server/instance/PaletteTest.java
View File

@ -111,18 +111,46 @@ public class PaletteTest {
@Test @Test
public void dimension() { public void dimension() {
assertThrows(Exception.class, () -> Palette.newPalette(-4, 5, 3, 1));
assertThrows(Exception.class, () -> Palette.newPalette(0, 5, 3, 1)); assertThrows(Exception.class, () -> Palette.newPalette(0, 5, 3, 1));
assertThrows(Exception.class, () -> Palette.newPalette(1, 5, 3, 1)); assertThrows(Exception.class, () -> Palette.newPalette(1, 5, 3, 1));
assertDoesNotThrow(() -> Palette.newPalette(2, 5, 3, 1)); assertDoesNotThrow(() -> Palette.newPalette(2, 5, 3, 1));
assertThrows(Exception.class, () -> Palette.newPalette(3, 5, 3, 1)); assertThrows(Exception.class, () -> Palette.newPalette(3, 5, 3, 1));
assertDoesNotThrow(() -> Palette.newPalette(4, 5, 3, 1)); assertDoesNotThrow(() -> Palette.newPalette(4, 5, 3, 1));
assertThrows(Exception.class, () -> Palette.newPalette(6, 5, 3, 1));
assertDoesNotThrow(() -> Palette.newPalette(16, 5, 3, 1));
} }
private static List<Palette> testPalettes() { private static List<Palette> testPalettes() {
List<Palette> palettes = new ArrayList<>(); List<Palette> palettes = new ArrayList<>();
for (int i = 4; i < 16; i += 2) { palettes.add(Palette.newPalette(2, 5, 3, 1));
palettes.add(Palette.newPalette(i, 5, 3, 1)); palettes.add(Palette.newPalette(4, 5, 3, 1));
} palettes.add(Palette.newPalette(8, 5, 3, 1));
palettes.add(Palette.newPalette(16, 5, 3, 1));
return palettes; return palettes;
} }
@Test
public void bulk() {
var palettes = testPalettes();
for (Palette palette : palettes) {
final int dimension = palette.dimension();
// Place
for (int x = 0; x < dimension; x++) {
for (int y = 0; y < dimension; y++) {
for (int z = 0; z < dimension; z++) {
palette.set(x, y, z, x + y + z);
}
}
}
// Verify
for (int x = 0; x < dimension; x++) {
for (int y = 0; y < dimension; y++) {
for (int z = 0; z < dimension; z++) {
assertEquals(x + y + z, palette.get(x, y, z));
}
}
}
}
}
} }