Upstream/Minestom
1
0
Fork 0
mirror of https://github.com/Minestom/Minestom.git synced 2025-01-27 02:21:38 +01:00
Code Issues Projects Releases Wiki Activity

Use enum for internal ExtensionManager state

Browse Source
This commit is contained in:
mworzala 2021-12-03 21:46:14 -05:00 committed by TheMode
parent d273ff401b
commit d1124be0f3
1 changed files with 18 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
src/main/java/net/minestom/server/extensions/ExtensionManager.java
View File

@ -41,7 +41,9 @@ public class ExtensionManager {
private final File extensionFolder = new File("extensions"); private final File extensionFolder = new File("extensions");
private final File dependenciesFolder = new File(extensionFolder, ".libs"); private final File dependenciesFolder = new File(extensionFolder, ".libs");
private Path extensionDataRoot = extensionFolder.toPath(); private Path extensionDataRoot = extensionFolder.toPath();
private int state = 0; // -1=do not start, 0=not started, 1=started, 2=preinit, 3=init, 4=postinit
private enum State { DO_NOT_START, NOT_STARTED, STARTED, PRE_INIT, INIT, POST_INIT }
private State state = State.NOT_STARTED;
public ExtensionManager() { public ExtensionManager() {
} }
@ -54,7 +56,7 @@ public class ExtensionManager {
* @return true if extensions are loaded in {@link net.minestom.server.MinecraftServer#start(String, int, ResponseDataConsumer)} * @return true if extensions are loaded in {@link net.minestom.server.MinecraftServer#start(String, int, ResponseDataConsumer)}
*/ */
public boolean shouldLoadOnStartup() { public boolean shouldLoadOnStartup() {
return state != -1; return state != State.DO_NOT_START;
} }
/** /**
@ -65,8 +67,8 @@ public class ExtensionManager {
* @param loadOnStartup true to load extensions on startup, false to do nothing * @param loadOnStartup true to load extensions on startup, false to do nothing
*/ */
public void setLoadOnStartup(boolean loadOnStartup) { public void setLoadOnStartup(boolean loadOnStartup) {
Check.stateCondition(state < 1, "Extensions have already been initialized"); Check.stateCondition(state.ordinal() > State.NOT_STARTED.ordinal(), "Extensions have already been initialized");
this.state = loadOnStartup ? 0 : -1; this.state = loadOnStartup ? State.NOT_STARTED : State.DO_NOT_START;
} }
@NotNull @NotNull
@ -102,37 +104,37 @@ public class ExtensionManager {
@ApiStatus.Internal @ApiStatus.Internal
public void start() { public void start() {
if (state == -1) { if (state == State.DO_NOT_START) {
LOGGER.warn("Extension loadOnStartup option is set to false, extensions are therefore neither loaded or initialized."); LOGGER.warn("Extension loadOnStartup option is set to false, extensions are therefore neither loaded or initialized.");
return; return;
} }
Check.stateCondition(state != 0, "ExtensionManager has already been started"); Check.stateCondition(state != State.NOT_STARTED, "ExtensionManager has already been started");
loadExtensions(); loadExtensions();
state = 1; state = State.STARTED;
} }
@ApiStatus.Internal @ApiStatus.Internal
public void gotoPreInit() { public void gotoPreInit() {
if (state == -1) return; if (state == State.DO_NOT_START) return;
Check.stateCondition(state != 1, "Extensions have already done pre initialization"); Check.stateCondition(state != State.STARTED, "Extensions have already done pre initialization");
extensions.values().forEach(Extension::preInitialize); extensions.values().forEach(Extension::preInitialize);
state = 2; state = State.PRE_INIT;
} }
@ApiStatus.Internal @ApiStatus.Internal
public void gotoInit() { public void gotoInit() {
if (state == -1) return; if (state == State.DO_NOT_START) return;
Check.stateCondition(state != 2, "Extensions have already done initialization"); Check.stateCondition(state != State.PRE_INIT, "Extensions have already done initialization");
extensions.values().forEach(Extension::initialize); extensions.values().forEach(Extension::initialize);
state = 3; state = State.INIT;
} }
@ApiStatus.Internal @ApiStatus.Internal
public void gotoPostInit() { public void gotoPostInit() {
if (state == -1) return; if (state == State.DO_NOT_START) return;
Check.stateCondition(state != 3, "Extensions have already done post initialization"); Check.stateCondition(state != State.INIT, "Extensions have already done post initialization");
extensions.values().forEach(Extension::postInitialize); extensions.values().forEach(Extension::postInitialize);
state = 4; state = State.POST_INIT;
} }
// //