From dd1b584cd21f947f45eb3761e9ab6ca54e72e909 Mon Sep 17 00:00:00 2001
From: themode <themode@outlook.fr>
Date: Fri, 30 Aug 2024 23:55:56 +0200
Subject: [PATCH] Add `throws IndexOutOfBoundsException` buffer warning

---
 .../java/net/minestom/server/network/NetworkBuffer.java   | 8 ++++----
 .../net/minestom/server/network/NetworkBufferImpl.java    | 4 ++--
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/main/java/net/minestom/server/network/NetworkBuffer.java b/src/main/java/net/minestom/server/network/NetworkBuffer.java
index 316212279..58ed37ab9 100644
--- a/src/main/java/net/minestom/server/network/NetworkBuffer.java
+++ b/src/main/java/net/minestom/server/network/NetworkBuffer.java
@@ -103,13 +103,13 @@ public sealed interface NetworkBuffer permits NetworkBufferImpl {
         return new NetworkBufferTypeImpl.LazyType<>(supplier);
     }
 
-    <T> void write(@NotNull Type<T> type, @UnknownNullability T value);
+    <T> void write(@NotNull Type<T> type, @UnknownNullability T value) throws IndexOutOfBoundsException;
 
-    <T> @UnknownNullability T read(@NotNull Type<T> type);
+    <T> @UnknownNullability T read(@NotNull Type<T> type) throws IndexOutOfBoundsException;
 
-    <T> void writeAt(long index, @NotNull Type<T> type, @UnknownNullability T value);
+    <T> void writeAt(long index, @NotNull Type<T> type, @UnknownNullability T value) throws IndexOutOfBoundsException;
 
-    <T> @UnknownNullability T readAt(long index, @NotNull Type<T> type);
+    <T> @UnknownNullability T readAt(long index, @NotNull Type<T> type) throws IndexOutOfBoundsException;
 
     void copyTo(long srcOffset, byte @NotNull [] dest, long destOffset, long length);
 
diff --git a/src/main/java/net/minestom/server/network/NetworkBufferImpl.java b/src/main/java/net/minestom/server/network/NetworkBufferImpl.java
index 2617349d2..22b34c791 100644
--- a/src/main/java/net/minestom/server/network/NetworkBufferImpl.java
+++ b/src/main/java/net/minestom/server/network/NetworkBufferImpl.java
@@ -159,14 +159,14 @@ final class NetworkBufferImpl implements NetworkBuffer {
 
     public long advanceWrite(long length) {
         final long oldWriteIndex = writeIndex;
-        writeIndex += length;
+        writeIndex = oldWriteIndex + length;
         return oldWriteIndex;
     }
 
     @Override
     public long advanceRead(long length) {
         final long oldReadIndex = readIndex;
-        readIndex += length;
+        readIndex = oldReadIndex + length;
         return oldReadIndex;
     }