Upstream/Minestom
1
0
Fork 0
mirror of https://github.com/Minestom/Minestom.git synced 2025-02-11 09:51:35 +01:00
Code Issues Projects Releases Wiki Activity

Avoid block allocation if the properties map is the same

Browse Source 
Signed-off-by: TheMode <themode@outlook.fr>
This commit is contained in:
TheMode 2021-09-20 18:09:16 +02:00
parent 25055413ff
commit e65c9f6a79
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/main/java/net/minestom/server/instance/block/BlockImpl.java
View File

@ -92,9 +92,7 @@ final class BlockImpl implements Block {
@Override @Override
public @NotNull Block withProperties(@NotNull Map<@NotNull String, @NotNull String> properties) { public @NotNull Block withProperties(@NotNull Map<@NotNull String, @NotNull String> properties) {
if (properties.isEmpty()) { if (properties.isEmpty()) return this;
return this;
}
if (this.properties.size() == properties.size()) { if (this.properties.size() == properties.size()) {
return compute(properties); // Map should be complete return compute(properties); // Map should be complete
} }
@ -171,6 +169,7 @@ final class BlockImpl implements Block {
} }
private Block compute(Map<String, String> properties) { private Block compute(Map<String, String> properties) {
if (this.properties.equals(properties)) return this;
Block block = propertyEntry.get(properties); Block block = propertyEntry.get(properties);
if (block == null) if (block == null)
throw new IllegalArgumentException("Invalid properties: " + properties + " for block " + this); throw new IllegalArgumentException("Invalid properties: " + properties + " for block " + this);