From f5b8f267d6c0ae06da9671dcc5e99f37df7a9945 Mon Sep 17 00:00:00 2001
From: TheMode <themode@outlook.fr>
Date: Sat, 10 Apr 2021 00:25:50 +0200
Subject: [PATCH] Clone instead of caching

---
 src/main/java/net/minestom/server/item/ItemMeta.java | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

diff --git a/src/main/java/net/minestom/server/item/ItemMeta.java b/src/main/java/net/minestom/server/item/ItemMeta.java
index acd62a6fa..1560decc7 100644
--- a/src/main/java/net/minestom/server/item/ItemMeta.java
+++ b/src/main/java/net/minestom/server/item/ItemMeta.java
@@ -7,7 +7,6 @@ import org.jetbrains.annotations.NotNull;
 import org.jetbrains.annotations.Nullable;
 import org.jglrxavpok.hephaistos.nbt.NBTCompound;
 
-import java.lang.ref.SoftReference;
 import java.util.Collections;
 import java.util.List;
 import java.util.Map;
@@ -29,8 +28,6 @@ public class ItemMeta {
     private final NBTCompound nbt;
     private final ItemMetaBuilder emptyBuilder;
 
-    private SoftReference<NBTCompound> nbtCache;
-
     protected ItemMeta(@NotNull ItemMetaBuilder metaBuilder) {
         this.damage = metaBuilder.damage;
         this.unbreakable = metaBuilder.unbreakable;
@@ -106,12 +103,7 @@ public class ItemMeta {
     }
 
     public @NotNull NBTCompound toNBT() {
-        NBTCompound cache = nbtCache.get();
-        if (cache == null) {
-            cache = nbt.deepClone();
-            nbtCache = new SoftReference<>(cache);
-        }
-        return cache;
+        return nbt.deepClone();
     }
 
     @Override