Upstream/Minestom
1
0
Fork 0
mirror of https://github.com/Minestom/Minestom.git synced 2025-01-09 01:47:54 +01:00
Code Issues Projects Releases Wiki Activity

Fix FireworkEffect byte reading

Browse Source
This commit is contained in:
TheMode 2021-04-13 04:14:32 +02:00
parent 61d2ef2f06
commit fed4e6897a
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/main/java/net/minestom/server/item/firework/FireworkEffect.java
View File

@ -1,13 +1,12 @@
package net.minestom.server.item.firework; package net.minestom.server.item.firework;
import net.minestom.server.chat.ChatColor;
import net.minestom.server.color.Color; import net.minestom.server.color.Color;
import net.minestom.server.exception.ExceptionManager;
import org.apache.commons.lang3.Validate;
import org.jetbrains.annotations.NotNull; import org.jetbrains.annotations.NotNull;
import org.jglrxavpok.hephaistos.nbt.*; import org.jglrxavpok.hephaistos.nbt.NBTCompound;
import java.util.*; import java.util.ArrayList;
import java.util.List;
import java.util.Objects;
public class FireworkEffect { public class FireworkEffect {
@ -18,6 +17,7 @@ public class FireworkEffect {
private final List<Color> fadeColor; private final List<Color> fadeColor;
//FIXME: fix javadoc //FIXME: fix javadoc
/** /**
* Initializes a new firework effect. * Initializes a new firework effect.
* *
@ -60,9 +60,9 @@ public class FireworkEffect {
} }
} }
boolean flicker = compound.containsKey("Flicker") && compound.getByte("Flicker") == 1; boolean flicker = compound.containsKey("Flicker") && compound.getAsByte("Flicker") == 1;
boolean trail = compound.containsKey("Trail") && compound.getByte("Trail") == 1; boolean trail = compound.containsKey("Trail") && compound.getAsByte("Trail") == 1;
FireworkEffectType type = compound.containsKey("Type") ? FireworkEffectType.byId(compound.getByte("Type")) : FireworkEffectType.SMALL_BALL; FireworkEffectType type = compound.containsKey("Type") ? FireworkEffectType.byId(compound.getAsByte("Type")) : FireworkEffectType.SMALL_BALL;
return new FireworkEffect( return new FireworkEffect(