Upstream/MobArena
1
0
Fork 0
mirror of https://github.com/garbagemule/MobArena.git synced 2025-01-07 08:58:23 +01:00
Code Issues Projects Releases Wiki Activity

Guard against exceptions when setting scoreboards for disconnecting players.

Browse Source 
Turns out that a player who disconnects while in the arena is actually still online if you ask the Player object. The setScoreboard() javadoc specifically says it throws an IllegalStateException in that case, so we can just catch and swallow it.

It's unclear what the state of the player's scoreboard is when they rejoin the server, but a borken scoreboard is better than a rogue exception.
This commit is contained in:
Andreas Troelsen 2018-04-23 11:53:24 +02:00
parent 99f57b7128
commit 5d2881383f
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/main/java/com/garbagemule/MobArena/ScoreboardManager.java
View File

@ -44,7 +44,11 @@ public class ScoreboardManager {
* @param player a player
*/
void removePlayer(Player player) {
player.setScoreboard(Bukkit.getScoreboardManager().getMainScoreboard());
try {
player.setScoreboard(Bukkit.getScoreboardManager().getMainScoreboard());
} catch (IllegalStateException e) {
// Happens if the player is logging out, just swallow it
}
}
/**