From 43309dc8418b0618a5846686041d72d0d57448c8 Mon Sep 17 00:00:00 2001 From: rlf Date: Sat, 19 Nov 2016 15:51:11 -0500 Subject: [PATCH] Fixed failing tests (thanks @rlf) * This is the test fixing portion of PR#1746 * This fixes using a HashMap and relying on the order of the values. (cherry picked from commit 8fdc0ad3dad96e6c5a420bafa97ce91e9abfb878) --- .../MultiverseCore/utils/MockWorldFactory.java | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/src/test/java/com/onarandombox/MultiverseCore/utils/MockWorldFactory.java b/src/test/java/com/onarandombox/MultiverseCore/utils/MockWorldFactory.java index fb2223cc..c5b68069 100644 --- a/src/test/java/com/onarandombox/MultiverseCore/utils/MockWorldFactory.java +++ b/src/test/java/com/onarandombox/MultiverseCore/utils/MockWorldFactory.java @@ -24,12 +24,13 @@ import java.util.List; import java.util.Map; import java.util.UUID; import java.util.WeakHashMap; +import java.util.LinkedHashMap; import static org.mockito.Mockito.*; public class MockWorldFactory { - private static final Map createdWorlds = new HashMap(); + private static final Map createdWorlds = new LinkedHashMap(); private static final Map worldUIDS = new HashMap(); private static final Map pvpStates = new WeakHashMap(); @@ -212,13 +213,7 @@ public class MockWorldFactory { } public static List getWorlds() { - // we have to invert the order! - ArrayList myList = new ArrayList(createdWorlds.values()); - List retList = new ArrayList(); - for (int i = (myList.size() - 1); i >= 0; i--) { - retList.add(myList.get(i)); - } - return retList; + return new ArrayList(createdWorlds.values()); } public static void clearWorlds() {