From cee6a4879ab008b5d72d46c3a4a1b39a0357536b Mon Sep 17 00:00:00 2001
From: Ben Woo <30431861+benwoo1110@users.noreply.github.com>
Date: Thu, 21 Nov 2024 09:57:07 +0800
Subject: [PATCH] Implement ExactDestination#fromLocation

---
 .../core/destination/core/ExactDestination.java       | 10 ++++++++++
 .../destination/core/ExactDestinationInstance.java    |  1 +
 .../multiverse/core/destination/DestinationTest.kt    | 11 +++++++++++
 3 files changed, 22 insertions(+)

diff --git a/src/main/java/org/mvplugins/multiverse/core/destination/core/ExactDestination.java b/src/main/java/org/mvplugins/multiverse/core/destination/core/ExactDestination.java
index ab76a9ef..d62f3dfd 100644
--- a/src/main/java/org/mvplugins/multiverse/core/destination/core/ExactDestination.java
+++ b/src/main/java/org/mvplugins/multiverse/core/destination/core/ExactDestination.java
@@ -36,6 +36,16 @@ public class ExactDestination implements Destination<ExactDestination, ExactDest
         return "e";
     }
 
+    /**
+     * Make a new {@link ExactDestinationInstance} from a {@link Location}.
+     *
+     * @param location  The target location
+     * @return A new {@link ExactDestinationInstance}
+     */
+    public @NotNull ExactDestinationInstance fromLocation(@NotNull Location location) {
+        return new ExactDestinationInstance(this, location);
+    }
+
     /**
      * {@inheritDoc}
      */
diff --git a/src/main/java/org/mvplugins/multiverse/core/destination/core/ExactDestinationInstance.java b/src/main/java/org/mvplugins/multiverse/core/destination/core/ExactDestinationInstance.java
index 44c749c4..d8561a43 100644
--- a/src/main/java/org/mvplugins/multiverse/core/destination/core/ExactDestinationInstance.java
+++ b/src/main/java/org/mvplugins/multiverse/core/destination/core/ExactDestinationInstance.java
@@ -31,6 +31,7 @@ public class ExactDestinationInstance extends DestinationInstance<ExactDestinati
      */
     @Override
     public @NotNull Option<Location> getLocation(@NotNull Entity teleportee) {
+        // todo: maybe check if the world is null?
         return Option.of(location);
     }
 
diff --git a/src/test/java/org/mvplugins/multiverse/core/destination/DestinationTest.kt b/src/test/java/org/mvplugins/multiverse/core/destination/DestinationTest.kt
index 20ba04cd..b260ab04 100644
--- a/src/test/java/org/mvplugins/multiverse/core/destination/DestinationTest.kt
+++ b/src/test/java/org/mvplugins/multiverse/core/destination/DestinationTest.kt
@@ -69,6 +69,17 @@ class DestinationTest : TestWithMockBukkit() {
         assertEquals("e:world:1.2,2.0,3.0:10.5:9.5", destination.toString())
     }
 
+    @Test
+    fun `Exact destination instance from location`() {
+        val exactDestination = serviceLocator.getActiveService(ExactDestination::class.java).takeIf { it != null } ?: run {
+            throw IllegalStateException("ExactDestination is not available as a service") }
+
+        val location = Location(world.bukkitWorld.orNull, 1.2, 2.0, 3.0, 9.5F, 10.5F)
+        val destination = exactDestination.fromLocation(location)
+        assertEquals(location, destination.getLocation(player).orNull)
+        assertEquals("e:world:1.2,2.0,3.0:10.5:9.5", destination.toString())
+    }
+
     @Test
     fun `Player destination instance`() {
         assertTrue(destinationsProvider.getDestinationById("pl") is PlayerDestination)