refactor: Rename reason method name with get

This commit is contained in:
Ben Woo 2023-04-14 22:30:25 +08:00
parent 6e72e72fb0
commit fad2890e10
No known key found for this signature in database
GPG Key ID: FB2A3645536E12C8
2 changed files with 14 additions and 14 deletions

View File

@ -16,39 +16,39 @@ public sealed interface Result<S extends SuccessReason, F extends FailureReason>
boolean isFailure(); boolean isFailure();
S successReason(); S getSuccessReason();
F failureReason(); F getFailureReason();
default Result<S, F> onSuccess(Consumer<S> consumer) { default Result<S, F> onSuccess(Consumer<S> consumer) {
if (this.isSuccess()) { if (this.isSuccess()) {
consumer.accept(this.successReason()); consumer.accept(this.getSuccessReason());
} }
return this; return this;
} }
default Result<S, F> onFailure(Consumer<F> consumer) { default Result<S, F> onFailure(Consumer<F> consumer) {
if (this.isFailure()) { if (this.isFailure()) {
consumer.accept(this.failureReason()); consumer.accept(this.getFailureReason());
} }
return this; return this;
} }
default Result<S, F> onSuccessReason(S successReason, Consumer<S> consumer) { default Result<S, F> onSuccessReason(S successReason, Consumer<S> consumer) {
if (this.isSuccess() && this.successReason() == successReason) { if (this.isSuccess() && this.getSuccessReason() == successReason) {
consumer.accept(this.successReason()); consumer.accept(this.getSuccessReason());
} }
return this; return this;
} }
default Result<S, F> onFailureReason(F failureReason, Consumer<F> consumer) { default Result<S, F> onFailureReason(F failureReason, Consumer<F> consumer) {
if (this.isFailure() && this.failureReason() == failureReason) { if (this.isFailure() && this.getFailureReason() == failureReason) {
consumer.accept(this.failureReason()); consumer.accept(this.getFailureReason());
} }
return this; return this;
} }
record Success<F extends FailureReason, S extends SuccessReason>(S successReason) implements Result<S, F> { record Success<F extends FailureReason, S extends SuccessReason>(S getSuccessReason) implements Result<S, F> {
@Override @Override
public boolean isSuccess() { public boolean isSuccess() {
return true; return true;
@ -60,12 +60,12 @@ public sealed interface Result<S extends SuccessReason, F extends FailureReason>
} }
@Override @Override
public F failureReason() { public F getFailureReason() {
throw new NoSuchElementException("No failure reason for success"); throw new NoSuchElementException("No failure reason for success");
} }
} }
record Failure<S extends SuccessReason, F extends FailureReason>(F failureReason) implements Result<S, F> { record Failure<S extends SuccessReason, F extends FailureReason>(F getFailureReason) implements Result<S, F> {
@Override @Override
public boolean isSuccess() { public boolean isSuccess() {
return false; return false;
@ -77,7 +77,7 @@ public sealed interface Result<S extends SuccessReason, F extends FailureReason>
} }
@Override @Override
public S successReason() { public S getSuccessReason() {
throw new NoSuchElementException("No success reason for failure"); throw new NoSuchElementException("No success reason for failure");
} }
} }

View File

@ -69,7 +69,7 @@ public class ResultGroup {
return Option.none(); return Option.none();
} }
return Option.ofOptional(results.stream() return Option.ofOptional(results.stream()
.map(Result::successReason) .map(Result::getSuccessReason)
.filter(successReasonClass::isInstance) .filter(successReasonClass::isInstance)
.map(successReasonClass::cast) .map(successReasonClass::cast)
.findFirst()); .findFirst());
@ -80,7 +80,7 @@ public class ResultGroup {
return Option.none(); return Option.none();
} }
return Option.ofOptional(results.stream() return Option.ofOptional(results.stream()
.map(Result::failureReason) .map(Result::getFailureReason)
.filter(failureReasonClass::isInstance) .filter(failureReasonClass::isInstance)
.map(failureReasonClass::cast) .map(failureReasonClass::cast)
.findFirst()); .findFirst());