Upstream/NoCheatPlus
1
0
Fork 0
mirror of https://github.com/NoCheatPlus/NoCheatPlus.git synced 2025-01-14 19:41:21 +01:00
Code Issues Projects Releases Wiki Activity

Ensure jump boost calculations don't result in negative numbers.

Browse Source
This commit is contained in:
asofold 2015-07-30 01:28:12 +02:00
parent bfd6cb7418
commit 7c194e467e
2 changed files with 23 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
NCPCore/src/main/java/fr/neatmonster/nocheatplus/checks/moving/MovingUtil.java
View File

@ -178,4 +178,16 @@ public class MovingUtil {
} }
} }
/**
* Estimated lift-off distance for jumping, considering the stored jump
* effect.
*
* @param player
* @param data
* @return
*/
public static double estimateJumpLiftOff(final Player player, final MovingData data, final double add) {
return Math.max(0.0, 0.42 + add + 0.2 * data.jumpAmplifier);
}
} }

32
NCPCore/src/main/java/fr/neatmonster/nocheatplus/checks/moving/SurvivalFly.java
View File

@ -332,7 +332,7 @@ public class SurvivalFly extends Check {
} }
else if (!sfDirty && from.isOnClimbable()) { else if (!sfDirty && from.isOnClimbable()) {
// Ladder types. // Ladder types.
vDistanceAboveLimit = vDistClimbable(from, fromOnGround, toOnGround, yDistance, data); vDistanceAboveLimit = vDistClimbable(player, from, fromOnGround, toOnGround, yDistance, data);
} }
else if (!sfDirty && from.isInLiquid() && (Math.abs(yDistance) > 0.2 || to.isInLiquid())) { else if (!sfDirty && from.isInLiquid() && (Math.abs(yDistance) > 0.2 || to.isInLiquid())) {
// Swimming... // Swimming...
@ -374,16 +374,6 @@ public class SurvivalFly extends Check {
} }
} }
// // Check maximal absolute distance (jumping).
// if (!data.sfDirty && yDistance > 0.57 + data.jumpAmplifier * 0.2 && !toOnGround && from.isPassable()) {
// // TODO: Side conditions... from.isPassable is checked because of pistons.
// // TODO: Pistons don't work.
// vDistanceAboveLimit = Math.max(vDistanceAboveLimit, yDistance - 0.53 + data.jumpAmplifier * 0.2);
// tags.add("fastascend");
// }
// TODO: Velocity handling here [concept: set vdistAbove.. almost always]?
// TODO: This might need max(0, for ydiff) // TODO: This might need max(0, for ydiff)
vDistanceAboveLimit = Math.max(vDistanceAboveLimit, to.getY() - data.getSetBackY() - vAllowedDistance); vDistanceAboveLimit = Math.max(vDistanceAboveLimit, to.getY() - data.getSetBackY() - vAllowedDistance);
if (vDistanceAboveLimit > 0) { if (vDistanceAboveLimit > 0) {
@ -401,10 +391,10 @@ public class SurvivalFly extends Check {
// Simple-step blocker. // Simple-step blocker.
// TODO: Complex step blocker: distance to set-back + low jump + accounting info // TODO: Complex step blocker: distance to set-back + low jump + accounting info
if ((resetFrom || data.noFallAssumeGround) && resetTo && vDistanceAboveLimit <= 0D && if ((resetFrom || data.noFallAssumeGround) && resetTo && vDistanceAboveLimit <= 0D &&
yDistance > 0.52 + data.jumpAmplifier * 0.2 && !player.hasPermission(Permissions.MOVING_SURVIVALFLY_STEP)) { yDistance > MovingUtil.estimateJumpLiftOff(player, data, 0.1) && !player.hasPermission(Permissions.MOVING_SURVIVALFLY_STEP)) {
// Exclude a lost-ground case. // Exclude a lost-ground case.
if (!data.noFallAssumeGround || data.sfLastYDist == Double.MAX_VALUE || data.sfLastYDist > 0.0 || yDistance + Math.abs(data.sfLastYDist) > 2.0 * (0.52 + 0.2 * data.jumpAmplifier)) { if (!data.noFallAssumeGround || data.sfLastYDist == Double.MAX_VALUE || data.sfLastYDist > 0.0 || yDistance + Math.abs(data.sfLastYDist) > 2.0 * (MovingUtil.estimateJumpLiftOff(player, data, 0.1))) {
vDistanceAboveLimit = Math.max(vDistanceAboveLimit, Math.abs(from.isOnClimbable() ? yDistance : yDistance - 0.52 + data.jumpAmplifier * 0.2)); // Could adjust if on ladders etc. vDistanceAboveLimit = Math.max(vDistanceAboveLimit, Math.abs(from.isOnClimbable() ? yDistance : yDistance - MovingUtil.estimateJumpLiftOff(player, data, 0.1) )); // Could adjust if on ladders etc.
tags.add("step"); tags.add("step");
} }
} }
@ -722,11 +712,11 @@ public class SurvivalFly extends Check {
*/ */
private boolean lostGround(final Player player, final PlayerLocation from, final PlayerLocation to, final double hDistance, final double yDistance, final boolean sprinting, final MovingData data, final MovingConfig cc) { private boolean lostGround(final Player player, final PlayerLocation from, final PlayerLocation to, final double hDistance, final double yDistance, final boolean sprinting, final MovingData data, final MovingConfig cc) {
// TODO: Confine by max y distance and max/min xz-distance? // TODO: Confine by max y distance and max/min xz-distance?
if (yDistance >= -0.5 && yDistance <= 0.594 + data.jumpAmplifier * 0.2) { if (yDistance >= -0.5 && yDistance <= MovingUtil.estimateJumpLiftOff(player, data, 0.174)) {
// "Mild" Ascending / descending. // "Mild" Ascending / descending.
// Stairs. // Stairs.
// TODO: More safety guards. // TODO: More safety guards.
if (yDistance <= 0.52 + data.jumpAmplifier * 0.2 && from.isAboveStairs()) { if (yDistance <= MovingUtil.estimateJumpLiftOff(player, data, 0.1) && from.isAboveStairs()) {
applyLostGround(player, from, true, data, "stairs"); applyLostGround(player, from, true, data, "stairs");
return true; return true;
} }
@ -1170,7 +1160,7 @@ public class SurvivalFly extends Check {
* @param data * @param data
* @return vDistanceAboveLimit * @return vDistanceAboveLimit
*/ */
private double vDistClimbable(final PlayerLocation from, final boolean fromOnGround, final boolean toOnGround, final double yDistance, final MovingData data) { private double vDistClimbable(final Player player, final PlayerLocation from, final boolean fromOnGround, final boolean toOnGround, final double yDistance, final MovingData data) {
double vDistanceAboveLimit = 0.0; double vDistanceAboveLimit = 0.0;
data.sfNoLowJump = true; data.sfNoLowJump = true;
// TODO: bring in in-medium accounting. // TODO: bring in in-medium accounting.
@ -1184,7 +1174,7 @@ public class SurvivalFly extends Check {
// TODO: yDistance < 0.0 ? // TODO: yDistance < 0.0 ?
if (Math.abs(yDistance) > climbSpeed) { if (Math.abs(yDistance) > climbSpeed) {
if (from.isOnGround(jumpHeight, 0D, 0D, BlockProperties.F_CLIMBABLE)) { if (from.isOnGround(jumpHeight, 0D, 0D, BlockProperties.F_CLIMBABLE)) {
if (yDistance > 0.52 + 0.2 * data.jumpAmplifier) { if (yDistance > MovingUtil.estimateJumpLiftOff(player, data, 0.1)) {
tags.add("climbstep"); tags.add("climbstep");
vDistanceAboveLimit = Math.max(vDistanceAboveLimit, Math.abs(yDistance) - climbSpeed); vDistanceAboveLimit = Math.max(vDistanceAboveLimit, Math.abs(yDistance) - climbSpeed);
} }
@ -1276,7 +1266,7 @@ public class SurvivalFly extends Check {
final double setBackYDistance = to.getY() - data.getSetBackY(); final double setBackYDistance = to.getY() - data.getSetBackY();
// Half block step up. // Half block step up.
if (yDistance <= (sprinting ? 0.594 : 0.5) && hDistance < 0.5 && setBackYDistance <= 1.3 + 0.2 * data.jumpAmplifier && to.isOnGround()) { if (yDistance <= (sprinting ? 0.594 : 0.5) && hDistance < 0.5 && setBackYDistance <= Math.max(0.0, 1.3 + 0.2 * data.jumpAmplifier) && to.isOnGround()) {
if (data.sfLastYDist < 0.0 || yDistance <= 0.5 && from.isOnGround(0.5 - Math.abs(yDistance))) { if (data.sfLastYDist < 0.0 || yDistance <= 0.5 && from.isOnGround(0.5 - Math.abs(yDistance))) {
return applyLostGround(player, from, true, data, "step"); return applyLostGround(player, from, true, data, "step");
} }
@ -1290,7 +1280,7 @@ public class SurvivalFly extends Check {
// && data.sfJumpPhase > 3 <- Seems to be a problem with cake on a block + jump over both mini edges (...). // && data.sfJumpPhase > 3 <- Seems to be a problem with cake on a block + jump over both mini edges (...).
if (data.fromX != Double.MAX_VALUE && yDistance > 0 && data.sfLastYDist < 0.0 && !to.isOnGround()) { if (data.fromX != Double.MAX_VALUE && yDistance > 0 && data.sfLastYDist < 0.0 && !to.isOnGround()) {
// TODO: Check if last-y-dist or sprinting should be considered. // TODO: Check if last-y-dist or sprinting should be considered.
if (setBackYDistance > 0.0 && setBackYDistance <= 1.5D + 0.2 * data.jumpAmplifier || setBackYDistance < 0.0 && Math.abs(setBackYDistance) < 3.0) { if (setBackYDistance > 0.0 && setBackYDistance <= Math.max(0.0, 1.5D + 0.2 * data.jumpAmplifier) || setBackYDistance < 0.0 && Math.abs(setBackYDistance) < 3.0) {
// Interpolate from last to-coordinates to the from // Interpolate from last to-coordinates to the from
// coordinates (with some safe-guard). // coordinates (with some safe-guard).
final double dX = from.getX() - data.fromX; final double dX = from.getX() - data.fromX;
@ -1351,7 +1341,7 @@ public class SurvivalFly extends Check {
} }
// Check for jumping up strange blocks like flower pots on top of other blocks. // Check for jumping up strange blocks like flower pots on top of other blocks.
if (yDistance == 0.0 && data.sfLastYDist > 0.0 && data.sfLastYDist < 0.25 && data.sfJumpPhase <= 6 + data.jumpAmplifier * 3.0 && setBackYDistance > 1.0 && setBackYDistance < 1.5 + 0.2 * data.jumpAmplifier && !to.isOnGround()) { if (yDistance == 0.0 && data.sfLastYDist > 0.0 && data.sfLastYDist < 0.25 && data.sfJumpPhase <= Math.max(0, 6 + data.jumpAmplifier * 3.0) && setBackYDistance > 1.0 && setBackYDistance < Math.max(0.0, 1.5 + 0.2 * data.jumpAmplifier) && !to.isOnGround()) {
// TODO: confine by block types ? // TODO: confine by block types ?
if (from.isOnGround(0.25, 0.4, 0, 0L) ) { if (from.isOnGround(0.25, 0.4, 0, 0L) ) {
// Temporary "fix". // Temporary "fix".