Upstream/NoCheatPlus
1
0
Fork 0
mirror of https://github.com/NoCheatPlus/NoCheatPlus.git synced 2025-03-11 14:09:40 +01:00
Code Issues Projects Releases Wiki Activity

[Bleeding] Simplify passable-ray-tracing.

Browse Source 
Just comment out the from-collides check, since it should be included in
the actual ray-tracing check. Should give some speed-up.
This commit is contained in:
asofold 2013-02-15 18:59:12 +01:00
parent cbe0b5c0d7
commit dbf87093e3
1 changed files with 11 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
NCPCompat/src/main/java/fr/neatmonster/nocheatplus/utilities/PassableRayTracing.java
View File

@ -65,14 +65,14 @@ public class PassableRayTracing extends RayTracing{
// TODO: Other problem (forgot)...
// Check if is already inside.
// TODO: This might be superfluous since below method used.
if (oX >= bounds[0] && oX < bounds[3] && oY >= bounds[1] && oY < bounds[4] && oZ >= bounds[2] && oZ < bounds[5]){
if (!BlockProperties.isPassableWorkaround(blockCache, blockX, blockY, blockZ, oX, oY, oZ, id, 0, 0, 0, 0)){
collides = true;
return true;
}
}
// // Check if is already inside.
// // TODO: This might be superfluous since below method used.
// if (oX >= bounds[0] && oX < bounds[3] && oY >= bounds[1] && oY < bounds[4] && oZ >= bounds[2] && oZ < bounds[5]){
// if (!BlockProperties.isPassableWorkaround(blockCache, blockX, blockY, blockZ, oX, oY, oZ, id, 0, 0, 0, 0)){
// collides = true;
// return true;
// }
// }
// Check extrapolation [all three intervals must be hit].
if (dX < 0){
if (oX < bounds[0]) return true;
@ -104,7 +104,9 @@ public class PassableRayTracing extends RayTracing{
return true;
}
// Does collide (most likely).
// TODO: This is not entirely accurate, needs further exclusion for smaller solid blocks.
// TODO: This is not entirely accurate.
// TODO: Moving such that the full move rect overlaps, but no real collision (diagonal moves).
// TODO: "Wrong" moves through edges of blocks (not sure, needs reproducing).
// (Could allow start-end if passable + check first collision time or some estimate.)
collides = true;
return true;