From e514cc2425e0166ed7e8da8f735de0125ad066f8 Mon Sep 17 00:00:00 2001
From: asofold <asofold@web.de>
Date: Fri, 4 Jan 2013 14:34:42 +0100
Subject: [PATCH] [Bleeding] Account for lag in blockbreak.frequency.

---
 .../checks/blockbreak/Frequency.java          | 23 +++++++++++++++----
 1 file changed, 19 insertions(+), 4 deletions(-)

diff --git a/NCPPlugin/src/main/java/fr/neatmonster/nocheatplus/checks/blockbreak/Frequency.java b/NCPPlugin/src/main/java/fr/neatmonster/nocheatplus/checks/blockbreak/Frequency.java
index ca331e9e..4676b679 100644
--- a/NCPPlugin/src/main/java/fr/neatmonster/nocheatplus/checks/blockbreak/Frequency.java
+++ b/NCPPlugin/src/main/java/fr/neatmonster/nocheatplus/checks/blockbreak/Frequency.java
@@ -25,21 +25,33 @@ public class Frequency extends Check {
         
         // Full period frequency.
         final float fullScore = data.frequencyBuckets.score(cc.frequencyBucketFactor);
-        final float fullTime = cc.frequencyBuckets * cc.frequencyBucketDur;
+        final long fullTime = cc.frequencyBucketDur * cc.frequencyBuckets;
         
         // Short term arrivals.
         final int tick = TickTask.getTick();
         if (tick - data.frequencyShortTermTick < cc.frequencyShortTermTicks){
-        	// Within range, add.
-        	data.frequencyShortTermCount ++;
+        	// Account for server side lag.
+        	final float stLag = cc.lag ? TickTask.getLag(50L * (tick - data.frequencyShortTermTick), true) : 1f;
+        	if (stLag < 1.5){
+            	// Within range, add.
+            	data.frequencyShortTermCount ++;
+        	}
+        	else{
+        		// Too much lag, reset.
+            	data.frequencyShortTermTick = tick;
+            	data.frequencyShortTermCount = 1;
+        	}
         }
         else{
         	data.frequencyShortTermTick = tick;
         	data.frequencyShortTermCount = 1;
         }
         
+        // Account for server side lag.
+        final float fullLag = cc.lag ? TickTask.getLag(fullTime, true) : 1f;
+        
         // Find if one of both or both are violations:
-        final float fullViolation = (fullScore > fullTime) ? (fullScore - fullTime) : 0;
+        final float fullViolation = (fullScore > fullTime * fullLag) ? (fullScore - fullTime * fullLag) : 0;
         final float shortTermWeight = 50f * cc.frequencyShortTermTicks / (float) cc.frequencyShortTermLimit; 
         final float shortTermViolation = (data.frequencyShortTermCount > cc.frequencyShortTermLimit) 
         		? (data.frequencyShortTermCount - cc.frequencyShortTermLimit) * shortTermWeight : 0; 
@@ -47,6 +59,9 @@ public class Frequency extends Check {
         
         boolean cancel = false;
         if (violation > 0){
+        	
+        	// TODO: account for lag spikes !
+        	
         	final double change = violation / 1000;
         	data.frequencyVL += change;
         	cancel = executeActions(player, data.frequencyVL, change, cc.frequencyActions);