2021-06-11 14:02:28 +02:00
|
|
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
|
|
|
From: BillyGalbreath <Blake.Galbreath@GMail.com>
|
|
|
|
|
Date: Sun, 7 Oct 2018 00:54:15 -0500
|
|
|
|
|
Subject: [PATCH] Add sun related API
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
diff --git a/src/main/java/org/bukkit/World.java b/src/main/java/org/bukkit/World.java
|
Rework async chunk api implementation
Firstly, the old methods all routed to the CompletableFuture method.
However, the CF method could not guarantee that if the caller
was off-main that the future would be "completed" on-main. Since
the callback methods used the CF one, this meant that the callback
methods did not guarantee that the callbacks were to be called on
the main thread.
Now, all methods route to getChunkAtAsync(x, z, gen, urgent, cb)
so that the methods with the callback are guaranteed to invoke
the callback on the main thread. The CF behavior remains unchanged;
it may still appear to complete on main if invoked off-main.
Secondly, remove the scheduleOnMain invocation in the async
chunk completion. This unnecessarily delays the callback
by 1 tick.
Thirdly, add getChunksAtAsync(minX, minZ, maxX, maxZ, ...) which
will load chunks within an area. This method is provided as a helper
as keeping all chunks loaded within an area can be complicated to
implement for plugins (due to the lacking ticket API), and is
already implemented internally anyways.
Fourthly, remove the ticket addition that occured with getChunkAt
and getChunkAtAsync. The ticket addition may delay the unloading
of the chunk unnecessarily. It also fixes a very rare timing bug
where the future/callback would be completed after the chunk
unloads.
2024-11-19 07:34:32 +01:00
|
|
|
index f314f8bc5c437c5703c1e093278d9046903ff2c8..a8fe8c2f4327f0bee60eeac565620117f3fde2ee 100644
|
2021-06-11 14:02:28 +02:00
|
|
|
--- a/src/main/java/org/bukkit/World.java
|
|
|
|
|
+++ b/src/main/java/org/bukkit/World.java
|
Rework async chunk api implementation
Firstly, the old methods all routed to the CompletableFuture method.
However, the CF method could not guarantee that if the caller
was off-main that the future would be "completed" on-main. Since
the callback methods used the CF one, this meant that the callback
methods did not guarantee that the callbacks were to be called on
the main thread.
Now, all methods route to getChunkAtAsync(x, z, gen, urgent, cb)
so that the methods with the callback are guaranteed to invoke
the callback on the main thread. The CF behavior remains unchanged;
it may still appear to complete on main if invoked off-main.
Secondly, remove the scheduleOnMain invocation in the async
chunk completion. This unnecessarily delays the callback
by 1 tick.
Thirdly, add getChunksAtAsync(minX, minZ, maxX, maxZ, ...) which
will load chunks within an area. This method is provided as a helper
as keeping all chunks loaded within an area can be complicated to
implement for plugins (due to the lacking ticket API), and is
already implemented internally anyways.
Fourthly, remove the ticket addition that occured with getChunkAt
and getChunkAtAsync. The ticket addition may delay the unloading
of the chunk unnecessarily. It also fixes a very rare timing bug
where the future/callback would be completed after the chunk
unloads.
2024-11-19 07:34:32 +01:00
|
|
|
@@ -1835,6 +1835,16 @@ public interface World extends RegionAccessor, WorldInfo, PluginMessageRecipient
|
2021-06-11 14:02:28 +02:00
|
|
|
*/
|
|
|
|
|
public void setFullTime(long time);
|
|
|
|
|
|
|
|
|
|
+ // Paper start
|
|
|
|
|
+
|
|
|
|
|
+ /**
|
|
|
|
|
+ * Check if it is currently daytime in this world
|
|
|
|
|
+ *
|
|
|
|
|
+ * @return True if it is daytime
|
|
|
|
|
+ */
|
|
|
|
|
+ public boolean isDayTime();
|
|
|
|
|
+ // Paper end
|
|
|
|
|
+
|
|
|
|
|
/**
|
|
|
|
|
* Gets the full in-game time on this world since the world generation
|
|
|
|
|
*
|
|
|
|
|
diff --git a/src/main/java/org/bukkit/entity/Mob.java b/src/main/java/org/bukkit/entity/Mob.java
|
2024-05-26 21:51:15 +02:00
|
|
|
index 63a14bec00d0b23431d1d002139f48a7d0bc2a88..ef89a82669a6c5bf911827b90facf36a2ff26e91 100644
|
2021-06-11 14:02:28 +02:00
|
|
|
--- a/src/main/java/org/bukkit/entity/Mob.java
|
|
|
|
|
+++ b/src/main/java/org/bukkit/entity/Mob.java
|
2022-09-12 13:31:45 +02:00
|
|
|
@@ -20,6 +20,13 @@ public interface Mob extends LivingEntity, Lootable {
|
2021-06-11 14:02:28 +02:00
|
|
|
*/
|
|
|
|
|
@NotNull
|
|
|
|
|
com.destroystokyo.paper.entity.Pathfinder getPathfinder();
|
|
|
|
|
+
|
|
|
|
|
+ /**
|
|
|
|
|
+ * Check if this mob is exposed to daylight
|
|
|
|
|
+ *
|
|
|
|
|
+ * @return True if mob is exposed to daylight
|
|
|
|
|
+ */
|
|
|
|
|
+ boolean isInDaylight();
|
|
|
|
|
// Paper end
|
|
|
|
|
/**
|
2021-09-22 19:23:21 +02:00
|
|
|
* Instructs this Mob to set the specified LivingEntity as its target.
|
