2021-06-11 14:02:28 +02:00
|
|
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
|
|
From: BillyGalbreath <Blake.Galbreath@GMail.com>
|
|
|
|
Date: Fri, 10 Nov 2017 23:03:12 -0500
|
|
|
|
Subject: [PATCH] Option for maximum exp value when merging orbs
|
|
|
|
|
|
|
|
|
|
|
|
diff --git a/src/main/java/org/bukkit/craftbukkit/event/CraftEventFactory.java b/src/main/java/org/bukkit/craftbukkit/event/CraftEventFactory.java
|
2024-04-06 21:53:39 +02:00
|
|
|
index 8866f1d4f19c935edb7eb3c9265a2b65383e5595..608829fa99a197a58505b1e7ca9898e8d6d19aa4 100644
|
2021-06-11 14:02:28 +02:00
|
|
|
--- a/src/main/java/org/bukkit/craftbukkit/event/CraftEventFactory.java
|
|
|
|
+++ b/src/main/java/org/bukkit/craftbukkit/event/CraftEventFactory.java
|
2024-04-06 21:53:39 +02:00
|
|
|
@@ -704,16 +704,30 @@ public class CraftEventFactory {
|
2023-12-05 23:55:31 +01:00
|
|
|
if (entity instanceof net.minecraft.world.entity.ExperienceOrb xp) {
|
2021-06-11 14:02:28 +02:00
|
|
|
double radius = world.spigotConfig.expMerge;
|
|
|
|
if (radius > 0) {
|
2024-01-21 12:11:43 +01:00
|
|
|
+ // Paper start - Maximum exp value when merging; Whole section has been tweaked, see comments for specifics
|
2022-06-09 10:51:45 +02:00
|
|
|
+ final int maxValue = world.paperConfig().entities.behavior.experienceMergeMaxValue;
|
|
|
|
+ final boolean mergeUnconditionally = world.paperConfig().entities.behavior.experienceMergeMaxValue <= 0;
|
2021-06-11 14:02:28 +02:00
|
|
|
+ if (mergeUnconditionally || xp.value < maxValue) { // Paper - Skip iteration if unnecessary
|
|
|
|
+
|
|
|
|
List<Entity> entities = world.getEntities(entity, entity.getBoundingBox().inflate(radius, radius, radius));
|
|
|
|
for (Entity e : entities) {
|
2023-12-05 23:55:31 +01:00
|
|
|
if (e instanceof net.minecraft.world.entity.ExperienceOrb loopItem) {
|
2021-06-14 07:37:57 +02:00
|
|
|
- if (!loopItem.isRemoved()) {
|
2021-06-11 14:02:28 +02:00
|
|
|
+ // Paper start
|
2021-06-14 07:37:57 +02:00
|
|
|
+ if (!loopItem.isRemoved() && !(maxValue > 0 && loopItem.value >= maxValue)) {
|
2021-06-11 14:02:28 +02:00
|
|
|
+ long newTotal = (long)xp.value + (long)loopItem.value;
|
|
|
|
+ if ((int) newTotal < 0) continue; // Overflow
|
|
|
|
+ if (maxValue > 0 && newTotal > (long)maxValue) {
|
|
|
|
+ loopItem.value = (int) (newTotal - maxValue);
|
|
|
|
+ xp.value = maxValue;
|
|
|
|
+ } else {
|
2021-06-14 07:37:57 +02:00
|
|
|
xp.value += loopItem.value;
|
Updated Upstream (Bukkit/CraftBukkit/Spigot) (#10277)
Upstream has released updates that appear to apply and compile correctly.
This update has not been tested by PaperMC and as with ANY update, please do your own testing
Bukkit Changes:
9a80d38c SPIGOT-336, SPIGOT-3366, SPIGOT-5768, SPIGOT-6409, SPIGOT-6861, PR-722: Add EntityRemoveEvent
258086d9 SPIGOT-7417, PR-967: Add Sign#getTargetSide and Sign#getAllowedEditor
ffaba051 SPIGOT-7584: Add missing Tag.ITEMS_NON_FLAMMABLE_WOOD
CraftBukkit Changes:
98b6c1ac7 SPIGOT-7589 Fix NullPointerException when bans expire
a2736ddb0 SPIGOT-336, SPIGOT-3366, SPIGOT-5768, SPIGOT-6409, SPIGOT-6861, PR-1008: Add EntityRemoveEvent
5bf12cb89 SPIGOT-7565: Throw a more descriptive error message when a developer tries to spawn an entity from a CraftBukkit class
76d95fe7e SPIGOT-7417, PR-1343: Add Sign#getTargetSide and Sign#getAllowedEditor
Spigot Changes:
e9ec5485 Rebuild patches
f1b62e0c Rebuild patches
2024-02-23 14:37:33 +01:00
|
|
|
loopItem.discard(null); // Add Bukkit remove cause
|
2024-01-21 12:11:43 +01:00
|
|
|
+ } // Paper end - Maximum exp value when merging
|
2021-06-11 14:02:28 +02:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2023-12-05 23:55:31 +01:00
|
|
|
+ } // Paper end - End iteration skip check - All tweaking ends here
|
|
|
|
}
|
2021-06-11 14:02:28 +02:00
|
|
|
// Spigot end
|
2023-12-05 23:55:31 +01:00
|
|
|
|