2020-05-06 11:48:49 +02:00
|
|
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
2016-03-18 18:23:48 +01:00
|
|
|
From: Aikar <aikar@aikar.co>
|
|
|
|
Date: Fri, 18 Mar 2016 13:17:38 -0400
|
|
|
|
Subject: [PATCH] Default loading permissions.yml before plugins
|
|
|
|
|
|
|
|
Under previous behavior, plugins were not able to check if a player had a permission
|
|
|
|
if it was defined in permissions.yml. there is no clean way for a plugin to fix that either.
|
|
|
|
|
|
|
|
This will change the order so that by default, permissions.yml loads BEFORE plugins instead of after.
|
|
|
|
|
|
|
|
This gives plugins expected permission checks.
|
|
|
|
|
|
|
|
It also helps improve the expected logic, as servers should set the initial defaults, and then let plugins
|
|
|
|
modify that. Under the previous logic, plugins were unable (cleanly) override permissions.yml.
|
|
|
|
|
|
|
|
A config option has been added for those who depend on the previous behavior, but I don't expect that.
|
|
|
|
|
|
|
|
diff --git a/src/main/java/com/destroystokyo/paper/PaperConfig.java b/src/main/java/com/destroystokyo/paper/PaperConfig.java
|
2020-05-06 11:48:49 +02:00
|
|
|
index f402a29b0904a0094ffe6e42dbdc6fbc0912d9d9..6ef5bb9f323da7cbf8cb24d094bf43c4735549b0 100644
|
2016-03-18 18:23:48 +01:00
|
|
|
--- a/src/main/java/com/destroystokyo/paper/PaperConfig.java
|
|
|
|
+++ b/src/main/java/com/destroystokyo/paper/PaperConfig.java
|
2019-05-06 09:20:16 +02:00
|
|
|
@@ -213,4 +213,9 @@ public class PaperConfig {
|
|
|
|
" - Length: " + timeSummary(Timings.getHistoryLength() / 20) +
|
|
|
|
" - Server Name: " + timingsServerName);
|
2016-03-18 18:23:48 +01:00
|
|
|
}
|
|
|
|
+
|
|
|
|
+ public static boolean loadPermsBeforePlugins = true;
|
|
|
|
+ private static void loadPermsBeforePlugins() {
|
|
|
|
+ loadPermsBeforePlugins = getBoolean("settings.load-permissions-yml-before-plugins", true);
|
|
|
|
+ }
|
|
|
|
}
|
|
|
|
diff --git a/src/main/java/org/bukkit/craftbukkit/CraftServer.java b/src/main/java/org/bukkit/craftbukkit/CraftServer.java
|
2020-06-25 16:09:55 +02:00
|
|
|
index af17df4810ef30eba640028dd0b2047ed387eff0..3b61bb5da6adc04eed934885be7ece2b3f4ea74c 100644
|
2016-03-18 18:23:48 +01:00
|
|
|
--- a/src/main/java/org/bukkit/craftbukkit/CraftServer.java
|
|
|
|
+++ b/src/main/java/org/bukkit/craftbukkit/CraftServer.java
|
2020-06-25 16:09:55 +02:00
|
|
|
@@ -395,6 +395,7 @@ public final class CraftServer implements Server {
|
2016-03-18 18:23:48 +01:00
|
|
|
if (type == PluginLoadOrder.STARTUP) {
|
|
|
|
helpMap.clear();
|
|
|
|
helpMap.initializeGeneralTopics();
|
|
|
|
+ if (com.destroystokyo.paper.PaperConfig.loadPermsBeforePlugins) loadCustomPermissions(); // Paper
|
|
|
|
}
|
|
|
|
|
|
|
|
Plugin[] plugins = pluginManager.getPlugins();
|
2020-06-25 16:09:55 +02:00
|
|
|
@@ -414,7 +415,7 @@ public final class CraftServer implements Server {
|
2016-03-18 18:23:48 +01:00
|
|
|
commandMap.registerServerAliases();
|
|
|
|
DefaultPermissions.registerCorePermissions();
|
|
|
|
CraftDefaultPermissions.registerCorePermissions();
|
2019-02-22 04:41:20 +01:00
|
|
|
- loadCustomPermissions();
|
|
|
|
+ if (!com.destroystokyo.paper.PaperConfig.loadPermsBeforePlugins) loadCustomPermissions(); // Paper
|
2016-03-18 18:23:48 +01:00
|
|
|
helpMap.initializeCommands();
|
2019-02-22 04:41:20 +01:00
|
|
|
syncCommands();
|
|
|
|
}
|