Upstream/Paper
1
0
Fork 0
mirror of https://github.com/PaperMC/Paper.git synced 2024-11-29 22:13:42 +01:00
Code Issues Projects Releases Wiki Activity
01c6454ead
Paper/Spigot-Server-Patches/0113-Fix-Bugs-with-Spigot-Mob-Spawn-Logic.patch

61 lines
2.9 KiB
Diff
Raw Normal View History

Update upstream B/CB/S
2018-01-11 06:31:19 +01:00
From f47639cb7c51dfa19cfd33bc6fa1346071430a1b Mon Sep 17 00:00:00 2001
Fix Bugs with Spigot Mob Spawn Logic - Fixes #138 Spigot drastically altered vanilla mob spawn logic and caused a few issues. 1) Used only spawnable chunks vs entire world for entity counting, resulting in ignoring other entities in the world, and causing the world to go over its intended limit. Specially with servers using smaller mob spawn ranges than view distance, as well as affects spawning API 2) Spigot was using 16x16 division instead of vanilla 17x17 division. Issues got worse in 1.9 due to more chunks being loaded due to 1.9 changes, that fall out of the monster spawn radius. This patch returns mob counting to use all loaded chunks, and 17x17 division.
2016-04-15 03:03:57 +02:00
From: Aikar <aikar@aikar.co>
Date: Thu, 14 Apr 2016 21:01:39 -0400
Subject: [PATCH] Fix Bugs with Spigot Mob Spawn Logic
Spigot drastically altered vanilla mob spawn logic and caused a few issues.
1) Used only spawnable chunks vs entire world for entity counting, resulting in ignoring
other entities in the world, and causing the world to go over its intended limit.
Specially with servers using smaller mob spawn ranges than view distance, as well as affects spawning API
2) Spigot was using 16x16 division instead of vanilla 17x17 division.
This patch returns mob counting to use all loaded chunks, and 17x17 division.
Ensure we actually removed entity from chunk before decrementing counts If a plugin hacks into NMS and triggers entity removal, it could result in an entity being attempted to remove from the chunk twice. The 2nd pass will return false, as it did not find the entity in the list. We should not touch entity counts if the entity was not removed, to avoid going negative.
2016-04-16 03:31:12 +02:00
diff --git a/src/main/java/net/minecraft/server/Chunk.java b/src/main/java/net/minecraft/server/Chunk.java
Restructure lighting queue runnable handling Instead of overriding add within the queue, never add runnables to the queue if the light queue is disabled. This change is made to make timings reports and stacktraces less confusing for administrators, who prior to this change, would have seen the lighting queue referenced in both, regardless of whether or not it was enabled. This change should not affect performance, nor is it made with the intent to.
2017-12-22 22:25:01 +01:00
index 300a5619..ecc76a88 100644
Ensure we actually removed entity from chunk before decrementing counts If a plugin hacks into NMS and triggers entity removal, it could result in an entity being attempted to remove from the chunk twice. The 2nd pass will return false, as it did not find the entity in the list. We should not touch entity counts if the entity was not removed, to avoid going negative.
2016-04-16 03:31:12 +02:00
--- a/src/main/java/net/minecraft/server/Chunk.java
+++ b/src/main/java/net/minecraft/server/Chunk.java
Restructure lighting queue runnable handling Instead of overriding add within the queue, never add runnables to the queue if the light queue is disabled. This change is made to make timings reports and stacktraces less confusing for administrators, who prior to this change, would have seen the lighting queue referenced in both, regardless of whether or not it was enabled. This change should not affect performance, nor is it made with the intent to.
2017-12-22 22:25:01 +01:00
@@ -683,7 +683,7 @@ public class Chunk {
Ensure we actually removed entity from chunk before decrementing counts If a plugin hacks into NMS and triggers entity removal, it could result in an entity being attempted to remove from the chunk twice. The 2nd pass will return false, as it did not find the entity in the list. We should not touch entity counts if the entity was not removed, to avoid going negative.
2016-04-16 03:31:12 +02:00
i = this.entitySlices.length - 1;
}
- this.entitySlices[i].remove(entity);
+ if (!this.entitySlices[i].remove(entity)) { return; } // Paper
// Paper start - update counts
if (entity instanceof EntityItem) {
itemCounts[i]--;
Fix Bugs with Spigot Mob Spawn Logic - Fixes #138 Spigot drastically altered vanilla mob spawn logic and caused a few issues. 1) Used only spawnable chunks vs entire world for entity counting, resulting in ignoring other entities in the world, and causing the world to go over its intended limit. Specially with servers using smaller mob spawn ranges than view distance, as well as affects spawning API 2) Spigot was using 16x16 division instead of vanilla 17x17 division. Issues got worse in 1.9 due to more chunks being loaded due to 1.9 changes, that fall out of the monster spawn radius. This patch returns mob counting to use all loaded chunks, and 17x17 division.
2016-04-15 03:03:57 +02:00
diff --git a/src/main/java/net/minecraft/server/SpawnerCreature.java b/src/main/java/net/minecraft/server/SpawnerCreature.java
Update upstream CB/S
2017-06-19 03:36:55 +02:00
index 45a83ae9..2cd06382 100644
Fix Bugs with Spigot Mob Spawn Logic - Fixes #138 Spigot drastically altered vanilla mob spawn logic and caused a few issues. 1) Used only spawnable chunks vs entire world for entity counting, resulting in ignoring other entities in the world, and causing the world to go over its intended limit. Specially with servers using smaller mob spawn ranges than view distance, as well as affects spawning API 2) Spigot was using 16x16 division instead of vanilla 17x17 division. Issues got worse in 1.9 due to more chunks being loaded due to 1.9 changes, that fall out of the monster spawn radius. This patch returns mob counting to use all loaded chunks, and 17x17 division.
2016-04-15 03:03:57 +02:00
--- a/src/main/java/net/minecraft/server/SpawnerCreature.java
+++ b/src/main/java/net/minecraft/server/SpawnerCreature.java
Update upstream B/CB/S
2016-07-16 00:36:53 +02:00
@@ -23,6 +23,15 @@ public final class SpawnerCreature {
Fix Bugs with Spigot Mob Spawn Logic - Fixes #138 Spigot drastically altered vanilla mob spawn logic and caused a few issues. 1) Used only spawnable chunks vs entire world for entity counting, resulting in ignoring other entities in the world, and causing the world to go over its intended limit. Specially with servers using smaller mob spawn ranges than view distance, as well as affects spawning API 2) Spigot was using 16x16 division instead of vanilla 17x17 division. Issues got worse in 1.9 due to more chunks being loaded due to 1.9 changes, that fall out of the monster spawn radius. This patch returns mob counting to use all loaded chunks, and 17x17 division.
2016-04-15 03:03:57 +02:00
// Spigot start - get entity count only from chunks being processed in b
private int getEntityCount(WorldServer server, Class oClass)
{
+ // Paper start - use entire world, not just active chunks. Spigot broke vanilla expectations.
+ if (true) {
+ return server
+ .getChunkProviderServer()
+ .chunks.values()
+ .stream()
+ .collect(java.util.stream.Collectors.summingInt(c -> c.entityCount.get(oClass)));
+ }
+ // Paper end
int i = 0;
Iterator<Long> it = this.b.iterator();
while ( it.hasNext() )
Update Paper to MC 1.11
2016-11-17 03:23:38 +01:00
@@ -126,7 +135,7 @@ public final class SpawnerCreature {
Fix Bugs with Spigot Mob Spawn Logic - Fixes #138 Spigot drastically altered vanilla mob spawn logic and caused a few issues. 1) Used only spawnable chunks vs entire world for entity counting, resulting in ignoring other entities in the world, and causing the world to go over its intended limit. Specially with servers using smaller mob spawn ranges than view distance, as well as affects spawning API 2) Spigot was using 16x16 division instead of vanilla 17x17 division. Issues got worse in 1.9 due to more chunks being loaded due to 1.9 changes, that fall out of the monster spawn radius. This patch returns mob counting to use all loaded chunks, and 17x17 division.
2016-04-15 03:03:57 +02:00
int l1 = limit * i / a; // CraftBukkit - use per-world limits
*/ // Paper end
- if ((mobcnt = getEntityCount(worldserver, enumcreaturetype.a())) <= limit * i / 256) {
+ if ((mobcnt = getEntityCount(worldserver, enumcreaturetype.a())) <= limit * i / 289) { // Paper - use 17x17 like vanilla (a at top of file)
BlockPosition.MutableBlockPosition blockposition_mutableblockposition = new BlockPosition.MutableBlockPosition();
Iterator iterator1 = this.b.iterator();
--
Update upstream B/CB/S
2018-01-11 06:31:19 +01:00
2.14.3
Fix Bugs with Spigot Mob Spawn Logic - Fixes #138 Spigot drastically altered vanilla mob spawn logic and caused a few issues. 1) Used only spawnable chunks vs entire world for entity counting, resulting in ignoring other entities in the world, and causing the world to go over its intended limit. Specially with servers using smaller mob spawn ranges than view distance, as well as affects spawning API 2) Spigot was using 16x16 division instead of vanilla 17x17 division. Issues got worse in 1.9 due to more chunks being loaded due to 1.9 changes, that fall out of the monster spawn radius. This patch returns mob counting to use all loaded chunks, and 17x17 division.
2016-04-15 03:03:57 +02:00
Reference in New Issue Copy Permalink