Paper/Spigot-Server-Patches/0333-Add-entity-count-cache.patch

From 3ac10ee43109b578232e3d127511e761ddc87a1a Mon Sep 17 00:00:00 2001
From: Colin Godsey <crgodsey@gmail.com>
Date: Wed, 8 Aug 2018 10:10:06 -0600
Subject: [PATCH] Add entity count cache


diff --git a/src/main/java/net/minecraft/server/World.java b/src/main/java/net/minecraft/server/World.java
index 004c3ec47..c392595c0 100644
--- a/src/main/java/net/minecraft/server/World.java
+++ b/src/main/java/net/minecraft/server/World.java
@@ -50,10 +50,41 @@ public abstract class World implements GeneratorAccess, IIBlockAccess, AutoClose
     // Spigot start - guard entity list from removals
     public final List<Entity> entityList = new java.util.ArrayList<Entity>()
     {
+        // Paper start - entity count cache
+        @Override
+        public boolean addAll(Collection<? extends Entity> c) {
+            for (Entity e : c) {
+                updateEntityCount(e, true);
+            }
+
+            return super.addAll(c);
+        }
+
+        @Override
+        public boolean removeAll(Collection<?> c) {
+            for (Object e : c) {
+                if (e instanceof Entity) {
+                    updateEntityCount((Entity)e, false);
+                }
+            }
+
+            return super.removeAll(c);
+        }
+
+        @Override
+        public boolean add(Entity e) {
+            updateEntityCount(e, true);
+
+            return super.add(e);
+        }
+
+        // Paper end
+
         @Override
         public Entity remove(int index)
         {
             guard();
+            updateEntityCount(get(index), false); // Paper
             return super.remove( index );
         }
 
@@ -61,6 +92,7 @@ public abstract class World implements GeneratorAccess, IIBlockAccess, AutoClose
         public boolean remove(Object o)
         {
             guard();
+            if (o instanceof Entity) updateEntityCount((Entity)o, false); // Paper
             return super.remove( o );
         }
 
@@ -82,6 +114,7 @@ public abstract class World implements GeneratorAccess, IIBlockAccess, AutoClose
     public final Map<String, EntityHuman> playersByName = Maps.newHashMap(); // Paper - World EntityHuman Lookup Optimizations
     public final List<Entity> k = Lists.newArrayList();
     protected final IntHashMap<Entity> entitiesById = new IntHashMap();
+    private Map<Class<?>, Integer> countCache = new HashMap(); // Paper
     private final long G = 16777215L;
     private int H; public int getSkylightSubtracted() { return this.H; } public void setSkylightSubtracted(int value) { this.H = value;} // Paper - OBFHELPER
     protected int m = (new Random()).nextInt();
@@ -2440,6 +2473,8 @@ public abstract class World implements GeneratorAccess, IIBlockAccess, AutoClose
     }
 
     public int a(Class<?> oclass) {
+        if (true) return getEntityCount(oclass); //Paper - short circuit to cached method
+
         int i = 0;
         Iterator iterator = this.entityList.iterator();
 
@@ -2464,6 +2499,71 @@ public abstract class World implements GeneratorAccess, IIBlockAccess, AutoClose
         return i;
     }
 
+    // Paper start - entity count cache
+    private int countEntityType(Class<?> oclass) {
+        int i = 0;
+        Iterator iterator = this.entityList.iterator();
+
+        while (iterator.hasNext()) {
+            Entity entity = (Entity) iterator.next();
+
+            if (shouldIgnoreForCount(entity)) continue;
+            if (oclass.isAssignableFrom(entity.getClass())) i++;
+        }
+
+        return i;
+    }
+
+    public int getEntityCount(Class<?> oclass) {
+        Integer count = countCache.get(oclass);
+
+        if (count != null) return count;
+
+        count = countEntityType(oclass);
+
+        countCache.put(oclass, count);
+
+        return count;
+    }
+
+    public boolean shouldIgnoreForCount(Entity entity) {
+        if (entity == null) return true;
+
+        if (entity instanceof EntityInsentient) {
+            EntityInsentient entityinsentient = (EntityInsentient) entity;
+            return entityinsentient.isTypeNotPersistent() && entityinsentient.isPersistent();
+        }
+
+        return false;
+    }
+
+    protected void updateEntityCount(Class<?> clazz, boolean incr) {
+        Integer countObject = countCache.get(clazz);
+
+        if (countObject == null) return;
+
+        int count = countObject;
+
+        if (incr) count++;
+        else count--;
+
+        if(count < 0) {
+            e.warn("Entity count cache has gone negative");
+            count = 0;
+        }
+
+        countCache.put(clazz, count);
+    }
+
+    protected void updateEntityCount(Entity entity, boolean incr) {
+        if (shouldIgnoreForCount(entity)) return;
+
+        for (Class<?> clazz = entity.getClass() ; !clazz.equals(Object.class) ; clazz = clazz.getSuperclass()) {
+            updateEntityCount(clazz, incr);
+        }
+    }
+    // Paper end
+
     public void addChunkEntities(Collection<Entity> collection) { a(collection); } // Paper - OBFHELPER
     public void a(Collection<Entity> collection) {
         org.spigotmc.AsyncCatcher.catchOp( "entity world add"); // Spigot
-- 
2.15.2 (Apple Git-101.1)