2019-03-20 01:28:15 +01:00
From c74d9072387dce3b2e4ba0406bb087da22b97176 Mon Sep 17 00:00:00 2001
2018-09-29 04:40:04 +02:00
From: Aikar <aikar@aikar.co>
Date: Fri, 28 Sep 2018 22:27:33 -0400
Subject: [PATCH] Don't recheck type after setting a block
The server does a "Did my update succeed" check after setting
a blocks data to a chunk.
However, writes can not fail outside of a hard error or a
a race condition from multiple threads writing, which is
not something that should ever occur on the server.
So this check is pointless, as if it did occur, the server would
be having data corruption issues anyways.
This provides a small boost to all setType calls.
diff --git a/src/main/java/net/minecraft/server/Chunk.java b/src/main/java/net/minecraft/server/Chunk.java
2019-03-20 01:28:15 +01:00
index fdf062b8b..d848a97bd 100644
2018-09-29 04:40:04 +02:00
--- a/src/main/java/net/minecraft/server/Chunk.java
+++ b/src/main/java/net/minecraft/server/Chunk.java
2019-01-01 04:15:55 +01:00
@@ -558,7 +558,7 @@ public class Chunk implements IChunkAccess {
2018-09-29 04:40:04 +02:00
this.world.n(blockposition);
}
- if (chunksection.getType(i, j & 15, k).getBlock() != block) {
+ if (false && chunksection.getType(i, j & 15, k).getBlock() != block) { // Paper - don't need to recheck this - this would only fail due to non main thread writes which are not supported
return null;
} else {
if (flag1) {
--
2019-03-20 01:28:15 +01:00
2.21.0
2018-09-29 04:40:04 +02:00