mirror of
https://github.com/PaperMC/Paper.git
synced 2024-10-30 07:19:58 +01:00
107 lines
6.5 KiB
Diff
107 lines
6.5 KiB
Diff
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
||
|
From: Tassu <git@tassu.me>
|
||
|
Date: Thu, 13 Sep 2018 08:45:21 +0300
|
||
|
Subject: [PATCH] Implement furnace cook speed multiplier API
|
||
|
|
||
|
Signed-off-by: Tassu <git@tassu.me>
|
||
|
|
||
|
Fixed an issue where a furnace's cook-speed multiplier rounds down
|
||
|
to the nearest Integer when updating its current cook time.
|
||
|
|
||
|
Modified by: Eric Su <ericsu@alumni.usc.edu>
|
||
|
|
||
|
diff --git a/src/main/java/net/minecraft/world/level/block/entity/AbstractFurnaceBlockEntity.java b/src/main/java/net/minecraft/world/level/block/entity/AbstractFurnaceBlockEntity.java
|
||
|
index 52b2b27f8f8b542a930d649ed6904b4bf808906c..627551db52a0ac1aff9f65f9fce7b9e3c07ad475 100644
|
||
|
--- a/src/main/java/net/minecraft/world/level/block/entity/AbstractFurnaceBlockEntity.java
|
||
|
+++ b/src/main/java/net/minecraft/world/level/block/entity/AbstractFurnaceBlockEntity.java
|
||
|
@@ -70,6 +70,7 @@ public abstract class AbstractFurnaceBlockEntity extends BaseContainerBlockEntit
|
||
|
protected NonNullList<ItemStack> items;
|
||
|
public int litTime;
|
||
|
int litDuration;
|
||
|
+ public double cookSpeedMultiplier = 1.0; // Paper - cook speed multiplier API
|
||
|
public int cookingProgress;
|
||
|
public int cookingTotalTime;
|
||
|
protected final ContainerData dataAccess;
|
||
|
@@ -272,6 +273,11 @@ public abstract class AbstractFurnaceBlockEntity extends BaseContainerBlockEntit
|
||
|
this.recipesUsed.put(new ResourceLocation(s), nbttagcompound1.getInt(s));
|
||
|
}
|
||
|
|
||
|
+ // Paper start - cook speed API
|
||
|
+ if (nbt.contains("Paper.CookSpeedMultiplier")) {
|
||
|
+ this.cookSpeedMultiplier = nbt.getDouble("Paper.CookSpeedMultiplier");
|
||
|
+ }
|
||
|
+ // Paper end
|
||
|
}
|
||
|
|
||
|
@Override
|
||
|
@@ -280,6 +286,7 @@ public abstract class AbstractFurnaceBlockEntity extends BaseContainerBlockEntit
|
||
|
nbt.putShort("BurnTime", (short) this.litTime);
|
||
|
nbt.putShort("CookTime", (short) this.cookingProgress);
|
||
|
nbt.putShort("CookTimeTotal", (short) this.cookingTotalTime);
|
||
|
+ nbt.putDouble("Paper.CookSpeedMultiplier", this.cookSpeedMultiplier); // Paper - cook speed multiplier API
|
||
|
ContainerHelper.saveAllItems(nbt, this.items);
|
||
|
CompoundTag nbttagcompound1 = new CompoundTag();
|
||
|
|
||
|
@@ -339,9 +346,9 @@ public abstract class AbstractFurnaceBlockEntity extends BaseContainerBlockEntit
|
||
|
|
||
|
if (blockEntity.isLit() && AbstractFurnaceBlockEntity.canBurn(irecipe, blockEntity.items, i)) {
|
||
|
++blockEntity.cookingProgress;
|
||
|
- if (blockEntity.cookingProgress == blockEntity.cookingTotalTime) {
|
||
|
+ if (blockEntity.cookingProgress >= blockEntity.cookingTotalTime) { // Paper - cook speed multiplier API
|
||
|
blockEntity.cookingProgress = 0;
|
||
|
- blockEntity.cookingTotalTime = AbstractFurnaceBlockEntity.getTotalCookTime(world, blockEntity.recipeType, blockEntity);
|
||
|
+ blockEntity.cookingTotalTime = AbstractFurnaceBlockEntity.getTotalCookTime(world, blockEntity.recipeType, blockEntity, blockEntity.cookSpeedMultiplier);
|
||
|
if (AbstractFurnaceBlockEntity.burn(blockEntity.level, blockEntity.worldPosition, irecipe, blockEntity.items, i)) { // CraftBukkit
|
||
|
blockEntity.setRecipeUsed(irecipe);
|
||
|
}
|
||
|
@@ -441,9 +448,13 @@ public abstract class AbstractFurnaceBlockEntity extends BaseContainerBlockEntit
|
||
|
}
|
||
|
}
|
||
|
|
||
|
- private static int getTotalCookTime(Level world, RecipeType<? extends AbstractCookingRecipe> recipeType, Container inventory) {
|
||
|
- return (world != null) ? (Integer) world.getRecipeManager().getRecipeFor((RecipeType<AbstractCookingRecipe>) recipeType, inventory, world).map(AbstractCookingRecipe::getCookingTime).orElse(200) : 200; // CraftBukkit - SPIGOT-4302 // Eclipse fail
|
||
|
+ // Paper begin - Expose this function so CraftFurnace can correctly scale the total cooking time to a new multiplier
|
||
|
+ public static int getTotalCookTime(Level world, RecipeType<? extends AbstractCookingRecipe> recipeType, Container inventory, final double cookSpeedMultiplier) {
|
||
|
+ /* Scale the recipe's cooking time to the current cookSpeedMultiplier */
|
||
|
+ int cookTime = world != null ? world.getRecipeManager().getRecipeFor((RecipeType<AbstractCookingRecipe>) recipeType, inventory, world).map(AbstractCookingRecipe::getCookingTime).orElse(200) : 200; // CraftBukkit - SPIGOT-4302 // Eclipse fail
|
||
|
+ return (int) Math.ceil (cookTime / cookSpeedMultiplier);
|
||
|
}
|
||
|
+ // Paper end
|
||
|
|
||
|
public static boolean isFuel(ItemStack stack) {
|
||
|
return AbstractFurnaceBlockEntity.getFuel().containsKey(stack.getItem());
|
||
|
@@ -512,7 +523,7 @@ public abstract class AbstractFurnaceBlockEntity extends BaseContainerBlockEntit
|
||
|
}
|
||
|
|
||
|
if (slot == 0 && !flag) {
|
||
|
- this.cookingTotalTime = AbstractFurnaceBlockEntity.getTotalCookTime(this.level, this.recipeType, this);
|
||
|
+ this.cookingTotalTime = AbstractFurnaceBlockEntity.getTotalCookTime(this.level, this.recipeType, this, this.cookSpeedMultiplier);
|
||
|
this.cookingProgress = 0;
|
||
|
this.setChanged();
|
||
|
}
|
||
|
diff --git a/src/main/java/org/bukkit/craftbukkit/block/CraftFurnace.java b/src/main/java/org/bukkit/craftbukkit/block/CraftFurnace.java
|
||
|
index 5028a6388f95a14df8d1590cddd7414d8de5bf78..a05704665f7718b189f0c60ae42c615fce408b0c 100644
|
||
|
--- a/src/main/java/org/bukkit/craftbukkit/block/CraftFurnace.java
|
||
|
+++ b/src/main/java/org/bukkit/craftbukkit/block/CraftFurnace.java
|
||
|
@@ -63,4 +63,20 @@ public abstract class CraftFurnace<T extends AbstractFurnaceBlockEntity> extends
|
||
|
public void setCookTimeTotal(int cookTimeTotal) {
|
||
|
this.getSnapshot().cookingTotalTime = cookTimeTotal;
|
||
|
}
|
||
|
+
|
||
|
+ // Paper start - cook speed multiplier API
|
||
|
+ @Override
|
||
|
+ public double getCookSpeedMultiplier() {
|
||
|
+ return this.getSnapshot().cookSpeedMultiplier;
|
||
|
+ }
|
||
|
+
|
||
|
+ @Override
|
||
|
+ public void setCookSpeedMultiplier(double multiplier) {
|
||
|
+ com.google.common.base.Preconditions.checkArgument(multiplier >= 0, "Furnace speed multiplier cannot be negative");
|
||
|
+ com.google.common.base.Preconditions.checkArgument(multiplier <= 200, "Furnace speed multiplier cannot more than 200");
|
||
|
+ T snapshot = this.getSnapshot();
|
||
|
+ snapshot.cookSpeedMultiplier = multiplier;
|
||
|
+ snapshot.cookingTotalTime = AbstractFurnaceBlockEntity.getTotalCookTime(this.world.getHandle(), snapshot.getCurrentRecipe().getType(), ((CraftInventoryFurnace) this.getInventory()).getInventory(), snapshot.cookSpeedMultiplier); // Update the snapshot's current total cook time to scale with the newly set multiplier
|
||
|
+ }
|
||
|
+ // Paper end
|
||
|
}
|