Upstream/Paper
1
0
Fork 0
mirror of https://github.com/PaperMC/Paper.git synced 2024-09-09 13:28:36 +02:00
Code Issues Projects Releases Wiki Activity
157528a29e
Paper/Spigot-Server-Patches/0195-MC-111699-Ignore-Improper-Anvil-Item-Name-Packets.patch

29 lines
1.3 KiB
Diff
Raw Normal View History

Remove Ignore invalid Marker Icon ID's in maps Spigot has patched this issue inside MapIcon, meaning that we no longer need to maintain this patch; Spigots patch also fixes #668 in that it will verify the length of the array, as well as protect against a negative type value being fetched from the array. Only real change is that Spigots patch returns a MapIcon.Type.PLAYER, instead of the RED_MARKER as originally PR'd by Aikar.
2017-04-22 16:32:06 +02:00
From c36f506b1200efce56cc66a11e2930dcc4803de1 Mon Sep 17 00:00:00 2001
MC-111699: Ignore Improper Anvil Item Name Packets The client is improperly sending Item Name Packets to the server BEFORE the click event. This causes the server to reset before the click event is processed This breaks the ability to rename more than 1 item at a time. See: https://bugs.mojang.com/browse/MC-111699
2017-01-02 08:09:31 +01:00
From: Aikar <aikar@aikar.co>
Date: Mon, 2 Jan 2017 02:07:24 -0500
Subject: [PATCH] MC-111699: Ignore Improper Anvil Item Name Packets
The client is improperly sending Item Name Packets to the server BEFORE
the click event. This causes the server to reset before the click event is processed
This breaks the ability to rename more than 1 item at a time.
See: https://bugs.mojang.com/browse/MC-111699
diff --git a/src/main/java/net/minecraft/server/PlayerConnection.java b/src/main/java/net/minecraft/server/PlayerConnection.java
Remove Ignore invalid Marker Icon ID's in maps Spigot has patched this issue inside MapIcon, meaning that we no longer need to maintain this patch; Spigots patch also fixes #668 in that it will verify the length of the array, as well as protect against a negative type value being fetched from the array. Only real change is that Spigots patch returns a MapIcon.Type.PLAYER, instead of the RED_MARKER as originally PR'd by Aikar.
2017-04-22 16:32:06 +02:00
index 7c2d43ac..cbe5d36d 100644
MC-111699: Ignore Improper Anvil Item Name Packets The client is improperly sending Item Name Packets to the server BEFORE the click event. This causes the server to reset before the click event is processed This breaks the ability to rename more than 1 item at a time. See: https://bugs.mojang.com/browse/MC-111699
2017-01-02 08:09:31 +01:00
--- a/src/main/java/net/minecraft/server/PlayerConnection.java
+++ b/src/main/java/net/minecraft/server/PlayerConnection.java
Update upstream B/CB
2017-04-20 15:22:08 +02:00
@@ -2449,7 +2449,7 @@ public class PlayerConnection implements PacketListenerPlayIn, ITickable {
MC-111699: Ignore Improper Anvil Item Name Packets The client is improperly sending Item Name Packets to the server BEFORE the click event. This causes the server to reset before the click event is processed This breaks the ability to rename more than 1 item at a time. See: https://bugs.mojang.com/browse/MC-111699
2017-01-02 08:09:31 +01:00
String s4 = SharedConstants.a(packetplayincustompayload.b().e(32767));
if (s4.length() <= 30) {
- containeranvil.a(s4);
+ if (!s4.isEmpty() || containeranvil.getSlot(2).getItem().isEmpty()) containeranvil.a(s4); // Paper - Hack Fix for MC-111699
}
} else {
containeranvil.a("");
--
Update bStats implementation
2017-04-22 08:16:45 +02:00
2.12.2
MC-111699: Ignore Improper Anvil Item Name Packets The client is improperly sending Item Name Packets to the server BEFORE the click event. This causes the server to reset before the click event is processed This breaks the ability to rename more than 1 item at a time. See: https://bugs.mojang.com/browse/MC-111699
2017-01-02 08:09:31 +01:00
Reference in New Issue Copy Permalink