2020-05-06 11:48:49 +02:00
|
|
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
2016-02-28 19:34:19 +01:00
|
|
|
From: Sudzzy <originmc@outlook.com>
|
2016-03-01 00:09:49 +01:00
|
|
|
Date: Thu, 3 Mar 2016 02:50:31 -0600
|
2018-06-18 23:27:33 +02:00
|
|
|
Subject: [PATCH] Configurable inter-world teleportation safety
|
2016-02-28 19:34:19 +01:00
|
|
|
|
2018-06-18 23:27:33 +02:00
|
|
|
People are able to abuse the way Bukkit handles teleportation across worlds since it provides a built in teleportation
|
|
|
|
safety check.
|
2016-02-28 19:34:19 +01:00
|
|
|
|
2018-06-18 23:27:33 +02:00
|
|
|
To abuse the safety check, players are required to get into a location deemed unsafe by Bukkit e.g. be within a chest
|
|
|
|
or door block. While they are in this block, they accept a teleport request from a player within a different world. Once
|
|
|
|
the player teleports, Minecraft will recursively search upwards for a safe location, this could eventually land within a
|
|
|
|
player's skybase.
|
2016-02-28 19:34:19 +01:00
|
|
|
|
|
|
|
Example setup to perform the glitch: http://puu.sh/ng3PC/cf072dcbdb.png
|
2018-06-18 23:27:33 +02:00
|
|
|
The wanted destination was on top of the emerald block however the player ended on top of the diamond block.
|
|
|
|
This only is the case if the player is teleporting between worlds.
|
2016-02-28 19:34:19 +01:00
|
|
|
|
2016-03-01 00:09:49 +01:00
|
|
|
diff --git a/src/main/java/com/destroystokyo/paper/PaperWorldConfig.java b/src/main/java/com/destroystokyo/paper/PaperWorldConfig.java
|
2020-05-06 11:48:49 +02:00
|
|
|
index cd47a4ca069df26969de3051c2aac80540093818..abbf59bb91021821876a8960e8f77fac24457ec4 100644
|
2016-03-01 00:09:49 +01:00
|
|
|
--- a/src/main/java/com/destroystokyo/paper/PaperWorldConfig.java
|
|
|
|
+++ b/src/main/java/com/destroystokyo/paper/PaperWorldConfig.java
|
2020-01-18 18:28:32 +01:00
|
|
|
@@ -198,4 +198,9 @@ public class PaperWorldConfig {
|
2016-03-01 00:09:49 +01:00
|
|
|
portalSearchRadius = getInt("portal-search-radius", 128);
|
2020-01-18 18:28:32 +01:00
|
|
|
portalCreateRadius = getInt("portal-create-radius", 16);
|
2016-03-01 00:09:49 +01:00
|
|
|
}
|
|
|
|
+
|
|
|
|
+ public boolean disableTeleportationSuffocationCheck;
|
|
|
|
+ private void disableTeleportationSuffocationCheck() {
|
|
|
|
+ disableTeleportationSuffocationCheck = getBoolean("disable-teleportation-suffocation-check", false);
|
|
|
|
+ }
|
|
|
|
}
|
2016-02-28 19:34:19 +01:00
|
|
|
diff --git a/src/main/java/org/bukkit/craftbukkit/entity/CraftPlayer.java b/src/main/java/org/bukkit/craftbukkit/entity/CraftPlayer.java
|
2020-10-17 10:18:39 +02:00
|
|
|
index 671cab3efd94b81b0d71af3e096ffe9108d36258..2cc50f8d91c4ea8632ad72fce6aa585916ca8dd7 100644
|
2016-02-28 19:34:19 +01:00
|
|
|
--- a/src/main/java/org/bukkit/craftbukkit/entity/CraftPlayer.java
|
|
|
|
+++ b/src/main/java/org/bukkit/craftbukkit/entity/CraftPlayer.java
|
2020-10-17 10:18:39 +02:00
|
|
|
@@ -783,7 +783,7 @@ public class CraftPlayer extends CraftHumanEntity implements Player {
|
2016-02-28 19:34:19 +01:00
|
|
|
if (fromWorld == toWorld) {
|
|
|
|
entity.playerConnection.teleport(to);
|
|
|
|
} else {
|
2020-06-25 13:00:35 +02:00
|
|
|
- server.getHandle().moveToWorld(entity, toWorld, true, to, true);
|
|
|
|
+ server.getHandle().moveToWorld(entity, toWorld, true, to, !toWorld.paperConfig.disableTeleportationSuffocationCheck); // Paper
|
2016-02-28 19:34:19 +01:00
|
|
|
}
|
|
|
|
return true;
|
|
|
|
}
|